From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C40AEA0C51; Wed, 21 Jul 2021 16:20:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07CF54068B; Wed, 21 Jul 2021 16:20:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 7112A4014D for ; Wed, 21 Jul 2021 16:20:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626877231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v/kOzAQ5ekZYiinfrY9zkSCF2Qk80Yhbm91EBa85U9s=; b=NPtKXWERu+ZgLYl8OzLU/hoitceCr8tF0XBuluXoZgxOhCcmEc+Ix89JGg4DfX8k4ekxQG ih4mDkTwYcp2ayxP64MJQ8kGvt+1VnKS2Zvpngec+u+6GcltX2oO3Jzf+WbF4PDZixDXnR IPQDrj4S2uNTRqf/naNedALUyyMLlEo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-W75FZgquNDmNC2Tz81oH2A-1; Wed, 21 Jul 2021 10:20:30 -0400 X-MC-Unique: W75FZgquNDmNC2Tz81oH2A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 928EE804142; Wed, 21 Jul 2021 14:20:28 +0000 (UTC) Received: from [10.36.110.10] (unknown [10.36.110.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43A535C1BB; Wed, 21 Jul 2021 14:20:27 +0000 (UTC) To: Cheng Jiang , Chenbo.Xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, yvonnex.yang@intel.com, stable@dpdk.org References: <20210602042802.31943-1-cheng1.jiang@intel.com> <20210719081022.12949-1-cheng1.jiang@intel.com> <20210719081022.12949-2-cheng1.jiang@intel.com> From: Maxime Coquelin Message-ID: <6d7c99cb-9f0e-0947-9c73-5c818c9a9748@redhat.com> Date: Wed, 21 Jul 2021 16:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210719081022.12949-2-cheng1.jiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/5] vhost: fix async vhost ops return type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/19/21 10:10 AM, Cheng Jiang wrote: > The async vhost callback ops should return negative value when there > are something wrong in the callback, so the return type should be > changed into int32_t. The issue in vhost example is also fixed. > > Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") > Fixes: 819a71685826 ("vhost: fix async callback return type") > Fixes: 6b3c81db8bb7 ("vhost: simplify async copy completion") > Fixes: abec60e7115d ("examples/vhost: support vhost async data path") > Fixes: 873e8dad6f49 ("vhost: support packed ring in async datapath") > Cc: stable@dpdk.org > > Signed-off-by: Cheng Jiang > --- > examples/vhost/ioat.c | 4 +-- > examples/vhost/ioat.h | 4 +-- > lib/vhost/rte_vhost_async.h | 8 ++--- > lib/vhost/virtio_net.c | 61 ++++++++++++++++++++++++++++++++----- > 4 files changed, 61 insertions(+), 16 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime