From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1C54B98
 for <dev@dpdk.org>; Sun, 12 Aug 2018 12:59:47 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 B9763280057; Sun, 12 Aug 2018 10:59:45 +0000 (UTC)
Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sun, 12 Aug
 2018 11:59:36 +0100
To: Qi Zhang <qi.z.zhang@intel.com>, <thomas@monjalon.net>,
 <gaetan.rivet@6wind.com>, <anatoly.burakov@intel.com>,
 <arybchenko@solarflare.com>
CC: <konstantin.ananyev@intel.com>, <dev@dpdk.org>,
 <bruce.richardson@intel.com>, <ferruh.yigit@intel.com>,
 <benjamin.h.shelton@intel.com>, <narender.vangati@intel.com>
References: <20180607123849.14439-1-qi.z.zhang@intel.com>
 <20180810004213.44497-1-qi.z.zhang@intel.com>
 <20180810004213.44497-5-qi.z.zhang@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <6d9012c0-80ea-f273-2de0-a836631d7257@solarflare.com>
Date: Sun, 12 Aug 2018 13:59:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180810004213.44497-5-qi.z.zhang@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [85.187.13.33]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24026.003
X-TM-AS-Result: No-2.405500-8.000000-10
X-TMASE-MatchedRID: 7ySqCuYCpfgOwH4pD14DsPHkpkyUphL9pwnFZnn+VHx+YesuCgkiXLVB
 g3BYepMMTDwuCv4MwrGlpQB16HZmbQy9rayvx/sOEhGH3CRdKUUpWss5kPUFdKdrpTvh7T6o67z
 KQiK/wKzM4GPKXwuE0zLaKLaWub4PTX7PJ/OU3vKDGx/OQ1GV8mMVPzx/r2cb+gtHj7OwNO2Ohz
 Oa6g8KrZmubcM7zqhpOAefptjTF+T8B/fixFIpOO8XAgJk8ku37rsbEBS3VQVMm3T9ibKNuKYZW
 Acp6/olb9qavfjCn2ETpWKBaCxhcuL59MzH0po2K2yzo9Rrj9wPoYC35RuihKPUI7hfQSp5eCBc
 UCG1aJiUTGVAhB5EbQ==
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--2.405500-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24026.003
X-MDID: 1534071586-3cbMQcKlXiPN
Subject: Re: [dpdk-dev] [PATCH v14 4/6] drivers/net: enable hotplug on
 secondary process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Aug 2018 10:59:47 -0000

On 10.08.2018 03:42, Qi Zhang wrote:
> Attach port from secondary should ignore devargs since the private
> device is not necessary to support. Also previously, detach port on
> a secondary process will mess primary process and cause the same
> device can't be attached back again. A secondary process should use
> rte_eth_dev_release_port_secondary to release a port.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

For me, it looks like duplication of the same code logic in
all vdev drivers. I'd say that remove should not be called
at all in the case of secondary process. Also I'd consider
to introduce separate callback for probe in the case of
secondary process: it would make it clear if secondary is
supported and enforce authors to think about secondary
process specifics on probe. As far as I can see it is always
absolutely different branch with own code.