From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A471E43E33;
	Wed, 10 Apr 2024 13:37:13 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 89C8E402CF;
	Wed, 10 Apr 2024 13:37:13 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 2F603402C7
 for <dev@dpdk.org>; Wed, 10 Apr 2024 13:37:12 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.163.174])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VF12B1X13ztS82;
 Wed, 10 Apr 2024 19:34:26 +0800 (CST)
Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242])
 by mail.maildlp.com (Postfix) with ESMTPS id ACF9D14038F;
 Wed, 10 Apr 2024 19:37:09 +0800 (CST)
Received: from [10.67.121.175] (10.67.121.175) by
 kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.2.1544.4; Wed, 10 Apr 2024 19:37:08 +0800
Message-ID: <6db61bde-eb34-d7e5-cb46-c08a3268a2a4@huawei.com>
Date: Wed, 10 Apr 2024 19:37:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
To: Yuying Zhang <yuying.zhang@intel.com>, Aman Singh
 <aman.deep.singh@intel.com>, Thomas Monjalon <thomas@monjalon.net>,
 "ferruh.yigit@amd.com >> Ferruh Yigit" <ferruh.yigit@amd.com>,
 <andrew.rybchenko@oktetlabs.ru>, <ivan.malov@arknetworks.am>,
 <dekelp@nvidia.com>, <psatheesh@marvell.com>, <adrien.mazarguil@6wind.com>,
 fengchengwen <fengchengwen@huawei.com>, Huisong Li <lihuisong@huawei.com>,
 Dengdui Huang <huangdengdui@huawei.com>
From: Jie Hai <haijie1@huawei.com>
Subject: question about eth and vlan item in flow pattern
CC: "dev@dpdk.org" <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.175]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 kwepemf500004.china.huawei.com (7.202.181.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi, all,

I have some questions about the sub-options for ``VLAN`` and ``ETH`` item.

According to the documentation, ``has_vlan`` is sub-option of ``ETH``
item and it means that the pattern contains at least one vlan.
The ``VLAN`` item is used to match tagged packets and have some
sub-options such as ``vid``, ``tci``, etc.

If we combine them, what should the effect be?
For instance,

rule-0: flow create 0 ingress pattern  eth  has_vlan is 1 / vlan  / end 
actions queue index 2 / end
rule-1: flow create 0 ingress pattern  eth  has_vlan is 1 / vlan vid is 
10 / end actions queue index 2 / end

For rule-0, should it match single-tagged packets only or multi-tagged 
only or both?
That is to say, which one will take effect, `has_vlan is 1`  or `vlan` 
or both?

For rule-2, which packets should it match, with inner VLAN id 10, or 
outer VLAN id 10, or both 10?

The hns3 driver supports only the exact matching of VLAN numer.
And it is planned to adapt ``has_vlan`` and ``has_more_vlan`` to the
meaning of one VLAN for hns3 driver. Therefore, if the preceding 
combinations are supported, we need to confirm the exact meanings.

So, what are your views on the above question?