From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05D33A04B1; Wed, 23 Sep 2020 11:04:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E198B1DBFB; Wed, 23 Sep 2020 11:04:51 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EDD671DBE1 for ; Wed, 23 Sep 2020 11:04:50 +0200 (CEST) IronPort-SDR: joTmIrJldlyjV++eQpC8/0O1oFjxuLc+wTErvDrrheInrPCOkkFp7dc5ye74RlhDGzvVsNfnjH z6k2Q5kHgY6A== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="158186620" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="158186620" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 02:04:50 -0700 IronPort-SDR: p38pIrFxnRYlX6rvjTKzQ6GnYVJmvC1zwLtCHyNrHcK8M/k+TGRKsKmClyHL3AIYToz+1tAkYF UEhYZ8VtIWeg== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305298226" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 02:04:48 -0700 To: Li Zhang , dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com References: <20200908100636.4575-1-lizh@nvidia.com> <20200909033434.31059-1-lizh@nvidia.com> From: Ferruh Yigit Message-ID: <6de9d63f-f4ba-9cac-0f00-24cdf609f9b6@intel.com> Date: Wed, 23 Sep 2020 10:04:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200909033434.31059-1-lizh@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/2020 4:34 AM, Li Zhang wrote: > From: lizh > > Ability to distinguish ICMP identifier fields in packets. > Dstinguish ICMP sequence number field too. > Already supports ICMP code and type fields in current version. > Existing fields in ICMP header contain the required information. > ICMP header already is supported and no code change in RTE FLOW. > Extend testpmd CLI to include the fields of ident and sequence number. > One example: > flow create 0 ingress pattern eth / ipv4 / > icmp code is 1 ident is 5 seq is 6 / > end actions count / queue index 0 / end > The ICMP packet with code 1, identifier 5 and > sequence number 6 will be matched. > It will implement action counter and forward to queue 0. > > Signed-off-by: Li Zhang > Reviewed-by: Ferruh Yigit