From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5EE561B2A9 for ; Thu, 16 Nov 2017 18:06:41 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2017 09:06:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,404,1505804400"; d="scan'208";a="2596989" Received: from gmirsonx-mobl.ger.corp.intel.com (HELO [10.252.130.159]) ([10.252.130.159]) by FMSMGA003.fm.intel.com with ESMTP; 16 Nov 2017 09:06:39 -0800 To: Adrien Mazarguil , "Wiles, Keith" Cc: Olivier Matz , "Wu, Jingjing" , "dev@dpdk.org" , Thomas Monjalon References: <1510234868-31053-1-git-send-email-adrien.mazarguil@6wind.com> <48C2CD08-29E1-444C-BF60-B96BE58865A5@intel.com> <20171116092356.GM24849@6wind.com> From: Ferruh Yigit Message-ID: <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com> Date: Thu, 16 Nov 2017 09:06:39 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171116092356.GM24849@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 17:06:41 -0000 On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: <...> >> I do not agree it has severed DPDK well, just look at test-pmd and the hoops people have to jump thru to get a new command or variation of an existing command integrated into test-pmd it is very difficult. Also if you look at the command sets in test-pmd they are very odd in that similar commands can some times be set up completely different as cmdline is too rigid and difficult to use. > > Testpmd is indeed messy, but this is not librte_cmdline's fundamental fault > in my opinion, more likely the result of using a copy/paste approach to new > commands due to lack of time or interest in making things nicer than the > bare minimum to validate features. There's no design direction for it hence > the lack of uniformity in the command hierarchy. Unrelated to cmdline discussion +1 for this paragraph.