From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CEDE2A0096 for ; Wed, 5 Jun 2019 10:44:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1B101B9B0; Wed, 5 Jun 2019 10:44:53 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 295011B9A0 for ; Wed, 5 Jun 2019 10:44:52 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 195888006C; Wed, 5 Jun 2019 08:44:51 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 5 Jun 2019 09:44:45 +0100 To: Stephen Hemminger , CC: Rami Rosen References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605010852.28395-1-stephen@networkplumber.org> <20190605010852.28395-2-stephen@networkplumber.org> From: Andrew Rybchenko Message-ID: <6e011b50-8168-ddeb-6c31-869dee837333@solarflare.com> Date: Wed, 5 Jun 2019 11:44:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190605010852.28395-2-stephen@networkplumber.org> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24658.003 X-TM-AS-Result: No-8.508500-8.000000-10 X-TMASE-MatchedRID: 6otD/cJAac3mLzc6AOD8DfHkpkyUphL9Qa2sDHLkQ05wGpdgNQ0JrGTt zQhB9g+GUjwC4PXX8BpBbDwRtwcItc9tfSEZlKTRKJYo5K4P1qQ/P58z9vIC2d9RlPzeVuQQ73T jDvilQQkx2oxY5cMAlPPRInVHc/9wgB6Y+mzEn4XbQWbwc1jeYRdoyFlJ5UUMOzrXChUtBAQqs1 mzdI2mNqRGASDuetHKr/EwLya77ldx6NqeNlYcmOa55w05lWyq0HrzChKWs8vDv5dDcuT2eVUu4 dMbNIOZ/dD/o+ecn6Adw3jH6W1gvaTCGfFuDW355BgEdUqqANR9LQinZ4QefL6qvLNjDYTwsuf7 RWbvUtz66w6vTIwLSCrJhLSjJRVmOxCE/j1I5T0fcl9mpROId9EXu0SmYxd9O+tkrQMyWqMDhQZ NKG3T+sH2QyE3krVJCPYO/oqwntGmGfEvxnD2Ai+8sp5KlRGdY+9m0Fvy8sWwUf0Plng4kMsrCi 2xP4gNaqMdnWQRhPQB1TOG0+iZm7QisFQPfmoc+crICkOzqvho8XToPf/MOed9DL3QbsIdVlxr1 FJij9s= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.508500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24658.003 X-MDID: 1559724291-gIxPtQhPqcjY Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 1/6] net/rte_ether: deinline non-critical functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/5/19 4:08 AM, Stephen Hemminger wrote: > Formatting ethernet address and getting a random value are > not in critical path so they should not be inlined. > > Signed-off-by: Stephen Hemminger > Acked-by: Rami Rosen Meson build is lost plus one nit below. Other than that: Reviewed-by: Andrew Rybchenko [...] > diff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map > index 26c06e7c7ae7..dae6e420cded 100644 > --- a/lib/librte_net/rte_net_version.map > +++ b/lib/librte_net/rte_net_version.map > @@ -13,6 +13,13 @@ DPDK_17.05 { > > } DPDK_16.11; > > +DPDK_19.08 { > + global: > + > + eth_random_addr; > + eth_format_addr; rte_ prefix is lost > +} DPDK_17.05; > + > EXPERIMENTAL { > global: >