From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A737A04C8; Fri, 18 Sep 2020 10:47:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 958601D930; Fri, 18 Sep 2020 10:47:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 064781D92D for ; Fri, 18 Sep 2020 10:47:48 +0200 (CEST) IronPort-SDR: +a3BXDhvXqTJpUhbU80l8MdYlQMxQ3jlFxR6wV/O36R/s1UaNQmNFZDC6qWhLXSRD8rtGNPXvW nCT/5n8+sBaQ== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="139896914" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="139896914" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 01:47:48 -0700 IronPort-SDR: xp/0YF8bjg9Rn5K3rbWbDZ2sghL429M/2Y6fN+QDfzIGkzo0GTna++Zio103+Ug+9GfhdK3Tpw V7CfreNS44BQ== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484112958" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248]) ([10.213.227.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 01:47:46 -0700 To: Stephen Hemminger , Haiyue Wang Cc: dev@dpdk.org, Olivier Matz References: <20200904054020.77648-1-haiyue.wang@intel.com> <20200907015651.956011-1-haiyue.wang@intel.com> <20200908075336.7d75195c@hermes.lan> From: Ferruh Yigit Message-ID: <6e0f03bb-f395-efc1-ca33-16f9b6b8928c@intel.com> Date: Fri, 18 Sep 2020 09:47:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200908075336.7d75195c@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net: adjust the header length parse size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2020 3:53 PM, Stephen Hemminger wrote: > On Mon, 7 Sep 2020 09:56:50 +0800 > Haiyue Wang wrote: > >> Enlarge the L3 and tunnel header length from 8-bit to 16-bit to handle >> the bigger headers. And reorder the fields to avoid creating a structure >> hole. >> >> Signed-off-by: Haiyue Wang >> --- >> v2: use bit field to avoid creating a structure hole. >> v3: use basic type and reorder to avoid structure hole. >> --- >> lib/librte_net/rte_net.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h >> index 94b06d9ee..434435ffa 100644 >> --- a/lib/librte_net/rte_net.h >> +++ b/lib/librte_net/rte_net.h >> @@ -20,11 +20,11 @@ extern "C" { >> */ >> struct rte_net_hdr_lens { >> uint8_t l2_len; >> - uint8_t l3_len; >> - uint8_t l4_len; >> - uint8_t tunnel_len; >> uint8_t inner_l2_len; >> - uint8_t inner_l3_len; >> + uint16_t l3_len; >> + uint16_t inner_l3_len; >> + uint16_t tunnel_len; >> + uint8_t l4_len; >> uint8_t inner_l4_len; >> }; >> > > Acked-by: Stephhen Hemminger > Applied to dpdk-next-net/main, thanks.