From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 380C8A04B5; Thu, 29 Oct 2020 09:28:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BA03BE8B; Thu, 29 Oct 2020 09:28:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id E744ABE89 for ; Thu, 29 Oct 2020 09:28:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603960118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WCj1fWu2Im9q6VFggWxAIWvOMKptRBFELBnj0pKlT/g=; b=O2PahzYS95sYSgDPbs9XMUoo6cSTVa44J6sDzZDN8cs+2TH+9IzGIztIPd/cmvy1RSqhpZ yg4E+py8zKHpSG9idREuJS+oVBsi04DrouF4/r00kI1D2wUj5Tf+BV3aROFKTWiFM+8RLI JRuGPeFW34Jfg+reuN7mBPzzRltNMcI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-8_zkpQSuNUuIFdMFsOWVdQ-1; Thu, 29 Oct 2020 04:28:36 -0400 X-MC-Unique: 8_zkpQSuNUuIFdMFsOWVdQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30C3A1018F78; Thu, 29 Oct 2020 08:28:35 +0000 (UTC) Received: from [10.36.110.11] (unknown [10.36.110.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EBFB5B4AA; Thu, 29 Oct 2020 08:28:31 +0000 (UTC) To: Patrick Fu , dev@dpdk.org, chenbo.xia@intel.com References: <20201026101042.4102442-1-patrick.fu@intel.com> <20201027020608.4103145-1-patrick.fu@intel.com> From: Maxime Coquelin Message-ID: <6e12004b-b03b-ea96-be26-c0f062225962@redhat.com> Date: Thu, 29 Oct 2020 09:28:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201027020608.4103145-1-patrick.fu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] vhost: fix guest/host physical address conversion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/20 3:06 AM, Patrick Fu wrote: > gpa_to_hpa() function almost always fails due to the wrong setup of > the binary tree search key. Since there has already been a similar > function gpa_to_first_hpa() available in the vhost, instead of fixing > the issue in its original logic, gpa_to_hpa() function is rewritten to > be a wrapper of the gpa_to_first_hpa() to avoid code redundancy. > > Fixes: e246896178e6 ("vhost: get guest/host physical address mappings") > Fixes: faa9867c4da2 ("vhost: use binary search in address conversion") > > Signed-off-by: Patrick Fu > --- > v2: > - minor rewordings on commit message & title > Applied to dpdk-next-virtio/main. Thanks! Maxime