From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34F1B45C99; Fri, 8 Nov 2024 11:18:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06B2E402ED; Fri, 8 Nov 2024 11:18:35 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 86844402DF; Fri, 8 Nov 2024 11:18:33 +0100 (CET) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XlFJf4wjWz6D9F6; Fri, 8 Nov 2024 18:18:26 +0800 (CST) Received: from frapeml100007.china.huawei.com (unknown [7.182.85.133]) by mail.maildlp.com (Postfix) with ESMTPS id F0490140133; Fri, 8 Nov 2024 18:18:31 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100007.china.huawei.com (7.182.85.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 8 Nov 2024 11:18:31 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Fri, 8 Nov 2024 11:18:31 +0100 From: Konstantin Ananyev To: Bruce Richardson , Andre Muezerie CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code Thread-Topic: [PATCH v5 08/20] net/ice: remove use of VLAs for Windows built code Thread-Index: AQHbMXeXI12WOH4yFk+zoxEhBfWpabKtAvgAgAAo1mA= Date: Fri, 8 Nov 2024 10:18:31 +0000 Message-ID: <6e36b497009b4a2dbc598435bdd44ef6@huawei.com> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1731026691-1529-1-git-send-email-andremue@linux.microsoft.com> <1731026691-1529-9-git-send-email-andremue@linux.microsoft.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.150.173] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > Title for this patch is incorrect. Does it belong merged with the next > patch in series? Yes, seems like oringianl title get lost, I think it needs to be: gro: fix overwrite unprocessed packets https://patchwork.dpdk.org/project/dpdk/patch/20240523162604.2600-2-konstan= tin.v.ananyev@yandex.ru/ >=20 > On Thu, Nov 07, 2024 at 04:44:39PM -0800, Andre Muezerie wrote: > > From: Konstantin Ananyev > > > > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into accoun= t > > that first entries in pkts[] can be already occupied by > > un-processed packets. > > > > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") > > Cc: stable@dpdk.org > > > > Signed-off-by: Konstantin Ananyev > > Acked-by: Ferruh Yigit > > --- > > lib/gro/rte_gro.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/gro/rte_gro.c b/lib/gro/rte_gro.c > > index d824eebd93..db86117609 100644 > > --- a/lib/gro/rte_gro.c > > +++ b/lib/gro/rte_gro.c > > @@ -327,7 +327,7 @@ rte_gro_reassemble_burst(struct rte_mbuf **pkts, > > /* Flush all packets from the tables */ > > if (do_vxlan_tcp_gro) { > > i +=3D gro_vxlan_tcp4_tbl_timeout_flush(&vxlan_tcp_tbl, > > - 0, pkts, nb_pkts); > > + 0, &pkts[i], nb_pkts - i); > > } > > > > if (do_vxlan_udp_gro) { > > -- > > 2.34.1 > >