From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A49243260; Wed, 1 Nov 2023 13:55:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCFD40151; Wed, 1 Nov 2023 13:55:20 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2069.outbound.protection.outlook.com [40.107.95.69]) by mails.dpdk.org (Postfix) with ESMTP id 5F2CD400EF for ; Wed, 1 Nov 2023 13:55:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6UgjfavwJhLwAVHVn4d4i9UBixHs9aUtH2nkYumSchHuUiYSZ5coS2h1XTEKzf/LDp/C/5MDbkeLKn/r15zD841DyZHgwrGJSonJ29LLneA1T9uUDsLmeIFPZegAxcQ1h6ynuYqsgDWYPO4bfjBYQMnSHnj6JOhzHrh0Nr3s1eNSioKfTR8IwSqptOLfJsYU/HgWfoSm3U1Y83cC5wPBRIiF2MEb11GmZB43Yln9hWLaBVc5c/Jj/E8Gjd6b7bqfO0Jz46+QDzVzqwCZ1eFXiJVCqtQrg2qGWuHtm5lgfWyaGcyS5HkI1nXhe9/ziJoWAh/3ESaZFkjxBiT1XefMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zMJC7BB1dMxE8bAYYQfNg9/Qar8HN4meY3je9hx9OUE=; b=hxt+prVm+TB7gMe19zOTJHpsi2UWoSZl5cNDfEHZKQyASRvsCxb3g5JrcFZF6iMtkmqydUsYzKxdWgcquTK4r9p7VVl5H4DVSs2mWgjLDOdpz72MsR7XAEYyXyI1DJ5LzJg/2KgMp8i97cJFM1bMHqfNMz8bAd/OgFVyFZPMr7RZ6iCtQhlZX+FlFYUll58fS5xwhaS5pfqJ9r5COItIYLKcQEbdv67BmfUdg4utNGhzDiPybdpeKCmiNLbOL1Bbg4JYzvDSmy3TWZrj36sWm86trBv1LyvEi+G5F3nwxpkGW3lFQD8398zJJbT189wQxOw9ftcuOflOud2mRjuZIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zMJC7BB1dMxE8bAYYQfNg9/Qar8HN4meY3je9hx9OUE=; b=TK3R3vjhTrDgj+hko149kTeoQhw43JW5hRVAjEGAnw+LUumXqfJIaoMDXdju+Q7UWd6wgtG9xHuDUb3WaQE5qFTIPfndlkLIn4o/VMyYnNzq2Bt7qa1s5gX8L5LyaP1dbtnhW1+UuDXAJf5kkRGNulhn9MrG32YKlHO+xmXHBAs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8085.namprd12.prod.outlook.com (2603:10b6:208:400::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Wed, 1 Nov 2023 12:55:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Wed, 1 Nov 2023 12:55:15 +0000 Message-ID: <6e52da03-7e1a-4b5c-8c4b-f568cbcba1d7@amd.com> Date: Wed, 1 Nov 2023 12:55:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/9] ethdev: overwrite some comment related to RSS Content-Language: en-US To: "lihuisong (C)" , Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ori Kam Cc: fengchengwen@huawei.com, liudongdong3@huawei.com References: <20231027092836.445224-1-haijie1@huawei.com> <20231028014611.4086500-1-haijie1@huawei.com> <20231028014611.4086500-2-haijie1@huawei.com> <3b98d4cf-5111-35d4-4b39-a2d61bbf42d5@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <3b98d4cf-5111-35d4-4b39-a2d61bbf42d5@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8085:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c8993db-73ea-4bb5-e562-08dbdad9cacc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uHFkLS02z/0YQ0gAfVMn42W5k4UKAot28FExfnRFoiXJq15Qhgva1FtbSyojdFxArPgbsVJG4osDqfEe1L4AAI+y1oB+oYZ2CCZvd2YthNBPqCR6DI13p7mcQAouSXHkkIpNgCT+pK2UloB5IJXvcpOf9R2zxC2ZtCT2utsFlwViK4MlQ6IEhUqumjxfm+v18o7McVXyueN+jwQvY8PftDJ4RZABhLvNLzpO7gj5nAq+SfriQH247Thbg75bqUlxQoj+OAMUo5geqmRZ+YzPh+WRSIe96fg4sjIkJHXpVA3PXZpyiZ1tFBv+g3YL/QhviuFypsi2IiYRmF2MFHa9pOL5l8wiIIkGMXbgpGEl4gRU2UzwOgeBnT+KKjn0KLbJc3oAqizWdMGr20dR5SriNfgEklzKjzOM+3kZgtVLUEyBo8ZMN9KYdpSdNmm4v/ZsxeARRdY3LZN6KPEJFCmqrgWXmjR3WFFqqM8RmzAPPk+Oa7ywumGq7oUTG95zjH4uyjdTlTjOr+JKkmdepYhuQLiqKM0cSpnMLcHxwEr3dQMTvANRSXD5uMQteNiDR0nYhjDpRCL37du26ynhPWlHwF1k5u9N0aakIJJZBL5ngZWwkSysh7yr7Lxz/zu2cmgDNUVFqO8aG6YMwdJWpBJCRA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(366004)(39860400002)(346002)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(31686004)(26005)(6512007)(2616005)(38100700002)(31696002)(86362001)(36756003)(83380400001)(8676002)(5660300002)(2906002)(478600001)(53546011)(6666004)(4326008)(8936002)(66946007)(316002)(66476007)(44832011)(6486002)(66556008)(41300700001)(110136005)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGZRTmsrL3ZJREVpZXA3ckJydUdrNzB0dk10YzBpTFhzRkRJbldzSzd5cy82?= =?utf-8?B?V05TbVlIQXU2SUd0Q1dPM2wzOHhNRlJERURSRXRsTFp5TFFNUzYwaDZrUlNZ?= =?utf-8?B?S3A1enhVcHh6eW5CV1lWaGp5cTg1ZExaRlphRGVPU3JtQUhGZDlUZTdGZVg0?= =?utf-8?B?ZnNhVFZlaEZMdk5pMGdsS3hWallNUFh6emM5cjR3ZmNNNE1LWWJ2WkcxT2NJ?= =?utf-8?B?TVhNdkZDZ0ppbXc1c3lGWHRvTHVDWVhwNGpaQllDOC9kcmlUWFhweVVQTWlm?= =?utf-8?B?WXJkcTZnVUdmcnNUNnBxSG52SzJqdDIwVVgwcnM2NWs2SmNtTGttWHJwMGdN?= =?utf-8?B?WFY1VGhUek55MjVmL0RYdmdjbEFTNGk0USs0OFpveWxMZ2YvQnVBWHlRMkxj?= =?utf-8?B?bXM0bGtLdTVGYWpEUS9ZK2NZWFhJWDVnQWVPZThQaEVwc1lkRTFlMUNzLzYx?= =?utf-8?B?aWhZVmJEc05UeFBRZTRHWjJubk1oUVpnU3YzNmFPZlo5L2ZFdXZHUEZEMjlE?= =?utf-8?B?NlFBUFQxVUlBTFJOR3FZSzUwZGxGWUhScHhmMmtGNFcyUFVWNFFhOGdtbmpP?= =?utf-8?B?RzlSTWtPZVAySmFMc0VJaEIwRmhoc2JIME5CL1o3YktBREhURmVnRzIzb1ZX?= =?utf-8?B?UENvVXJxa1pnQ0xHZDdubER3TXE3c0RQK2llVXMvamFPSHFlSlZodE5TR01s?= =?utf-8?B?Ym9ROTZSMHhCMWFwdWZYVUlKTHRkQTNZaXRFc25xTDMvVHd1ZTA4MTRUV1ZC?= =?utf-8?B?eGNrcjNsU3B6Q2ViY3ZWS3UyMzhTZFhubXBwR0ZwSGFLelVISk5BZlZ5R05n?= =?utf-8?B?TS9iOXVXMDVoWFcwU2x2NkR0SkZVQlBPclZNY3YzbkhTTi9NQzhzWUQ1TzZy?= =?utf-8?B?NXRjcXZISnQrZElzSmRVOGprcU11TGNiaWs4OGo2QXJDN3kwWTRpZ3Y4VU9Q?= =?utf-8?B?QzlzUldNeE9IYnhzcnlYUmJkRDJpS0tWQkZNNUlreHBJeEVJcGNEeGlmUG83?= =?utf-8?B?M1BSL3crS2hSYVU4ZzI4cG5rQXUxNDU0ZnpEdFhwV1VkR0xzemFWbnZHNGpP?= =?utf-8?B?Rjh4ZlczbWh4MDh4dkVleDVkR21TTCtPYnd3d2FXZTdXbENING1BdXZEMUhy?= =?utf-8?B?a2pJTmdEZ1lqL2xHV0tZSGNReTNETWVQd1ZLcEEwdm9CYW5XYm5xbFgyT2Yr?= =?utf-8?B?N3NIQldYZ09iYzBrRDNiNjlyQVVzYUdPekRLQytBamdLdUdsSWYreUg5ZVMw?= =?utf-8?B?YnVvbWUySGVKYkhMR2ZUYUtoRC9TMkpTeXJGVURnTHBCUEhvNDhLQjhqU0Rn?= =?utf-8?B?U2pPcklKd0k3T1hwUmlGT2wzVk9BMXR6elpQSzR4Z0cyRDA2R01PVXhrTkxU?= =?utf-8?B?RC94UW1jNE9vVVN0QjdBbzZFQ0hhVFRZaWdCMy91TFpYeFBsQ2ZwNHFQTXRD?= =?utf-8?B?a3BnUnUzSFIvZnhscTlPcnZVcFZmMEwvayt1N0VXdlh5WnN1TElOZms2TE9o?= =?utf-8?B?NVRmb29KcFJoQUdXRkVjZTJRcERoWTJqY0NtbWR6Ryt6amsyNnNYNzB3eUxB?= =?utf-8?B?NGFrY2swVENtUXc1NEpDWkhYMExIT0lsUkxSbERZaXA3MFpCWnkvRGdQdGR0?= =?utf-8?B?WFBBWUU2TWFQNXJqbHRyakRmK1BTOFV4YW5LS0lYUmsvaUdubk9odDRDRDRE?= =?utf-8?B?NVFIV1pBbmE4S0JIdkRwWVpLYUJ3a2JTQ2JoOWhpSDJQb2xnemxydU0wZWFv?= =?utf-8?B?QjM1Z21NOHR6U3pEa0pNSE5LSmFYTXFNQStaSzh2SVhla2VHbFRDOG90U1JJ?= =?utf-8?B?MXFLZE5PRHQyVGgzbzl3L2pXd3E4d2MwZERHNFZBamlWbWRQOWZqK2w1UVdL?= =?utf-8?B?djJmc3V5T212V2lqM3ZlSXhNUjBWTHJYMWVHSXhCWThHVVdXOUdRckhWT1N2?= =?utf-8?B?UDJwTUlNR3lPbFFuZkhjaXVUQzFCWXlvTFlIN2R0MmZ3c0VPMWdUYzhBNno3?= =?utf-8?B?bS81RnNuVEhwK2RCVlAwZEh1d0xDN0o4RFBBeHIwQlhvcjZ5S1lqcjd0QkJ2?= =?utf-8?B?M2FxdzIxa2pKc2ZhTjBpT1FNMTNuYzNKSDRvMlRxcTc1REVQUWR1QkFjV2Qv?= =?utf-8?Q?lIwO4MCh7PG8hlBj/hoUqG5g9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c8993db-73ea-4bb5-e562-08dbdad9cacc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 12:55:15.0560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CPvqcuv37ezXI23Jd09Qs9KafPBjgzQY5keM533h233lq+XKIZFobe7Ym7hgELLb X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8085 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/28/2023 3:41 AM, lihuisong (C) wrote: > > 在 2023/10/28 9:46, Jie Hai 写道: >> 1. overwrite the comments of fields of 'rte_eth_rss_conf'. >> 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. >> >> Signed-off-by: Jie Hai >> --- >>   lib/ethdev/rte_ethdev.h | 33 ++++++++++++++++++--------------- >>   lib/ethdev/rte_flow.h   |  1 + >>   2 files changed, 19 insertions(+), 15 deletions(-) >> >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> index 2fd3cd808dbf..37fd5afef48a 100644 >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_ethdev.h >> @@ -448,24 +448,27 @@ struct rte_vlan_filter_conf { >>   /** >>    * A structure used to configure the Receive Side Scaling (RSS) feature >>    * of an Ethernet port. >> - * If not NULL, the *rss_key* pointer of the *rss_conf* structure points >> - * to an array holding the RSS key to use for hashing specific header >> - * fields of received packets. The length of this array should be >> indicated >> - * by *rss_key_len* below. Otherwise, a default random hash key is >> used by >> - * the device driver. >> - * >> - * The *rss_key_len* field of the *rss_conf* structure indicates the >> length >> - * in bytes of the array pointed by *rss_key*. To be compatible, this >> length >> - * will be checked in i40e only. Others assume 40 bytes to be used as >> before. >> - * >> - * The *rss_hf* field of the *rss_conf* structure indicates the >> different >> - * types of IPv4/IPv6 packets to which the RSS hashing must be applied. >> - * Supplying an *rss_hf* equal to zero disables the RSS feature. >>    */ >>   struct rte_eth_rss_conf { >> -    uint8_t *rss_key;    /**< If not NULL, 40-byte hash key. */ >> +    /** >> +     * In rte_eth_dev_rss_hash_conf_get(), the *rss_key_len* should be >> +     * greater than or equal to the hash_key_size which get from >> > Is this added the new comment? > Suggest that the "rss_key_len" field should be equal to the > hash_key_size from dev_info_get(). > Because many PMDs, like, hns3, i40e, ice and mlx5, check it in driver > based on the condition that the rss_key_len field must be equal to the > hash_key_size when the rss_key is not NULL. > IMO, it is better that this check should be added in ethdev layer. > +1 to add check in ethdev layer >> +     * rte_eth_dev_info_get() API. And the *rss_key* should contain >> at least >> +     * *rss_key_len* bytes. If not meet these requirements, the query >> result > > here "rss_key_len" should be "hash_key_size", right? > >> +     * is unreliable even the operation returns success. > s/even/even if >> +     * >> +     * In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), the >> +     * *rss_key_len* indicates the length of the *rss_key* in bytes of >> +     * the array pointed by *rss_key*. Drivers are free to ignore the >> +     * *rss_key_len* and assume key length is 40 bytes. >> > please modify the comment: "Drivers are free to ignore the *rss_key_len* > and assume key length is 40 bytes. " > Actually, most of PMDs, like, hns3, i40e, mlx, do not configure RSS hash > key if rss_key is NULL and treat it as not updating the hash key. > This is not for the case where rss_key is NULL, most driver use hardcoded 40 bytes as rss key len, so they don't check the rss_key_len, only some drivers use not 40 bytes length, that is why above comment is correct I think. >> +     */ >> +    uint8_t *rss_key; >>       uint8_t rss_key_len; /**< hash key length in bytes. */ >> -    uint64_t rss_hf;     /**< Hash functions to apply - see below. */ >> +    /** >> +     * Indicates the type of packets or the specific part of packets to >> +     * which RSS hashing is to be applied. >> +     */ >> +    uint64_t rss_hf; >>   }; >>     /* >> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h >> index edefa34c10da..25f1dffd1f30 100644 >> --- a/lib/ethdev/rte_flow.h >> +++ b/lib/ethdev/rte_flow.h >> @@ -3226,6 +3226,7 @@ struct rte_flow_query_count { >>    * Hash function types. >>    */ >>   enum rte_eth_hash_function { >> +    /** DEFAULT means driver decides which hash algorithm to pick. */ >>       RTE_ETH_HASH_FUNCTION_DEFAULT = 0, >>       RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ >>       RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */