From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C4ADA0561; Mon, 20 Apr 2020 16:07:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA07D1C2F6; Mon, 20 Apr 2020 16:07:42 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E59DF1C2F3 for ; Mon, 20 Apr 2020 16:07:41 +0200 (CEST) IronPort-SDR: PaYoCPkVShXbNBc5FVV+W11XSUq/ve1ZBZQP24EPGuRF9ejgQgycFNwfO39GIWVu8aczUvLPb1 83L0Q3foCdpw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 07:07:40 -0700 IronPort-SDR: ImZRkxk1FF5pvVDLKf+UTzJ7F27j064R0FjvLZ9k9eYtzlLpVdGREj4XhFJBEAHefJlLqIQJdL UH8+G0cPvTBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,406,1580803200"; d="scan'208";a="246902166" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.193.28]) ([10.213.193.28]) by fmsmga008.fm.intel.com with ESMTP; 20 Apr 2020 07:07:38 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, Tal Shnaiderman , bruce.richardson@intel.com, david.marchand@redhat.com References: <651f25bd-29e2-2058-70e8-59829e0b53bb@intel.com> <4193388.A7TYtsqqnE@thomas> <3278563.U75o6juQT5@thomas> From: "Burakov, Anatoly" Message-ID: <6e66deb1-e952-9e9c-81c1-dc51fc1326c4@intel.com> Date: Mon, 20 Apr 2020 15:07:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <3278563.U75o6juQT5@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19-Apr-20 2:10 PM, Thomas Monjalon wrote: > 19/04/2020 15:09, Thomas Monjalon: >> 17/04/2020 16:09, Burakov, Anatoly: >>> On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: >>>> On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: >>>>> Hi Anatoly, >>>>> >>>>> I’m working on the implementation of bus/pci driver for Windows, >>>>> pci_common.c uses the titled functions however they are relevant only >>>>> for Linux OS. >>>>> >>>>> I’m wondering if the implementation of those functions should be moved >>>>> to a Linux specific area since FreeBSD (and now Windows) are forced to >>>>> implemented those in the current state. >>> >>> Unfortunately, we don't have a generic API for these, but since we >>> export a single API on all platforms, either all platforms have to >>> implement these functions, or none of them do. There's simply no way to >>> avoid implementing stubs for these functions, short of coming up with a >>> generic API that would replace these. Given that this API is heavily >>> Linux specific, i don't see that happening. >> >> Because it is Linux specific, we should not force FreeBSD and Windows >> having stubs. Can we move VFIO calls in Linux-specific files? >> >> I think rte_vfio.h should be moved in lib/librte_eal/linux/include. > > +Cc Bruce and David > > ...and have a Linux-specific ABI? -- Thanks, Anatoly