From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 608EFA04DB; Fri, 16 Oct 2020 19:05:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B026DACC0; Fri, 16 Oct 2020 19:05:20 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F1B2DAC9D for ; Fri, 16 Oct 2020 19:05:17 +0200 (CEST) IronPort-SDR: NFC0ABeJvVwQ2tVS8cljHLU9LB0znoHl7RX0jxWf6/vFt58BKA4i+ShDHLLtEgM+bRBCJudcX0 tspfjvrmokKw== X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="166759474" X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="166759474" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 10:05:15 -0700 IronPort-SDR: qE4xOfg0q8rwN+g19OxEmxJJNDTMd9HzZM2IXvKEKNL9RxeUQFQyscE4QtkZwzmbf4K8VyqyFi E/+GPL5xscHg== X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="531795113" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 10:05:13 -0700 To: Viacheslav Ovsiienko , dev@dpdk.org Cc: thomas@monjalon.net, stephen@networkplumber.org, olivier.matz@6wind.com, jerinjacobk@gmail.com, maxime.coquelin@redhat.com, david.marchand@redhat.com, arybchenko@solarflare.com References: <1602866680-25920-1-git-send-email-viacheslavo@nvidia.com> From: Ferruh Yigit Message-ID: <6ea61152-bb96-cbe6-85bd-14cd178ecdc1@intel.com> Date: Fri, 16 Oct 2020 18:05:08 +0100 MIME-Version: 1.0 In-Reply-To: <1602866680-25920-1-git-send-email-viacheslavo@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 0/6] ethdev: introduce Rx buffer split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2020 5:44 PM, Viacheslav Ovsiienko wrote: > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the memory attributes > like external buffers, registered for DMA, etc. > > In the receiving direction, the datapath is much less flexible, > an application can only specify the memory pool to configure the > receiving queue and nothing more. In order to extend receiving > datapath capabilities it is proposed to add the way to provide > extended information how to split the packets being received. > > The new offload flag RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT in device > capabilities is introduced to present the way for PMD to report to > application about supporting Rx packet split to configurable > segments. Prior invoking the rte_eth_rx_queue_setup() routine > application should check RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT flag. > > The following structure is introduced to specify the Rx packet > segment for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT offload: > > struct rte_eth_rxseg_split { > > struct rte_mempool *mp; /* memory pools to allocate segment from */ > uint16_t length; /* segment maximal data length, > configures "split point" */ > uint16_t offset; /* data offset from beginning > of mbuf data buffer */ > uint32_t reserved; /* reserved field */ > }; > > The segment descriptions are added to the rte_eth_rxconf structure: > rx_seg - pointer the array of segment descriptions, each element > describes the memory pool, maximal data length, initial > data offset from the beginning of data buffer in mbuf. > This array allows to specify the different settings for > each segment in individual fashion. > rx_nseg - number of elements in the array > > If the extended segment descriptions is provided with these new > fields the mp parameter of the rte_eth_rx_queue_setup must be > specified as NULL to avoid ambiguity. > > There are two options to specify Rx buffer configuration: > - mp is not NULL, rx_conf.rx_seg is NULL, rx_conf.rx_nseg is zero, > it is compatible configuration, follows existing implementation, > provides single pool and no description for segment sizes > and offsets. > - mp is NULL, rx_conf.rx_seg is not NULL, rx_conf.rx_nseg is not > zero, it provides the extended configuration, individually for > each segment. > > f the Rx queue is configured with new settings the packets being > received will be split into multiple segments pushed to the mbufs > with specified attributes. The PMD will split the received packets > into multiple segments according to the specification in the > description array. > > For example, let's suppose we configured the Rx queue with the > following segments: > seg0 - pool0, len0=14B, off0=2 > seg1 - pool1, len1=20B, off1=128B > seg2 - pool2, len2=20B, off2=0B > seg3 - pool3, len3=512B, off3=0B > > The packet 46 bytes long will look like the following: > seg0 - 14B long @ RTE_PKTMBUF_HEADROOM + 2 in mbuf from pool0 > seg1 - 20B long @ 128 in mbuf from pool1 > seg2 - 12B long @ 0 in mbuf from pool2 > > The packet 1500 bytes long will look like the following: > seg0 - 14B @ RTE_PKTMBUF_HEADROOM + 2 in mbuf from pool0 > seg1 - 20B @ 128 in mbuf from pool1 > seg2 - 20B @ 0 in mbuf from pool2 > seg3 - 512B @ 0 in mbuf from pool3 > seg4 - 512B @ 0 in mbuf from pool3 > seg5 - 422B @ 0 in mbuf from pool3 > > The offload RTE_ETH_RX_OFFLOAD_SCATTER must be present and > configured to support new buffer split feature (if rx_nseg > is greater than one). > > The split limitations imposed by underlying PMD is reported > in the new introduced rte_eth_dev_info->rx_seg_capa field. > > The new approach would allow splitting the ingress packets into > multiple parts pushed to the memory with different attributes. > For example, the packet headers can be pushed to the embedded > data buffers within mbufs and the application data into > the external buffers attached to mbufs allocated from the > different memory pools. The memory attributes for the split > parts may differ either - for example the application data > may be pushed into the external memory located on the dedicated > physical device, say GPU or NVMe. This would improve the DPDK > receiving datapath flexibility with preserving compatibility > with existing API. > > Signed-off-by: Viacheslav Ovsiienko > --- > > v1: http://patches.dpdk.org/patch/79594/ > v2: http://patches.dpdk.org/patch/79893/ > - add feature support to mlx5 PMD > > v3: http://patches.dpdk.org/patch/80389/ > - rte_eth_rx_queue_setup_ex is renamed to rte_eth_rxseg_queue_setup > - DEV_RX_OFFLOAD_BUFFER_SPLIT is renamed to RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT > - commit message update > - documentaion provided > - release notes update > - minor bug fixes in testpmd related part > > v4: http://patches.dpdk.org/patch/80401/ > - common part of rx_queue_setup/rxseg_queue_setup > > v5: http://patches.dpdk.org/patch/80609/ > - refactored to approach of providing split configuration > in the rte_eth_rxconf structure instead of introducing > the new API routine > - added support for rxoffs command to testpmd to > provide segment offsets for complete testing of split > configurations > - patchset is split into two parts - PMD part will > be presented as separate series > > v6: http://patches.dpdk.org/patch/80785/ > - wordy comments rephrased > - typos fixed > - rte_eth_rx_queue_setup configuration check isolated > for two main options > - the rest of comments addressed > > v7: http://patches.dpdk.org/patch/80978/ > - description as union of feature dedicated segment split description > - the split limitations reported in the rte_eth_dev_info->rx_seg_capa > - comments made less wordy > > v8: - bitfield instead of uint8; > - named union to avoid warinings; > - typos fixed > > > v9: http://patches.dpdk.org/patch/81080/ > - simplified rte_eth_rxseg union > - moved out wordy comment from rte_eth_rxconf > - rte_eth_rxseg_capa uint32 bitfield and naming > - added experimental tags > > v10: - missed in mailing list, see v11 for changes > > v11: http://patches.dpdk.org/patch/81116/ > - documentation cleanup (removed rxq_info_get mention) > - max_nseg moved from the recored and converted to uint16_t; > - reserved uint16_t is added to rte_eth_rxseg_capa; > > v12: - __rte_experimental at structure declarations > converted to the tag in the comment > - testpmd pool names shortened, prefix provided > - comments reworded > > --- > Viacheslav Ovsiienko (6): > ethdev: introduce Rx buffer split > app/testpmd: add multiple pools per core creation > app/testpmd: add buffer split offload configuration > app/testpmd: add rxpkts commands and parameters > app/testpmd: add rxoffs commands and parameters > app/testpmd: add extended Rx queue setup > Series applied to dpdk-next-net/main, thanks.