From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85F6CA0C41; Tue, 30 Nov 2021 09:58:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22AE14113C; Tue, 30 Nov 2021 09:58:25 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 6EC18410F7 for ; Tue, 30 Nov 2021 09:58:23 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10183"; a="223056249" X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="223056249" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2021 00:58:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,275,1631602800"; d="scan'208";a="609059465" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 30 Nov 2021 00:58:22 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 30 Nov 2021 00:58:22 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 30 Nov 2021 00:58:22 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 30 Nov 2021 00:58:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpjJa5zBuM4OKCoNNfKGzxHfMUET62CrnhhvICuYr5yjZzV/NWQm2js98XWGuXpJAd+XacGQbEr57KkdcoRNvLS26WGWAwJb4tI7XgtqAenEzv+Dd8/0GfAseFYyUgJN9cvrBsu8fw+X7rG5PpGBAai86rO1D9TLnzWSIksBFKk01+B0Js1Ya1ZgqZ/OzhLoSXWfl2bKk//jz69tBR0aiTAAXiOvDnXqkQ3YEpgTS7Ndp5lTxU8sVmqu9aQ1ILSDwpe2JQqeBZGG7FM45Xa3IZeH0B7XwNlYKn3zWAKjc8cMJkLK9Ob1hs7ns/pZoZuNIBDxgvJzpf4l6Gw0LXeVaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+6s1uSCj/TY3RJg9B3k4uS3jsYZvMk5F9ZcKl8KWX6s=; b=aLJ1hsyHEVTGBRbl3hTrqqxMMMZJjVicba5Gz1vR5AD9a9MdEtBk9V//74k58coOW+uuwobQK6nnT+2B5AwcLhY/WGsXktIZ6TGlzotCUk+FD0W/M3MFNp1gqkg2EnylhwvbG6nNkTyY6K2sm0x0K2WEuiuZr7UqfGi6wkpKoK9KBYi//DVHpp3vVzx14E01hJ3cAANfQxJ7D07nYBvJS7W80J8gcblHYhIDhE9kzIcaC5erNPs1JY+oIE5hoz7z50MDK1gOhNy9OvDrrM8ecEY1A57jy6p6v/zKeh+RbImWI8M6Kboc+uonYYgilg5P0WPFLpWrtTjunrRr1s0U/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+6s1uSCj/TY3RJg9B3k4uS3jsYZvMk5F9ZcKl8KWX6s=; b=FhIEe+vIPhDJ3BIeW/oQBZJvScYf1rtnYTJVzyMqmgKzs7qw9jQ31rrKcl/CEzj7hUwPXIdkE9yBG9aoMBy2gnsqXUFY05UyQlk6/7XYmqKwmIkFjAoAMAXLbf5NlUlIw/8DGHuSXJcmZmCBlQ6UvBI7KNR8Mqmuk1QTMVPEaP8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4935.namprd11.prod.outlook.com (2603:10b6:510:35::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Tue, 30 Nov 2021 08:58:15 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4734.024; Tue, 30 Nov 2021 08:58:15 +0000 Message-ID: <6ea72253-ca4d-9c1e-b419-6cf2685668b3@intel.com> Date: Tue, 30 Nov 2021 08:58:09 +0000 Subject: Re: [PATCH] net/vmxnet3: add spinlocks to register command access Content-Language: en-US To: Yong Wang , "sahithi.singam@oracle.com" CC: "dev@dpdk.org" References: <20211108082331.1407-1-sahithi.singam@oracle.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:a0::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend Transport; Tue, 30 Nov 2021 08:58:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4164bcb-0e93-4c74-d719-08d9b3df8b8e X-MS-TrafficTypeDiagnostic: PH0PR11MB4935: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7Ry6UqvnHyCx/08xvsVxUYv9xw42yMQATTb5mLJoeXhLLGfO1REZNZu9UjPhjX7206te2DLm+ZuaHGc3L/RFiiM94Uaz0rJoMEEFaM1Uc4Q4aWRu9Y99AGP6J6P49T6lyYtUinMOq9maz02GdJ1r9dchbrJmvzWdyRHTus4JPEeemwDzogv0vFdtKtPFeAsamymg/kKmomjg98pfBGeMfpFz3VETcKMMzsbvpKw9TOMX7AFvCNgaQ5JHC88nKnxfVEWJosG4YSWVCtxa0WJLftAx43tjZjIRvdLHXRlpEGGwy59ONpSM6xUAdxgq+iNb0J7U1vCvVmSP655+RXR9lIxP3Txq7zMwy7DAOiZIlKPjfKuU7Uv3J9Jtm2e++R8W/lIakeDfNhGYx3q+pBg3qR4tjNy36ekf3/Ja7VEm/QpMRvdvtLcQSKNBxbJ+f1oDYpbZqaNaj0uM9ibOOBpNZSw1FWjUavZ7z+LR/qNuAG3FdkU4MQw1N4hcJDBoNJ2MNEXRZeST1PAeZ4e+CTzCNWAKs9VW3D8LYM4DEzJc1xsvWPXaMofoQ+Dy/cDBoTsZFV/DIeahFyUQ++jzvYR4Jgj1opa2F1KRTdTMoaLJ7hUqQNDytD4mIwLywQUBUebV9D3lOy/+6mcf+SaiHWtI0iCvsImR2K6BCnrgAujQ3d3N+595ealbwhoWmsjkf7+cH5cy+LIzVT344mkZ6NxwpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(66556008)(6486002)(8676002)(110136005)(66946007)(6666004)(4326008)(16576012)(31686004)(316002)(86362001)(8936002)(82960400001)(2616005)(956004)(5660300002)(26005)(186003)(508600001)(31696002)(38100700002)(2906002)(53546011)(83380400001)(44832011)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akM5WURxd1J5T3k3bDEveExiTTFoejBZaUoyTmJUSndkck1OVmdiNzlUMDN4?= =?utf-8?B?cWw5WnJPZk01c1R5Y01nUXhIWUttMzNGamU0MlRxdXIyZXFzb3pFNDFDNXdD?= =?utf-8?B?ZzZKMzdLd3gxTjVYR25QZndmWkRHaGNrU2NGRXFObkJDZWFBaWVFNUhjajJI?= =?utf-8?B?ZnUzSzNnd3V5T1ZCRDh3aHhNWkNMOUtIcXdRTDRoMmRibW5LaHozbmprSVJG?= =?utf-8?B?MnJObEdZZFpLMy9FU0ppRmlGR2ZGbHNTQ2NjSzNQSUpsWVJ6UG0xY1AwSWQ5?= =?utf-8?B?cE5xV0xqY3FKdWw2MzZMV21tbElSL0hXb2t2aGtvbWtxUWI3cVdkeWZpRXZD?= =?utf-8?B?QUVvYWhBa1pZRnIvNDFGdmlHVDFoei91Smdld3ZsdVN0YjFQdDMxMEtuSDFB?= =?utf-8?B?RXp1MnYvLzIzTzJjK0huNEtpcERmT0VBbkdITTdpaHBQVWwxbm1FRlhzUGp4?= =?utf-8?B?M1pnOENma2VYTEFmNWN0d1hEY0NQNmpHYzErcVJWbzZxRCtwVlhpbDdBZzk1?= =?utf-8?B?bjI5NksyL0RmTHRhOXBFV29MemVBcmU0Z25CbElVcU82SGR5dllIZ2t0ZmZU?= =?utf-8?B?a01XQ3p2V2dHN3Rrb0JwN3hrSkwvQ2VLSzNNWjBOcHNNdXkwVDRFQ0N5RVFU?= =?utf-8?B?VHkwVm9LWU5RNjZ1NitCTXZxM29Eek13dCtiL2RqR0hDb0taZlRPdHpDUlY5?= =?utf-8?B?Y2t1UWtETDZCMkdydEFsT3FNQVlDbVJYdU9FS20vUnE3NklKcmk5aU9aOVhp?= =?utf-8?B?aC9PS2s0alg0QUhCRmd1UVdtcDRXblhjM2NIelVXRkp2U3ltRTN3T3podGhw?= =?utf-8?B?bytJaGt3bHlEYS8yUDcyWFFPNzFLcE45b2JNTzhNYnhidjBjUGhXdXo0UTd0?= =?utf-8?B?YjN0ZGFMb0J0YmFRRjlrMXNxQkNpUUc1MmRrRldjOXh1N09YVmp1b1pMa3kx?= =?utf-8?B?OEVrWFY3Z2ExTEpkNDgyQlNwYlFuUjFPNlZtdDdpbWVKR1ZxQ1ExY05NYTB3?= =?utf-8?B?bHFzVzJDK0xWaHc0L1VYdG9qcTlxbllwVk9YZDROVnBMcTFBSVV0NnR3djhB?= =?utf-8?B?USt4bkVGNzNPTGFvNFF1djZVVlBRSHp3TEdETktJSVhZQTdCM3FMakM1SGxp?= =?utf-8?B?VmxuUENMQzZoSGlPVEJ3UnNrdXMybmZuT2VhMWE1K1d4czhrUjVkOXNTY3Bi?= =?utf-8?B?ZDNUVGFnUlpvNXJ5a1dYcjdVNlR1c1ZhRlFjQk1SOWxhSDdoaW1pYWtvd3h0?= =?utf-8?B?bkVnSFRYRUVkblF2cFlGY3pRWHlreGVNUmpZYUd6dEJqNEJ0UzB4MnNTa0Z2?= =?utf-8?B?SnJMU2orZkY0V0dHYTl6ZktSZUN0S2JKaDdxMTFjWXc1eml2OWJuU0NNSDBr?= =?utf-8?B?Q1hOWWptOFFmanFLMDBmZVJFTmloNnRwKzlDcFJuWWtDTDNGanFKaHRURE44?= =?utf-8?B?U2xkcnN6VzZlK3RUcGxZbUptSkEwWmxQZ0U1eWE5bDVON29lc3FtVm5Kc0Jx?= =?utf-8?B?dURjejhSd1J4bDltMFNDV1htczFON0hGb0hhUGZ1WS9xQmZXOW1NZ3M3US9I?= =?utf-8?B?NzdGQlI2VzlpZE9LdFJDcVk1RHVDeGZkVUJDWVNnV1FOaklkWXVxQURCbjNw?= =?utf-8?B?MjdqMkdsNW5HQ0g1bGp1Z0tWcEZwRU9Ick1zODUrRzdXRkdrc1ZlQkVvYUZ6?= =?utf-8?B?Sm1UeitvakF6dnBEYnY3dDlUWWhwWmdaTjcvT0FicVZMMmQ1YjNTMVZPeGwy?= =?utf-8?B?U2RRZEpYMzdLcStSQUFKRjllMmtKSGtMc05wNTNMdFg3UjZwN1JPa1lSbzRo?= =?utf-8?B?UzhaUzlzeFhpeklaOHF5SXNYUFRqcXgvS0ZiMmdLUEtIVDkwb0NoNnBzOGVJ?= =?utf-8?B?c3BqTHRTZW0yczB1OWlWRDAwRmJWbzhzczI2LzNhT1FKL0RJb1hCRUkyZThP?= =?utf-8?B?akdMYWIyMkxrZUdtNDlmQzJUUSsybVJPYzEvUlM0NkJqSFhuTFhEVHNoYVgr?= =?utf-8?B?eVl3ZVh6R1pVRnVHTkRqazV3QWhBcEZOQlg3a1JrUXNBNEFJcmlpWC9qTktC?= =?utf-8?B?OGtkUi85NVpvQWZUT1dWQXlYdlZQQkxhbmhtUmZYMjY5U3Q0N1JycGVPemxi?= =?utf-8?B?SFl3elRuMzVVYWwwRERHYnczM3loMzF4bTJiWFVZb0t4K2JjTUN3QTBrMmpz?= =?utf-8?Q?1jkLwOY8nnmvfK5hzMnXIOU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e4164bcb-0e93-4c74-d719-08d9b3df8b8e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 08:58:15.2637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Qx2NGsz61G3vpkEDHFWjW+G+wr69PtiTV6nxJBRxQ5S3WvfwCemJcnhsChke6N8nyFSeft74mDj373isW40RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4935 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/30/2021 7:31 AM, Yong Wang wrote: > -----Original Message----- > From:"sahithi.singam@oracle.com" > Date: Monday, November 8, 2021 at 12:23 AM > To: Yong Wang > Cc:"dev@dpdk.org" , Sahithi Singam > Subject: [PATCH] net/vmxnet3: add spinlocks to register command access > > From: Sahithi Singam > > At present, there are no spinlocks around register command access. > This resulted in a race condition when two threads running on > two different cores invoked link_update function at the same time > to get link status. Due to this race condition, one of the threads > reported false link status value. > > Signed-off-by: Sahithi Singam > --- > > Thanks Sahithi for the patch. As we discussed offline, in DPDK, the expectation is that control level synchronization should be handled by the application. In my knowledge, currently no PMD guarantee such synchronization at driver callback level. It makes more sense to have the application manages the synchronization as most likely it needs to work with multiple PMDs and it's better to keep this behavior consistent across all PMDs (i.e, it does not make a lot of sense to support this behavior only in one particular PMD). ack, updating patch status as rejected.