From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1921A0548; Tue, 24 Aug 2021 18:04:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8627F406A3; Tue, 24 Aug 2021 18:04:52 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2060.outbound.protection.outlook.com [40.107.100.60]) by mails.dpdk.org (Postfix) with ESMTP id 9D0CD40687 for ; Tue, 24 Aug 2021 18:04:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mG1k/MfOLB1KLwq3ltZfQB0pYITEDwqZp2A8o9XPtXjqKGjh74ogapiDv9m0BuAiGShuQEJGMenpoKXpxAQO3ASPHjDozs95kBO9DDXIqhsgER4h3coHarwGaI1XJ6DKr/Liw9V6rG/nnbm0kCL6OOVYCPLIArh/Z86V64vef0yBKlXYsHpH0ks0DNNAEZoFAmHNXzTqyCwaBCj6PbYJAnMc+lOS89dvvgFki1a2s2MzJTF2obMtvvHZtF5+UwfPyEFrkWkvms9KNnjd6BnL3Lde/lKcIPdY0yQBK7W9ojfcGjXneXq+o66UJWEJbHDrgJ6gN2Lx42Y0Uq4Erj6suQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=moD/rh0/wHLungW8z/a7NGB1O2Ym3NEWB3GQawQccYY=; b=oOzCqYO0Pkv7ORqYJrskp8XYpTzuKjtXWt3JZmFoUAEz/IqT8xR24fYOQR6rNutZJBtsSLJMAOtMtHl+MZJimbZrhmHBCyUZ/u8bTezVJj1JCN2LXwkSINPKFkRMe3tbgpwDuwXF7TRzTCw3rY1UL06rBm6xOkIwnpR5iVrPJHb8fD+sFX/Oz5RQOjjCXOfhkojK7CzYUJqPhouAK6ygJ8ns0m5y2iwuYKTuPiq4Ew3Y56OmOfRj4Z8FrBUP+DMWOEWaRulCqFpbliKAZmd4a8ZDVDKAhw82WSCwK87P7lVvvuj5KKcxEAz3BHFsEkVaEE6grI1lOBzDjijZzCq1Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=moD/rh0/wHLungW8z/a7NGB1O2Ym3NEWB3GQawQccYY=; b=c9x33SMMpJKRRTonFTZUzhPM1ZuNWHvQ5Rs32LFIb5vepS93jKWNS4IkVNXehzbG+9+34uspzqaY7tZ2MbUa/JlWp4v3J6z3Ng9L9EVW7znn0G9Yj1zKdPxXiuB8Tr+GrQPOYVUfTvoSJ4TNu6OJ730CobzcBMsBoF+Jsqyd5gFC1KZlQMbhc5G40WEys2a+HEfYLBzkONqt2B3luqlAh7Nmm/THa1aV9KD1vRl9BbV8ESLsoJ7TGjnZ+k7+3qxjHIgF2czK04eTdIi3anrUFkn6hDypThu1RsZ67mQjnm3B9aV0kQ4eWU7gNN6T2sklPepDDEEt8WpCXoIIwSdEZA== Received: from BN9PR03CA0370.namprd03.prod.outlook.com (2603:10b6:408:f7::15) by BY5PR12MB3985.namprd12.prod.outlook.com (2603:10b6:a03:196::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Tue, 24 Aug 2021 16:04:48 +0000 Received: from BN8NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::db) by BN9PR03CA0370.outlook.office365.com (2603:10b6:408:f7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Tue, 24 Aug 2021 16:04:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT061.mail.protection.outlook.com (10.13.177.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 24 Aug 2021 16:04:48 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 24 Aug 2021 16:04:47 +0000 Received: from [172.27.1.17] (172.20.187.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 24 Aug 2021 16:04:44 +0000 To: Ilya Maximets , "Finn, Emma" , "dev@openvswitch.org" CC: "Stokes, Ian" , Sriharsha Basavapatna , Gaetan Rivet , "Majd Dibbiny" , Salem Sol , Andrew Rybchenko , Ori Kam , dev References: <20210816135433.1922261-1-elibr@nvidia.com> <221d1783-58c0-5cb4-eb0d-c6ff5648636f@nvidia.com> <7f98de95-144f-bddd-6747-da145fc1e6d9@ovn.org> From: Eli Britstein Message-ID: <6eae08ab-dc19-7623-ba2c-e76f8c435659@nvidia.com> Date: Tue, 24 Aug 2021 19:04:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <7f98de95-144f-bddd-6747-da145fc1e6d9@ovn.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eccd8b91-2e6a-46f9-7da7-08d96718e61a X-MS-TrafficTypeDiagnostic: BY5PR12MB3985: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NzSx98xkylfzWF9g41OfpBj65rqSI2LaeOtT1P/nwgqIBnTbK0Cbk4RZZBqkr1bIdJ1TJtTS65NoGqQXh2/3CJ2NG7oR5BBMqoXVH+4CuqKMPJdUyX3SEPakeGxMn3YrrWRonaZDVFSkEEJJSWJXjoJ4gE4J7T3PB0O+F364vijomQm8rk1MSl8vizBZycillCHYgzTUYTXmW9/Z05kp1HHCX87QBM/uieyI42cpKcCG6qcND3U7PYw0YknHq02ekKKmZA96AQEQBiCIjQY61lv7tpzETSjYNb+0ArFuSXs38Vae0H4qPraIXVm+3HwL8mz+OfG0MA3ejh77gOdJcnRop2JHaQJHMNwGtQQ7kw1X1kQHQbdHmYkCTX0U45YUNk/OD6dc8rsGxC/TI6rbkN75Wutsz0RRK6qC0zOI4S7prtKHdvKU004/Ji34hkUOIIkp04hjR8M6sfoZxj+HvSBOzMoS3EzrpQIr0Sw4gIaeFFFxsfaiEc37IqiNGPpp4z0sjn0TT2NJUbO4gMwG/66DOYNGKPyCv4Vcwjv4wFn9ffiGJYAdCAho/eNi47xhu+iTnGwycgAdcvQsy2Y1pbtvOsigg8i0YWebgAnIxtu4W53jSr0mD5OyU2MOXBqHzNaxr3HwMywtHv53N4IH9np0EBD2I83JZvDN1JWpyV6ay0a0QpFfkZWIF8nC0g++kBhfDHJyu20ldIkp/NQ0qPVqaR4TJVvQcId+7OIoTU0FHtifT3P23y7/mXJunCaNKn0CLP6y13NMu+qj2ilKxxk8w5mbmsF+1q7ctOwv9cQhOQ+fcl3drhbo3mTQqaiP X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(47076005)(82310400003)(31686004)(36756003)(36860700001)(7636003)(31696002)(83380400001)(966005)(86362001)(508600001)(5660300002)(316002)(16576012)(356005)(70206006)(8936002)(26005)(8676002)(16526019)(186003)(53546011)(2616005)(4326008)(2906002)(54906003)(110136005)(336012)(36906005)(70586007)(6666004)(426003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 16:04:48.4778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eccd8b91-2e6a-46f9-7da7-08d96718e61a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3985 Subject: Re: [dpdk-dev] [PATCH V3 1/2] netdev-offload-dpdk: Use has_vlan match attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/24/2021 6:47 PM, Ilya Maximets wrote: > External email: Use caution opening links or attachments > > > On 8/24/21 5:25 PM, Eli Britstein wrote: >> On 8/24/2021 6:08 PM, Finn, Emma wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> -----Original Message----- >>> From: Eli Britstein >>> Sent: Monday 16 August 2021 14:55 >>> To: dev@openvswitch.org; Ilya Maximets >>> Cc: Finn, Emma ; Stokes, Ian ; Sriharsha Basavapatna ; Gaetan Rivet ; Majd Dibbiny ; Eli Britstein ; Salem Sol >>> Subject: [PATCH V3 1/2] netdev-offload-dpdk: Use has_vlan match attribute >>> >>> DPDK 20.11 introduced an ability to specify existance/non-existance of VLAN tag by [1]. >>> Use this attribute. >>> >>> [1]: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items") >>> >>> Signed-off-by: Eli Britstein >>> Reviewed-by: Salem Sol >>> >>> Hi Eli, >>> >>> I tested this but currently we don't have support in the i40e pmd for the has_vlan match attribute and with these patches it is breaking offload for VLAN packets on Intel devices. >> Hi Emma, >> >> Thanks for testing. >> >> Is adding such support in your plans? >> >> How do you suggest to proceed? It is needed in order to fix OVS bug. >> >> Thanks, >> >> Eli > The "Table 1.2 rte_flow items availability in networking drivers" > here: https://doc.dpdk.org/guides/nics/overview.html > says that both ixgbe and i40e has a full support for 'vlan' and > 'eth' items. Is it a bug? Should it be 'partial' instead? > > In general, this sounds like a big limitation of rte_flow API. > I mean the fact that there is no way to get what is implemented by > a particular driver and what is not implemented in runtime. > Someone should, probably, work on adding this kind of API to DPDK. > Otherwise, we will stuck with inability to use certain actions/matches > unless all the drivers supports them (which is also hard to check > taking documentation issues into account). If I missed it and the > API actually exists, we should definitely start using it. > > CC: dpdk-dev and rte_flow maintainers. > > Thoughts? There is such an API - rte_flow_validate(). However, in OVS, as each flow is independent and can have different matches and actions, we just call rte_flow_create(). The PMD (at least mlx5) first internally validates it (as if rte_flow_validate() is called), and bail out with a failure in case validate fails. Can you suggest an effective way to utilize it in OVS? In theory, if the API exists in rte_flow, OVS should not care if all PMDs support it or not. In practice, the "has_vlan" field was introduced only in 20.11, and apparently Intel has not adapted i40e PMD, so it breaks their offloads. I suspected this so I've added Emma and Ian to review it. I don't know i40e HW capabilities, but at least from PMD point of view, it can be silently ignored until a proper support is added. > > Best regards, Ilya Maximets.