From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) by dpdk.org (Postfix) with ESMTP id 88CC81B6F0 for ; Wed, 10 Oct 2018 20:56:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1755; q=dns/txt; s=iport; t=1539197779; x=1540407379; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JgtdArPAFgtu9+Q0UKUM97cXwrYzCJuJwcBP7wrh4Zc=; b=lX3ZqT5VUYNw9S74rp3qe33QC6iVnlAogXjcd5P/rSoGZZDT4b1qaQvO /Zv9xJ9FcjFzS7CR3HxCK0GQoEOFXo/hQK2DbJ5SDtAHfToOQRoVyt8mQ RSjHxlf7qN6gVVf+lSF1tZzEISWwa+vipdAhxywdtsEq2uVlv1KjEtvS5 4=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAAB6Sr5b/4sNJK1lGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBggNmfygKjACMNYINln6BegsBAR+ETQK?= =?us-ascii?q?EUCE0DQ0BAwEBAgEBAm0cDIU5AQEBAQMnEz8MBAIBCA4DBAEBHxAyHQgCBAE?= =?us-ascii?q?NBQiDGoIBD6cPM4QBASkBhSsFizsXgUE/hCSER4YPAo4xj1UJAoZPiXgfkAu?= =?us-ascii?q?MMIk1AhEUgSUdOIFVcBU7gmyCJheIWoUIATVvihGBLoEfAQE?= X-IronPort-AV: E=Sophos;i="5.54,365,1534809600"; d="scan'208";a="464527517" Received: from alln-core-6.cisco.com ([173.36.13.139]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2018 18:56:18 +0000 Received: from XCH-RCD-007.cisco.com (xch-rcd-007.cisco.com [173.37.102.17]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id w9AIuHMq010092 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 10 Oct 2018 18:56:17 GMT Received: from xch-rcd-007.cisco.com (173.37.102.17) by XCH-RCD-007.cisco.com (173.37.102.17) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 13:56:17 -0500 Received: from xch-rcd-007.cisco.com ([173.37.102.17]) by XCH-RCD-007.cisco.com ([173.37.102.17]) with mapi id 15.00.1395.000; Wed, 10 Oct 2018 13:56:17 -0500 From: "John Daley (johndale)" To: Mordechay Haimovsky , Adrien Mazarguil , Shahaf Shuler , Ori Kam , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix flow query failure Thread-Index: AQHUYLtezpIFwK1+5EWur2IGcQ2jJKUY0Eew Date: Wed, 10 Oct 2018 18:56:16 +0000 Message-ID: <6ebb000b3d0f47d6baf376fb02e2c5b2@XCH-RCD-007.cisco.com> References: <1539191078-8501-1-git-send-email-motih@mellanox.com> In-Reply-To: <1539191078-8501-1-git-send-email-motih@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.57.19] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Outbound-SMTP-Client: 173.37.102.17, xch-rcd-007.cisco.com X-Outbound-Node: alln-core-6.cisco.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 18:56:19 -0000 Ok, makes sense now, both flow query and flow list work with this patch, ye= ah. Tested-by: John Daley Remember that https://patches.dpdk.org/patch/46221/ still needs to be rever= ted out of dpdk-next-net/master otherwise we are still broken. The patch wa= s squished into e5b652ea34. -johnd > -----Original Message----- > From: dev On Behalf Of Mordechay Haimovsky > Sent: Wednesday, October 10, 2018 10:05 AM > To: Adrien Mazarguil ; Shahaf Shuler > ; Ori Kam > Cc: dev@dpdk.org; Mordechay Haimovsky > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure >=20 > This patch fixes a bug found in port_flow_query routine which caused flow > query command to fail with the following error "Caught error type 1 (caus= e > unspecified): unknown object type to retrieve the name > of: Invalid argument". >=20 > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function") >=20 > Signed-off-by: Moti Haimovsky > --- > app/test-pmd/config.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 009c92c..b11317b 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1239,7 +1239,8 @@ void print_valid_ports(void) > return -ENOENT; > } > ret =3D rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR, > - &name, sizeof(name), action, &error); > + &name, sizeof(name), > + (void *)(uintptr_t)action->type, &error); > if (ret < 0) > return port_flow_complain(&error); > switch (action->type) { > -- > 1.8.3.1