From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E66C9A0C51; Tue, 13 Jul 2021 15:35:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9799C41263; Tue, 13 Jul 2021 15:35:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E7BAC406FF for ; Tue, 13 Jul 2021 15:35:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626183301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3hkUz7Tjcfy64++jaScJgc+WzWwKxbVD9rXPhFJyLPE=; b=Vehkhsi+e9nTL9Ub/ZLCIZvPD/yZQdQzM20bVYD3036GHd+4RVENbZLEre10VuwmG/+CMU GiGTIH/cNlZnAtjMR7nNfYoqlSi3pAw40WqcRopaAYyYfWPuBIrBOBjzdmbtpVvwrNYmOH A5smTndUG24UzMxOiIF1idDv4L6UcBc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-n7BqcKkLOIKhrNzARYZZfg-1; Tue, 13 Jul 2021 09:34:58 -0400 X-MC-Unique: n7BqcKkLOIKhrNzARYZZfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AABD18D6A25; Tue, 13 Jul 2021 13:34:57 +0000 (UTC) Received: from [10.36.110.39] (unknown [10.36.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 018326090F; Tue, 13 Jul 2021 13:34:55 +0000 (UTC) To: Wenwu Ma , dev@dpdk.org Cc: chenbo.xia@intel.com, cheng1.jiang@intel.com, jiayu.hu@intel.com References: <20210602083110.5530-1-yuanx.wang@intel.com> <20210705181151.141752-1-wenwux.ma@intel.com> <20210705181151.141752-2-wenwux.ma@intel.com> From: Maxime Coquelin Message-ID: <6ec24fcd-fe0f-e571-cbb2-b45e1ecac7ab@redhat.com> Date: Tue, 13 Jul 2021 15:34:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210705181151.141752-2-wenwux.ma@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 1/4] examples/vhost: refactor vhost enqueue and dequeue datapaths. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wenwu, Please do not add dot in the commit title. On 7/5/21 8:11 PM, Wenwu Ma wrote: > Previously, by judging the flag, we call different enqueue/dequeue > functions in data path. > > Now, we use an ops that was initialized when Vhost was created, > so that we can call ops directly in Vhost data path without any more > flag judgment. > > Signed-off-by: Wenwu Ma > --- > examples/vhost/main.c | 112 ++++++++++++++++++++---------------- > examples/vhost/main.h | 33 +++++++++-- > examples/vhost/virtio_net.c | 16 +++++- > 3 files changed, 105 insertions(+), 56 deletions(-) > Other than that, it looks good to me. The typo in the title can be fixed while applying: Reviewed-by: Maxime Coquelin Thanks, Maxime