From: Kevin Traynor <ktraynor@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>, dev@dpdk.org
Cc: ailan@redhat.com, jan.scheurich@ericsson.com,
bruce.richardson@intel.com, thomas@monjalon.net,
maxime.coquelin@redhat.com, konstantin.ananyev@intel.com,
ferruh.yigit@intel.com, bernard.iremonger@intel.com
Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode
Date: Tue, 2 Oct 2018 12:58:04 +0100 [thread overview]
Message-ID: <6ec37a68-ccb9-374f-7451-c0201724b75d@redhat.com> (raw)
In-Reply-To: <20181002074419.24164-1-jfreimann@redhat.com>
On 10/02/2018 08:44 AM, Jens Freimann wrote:
> This adds a new forwarding mode to testpmd to simulate
> more realistic behavior of a guest machine engaged in receiving
> and sending packets performing Virtual Network Function (VNF).
>
<snip>
As there's going to be a v9 anyway, you can also fix the below error
messages to be '>= 0'
> + if (!strcmp(lgopts[opt_idx].name,
> + "noisy-lkup-memory")) {
> + n = atoi(optarg);
> + if (n >= 0)
> + noisy_lkup_mem_sz = n;
> + else
> + rte_exit(EXIT_FAILURE,
> + "noisy-lkup-memory must be > 0\n");
> + }
> + if (!strcmp(lgopts[opt_idx].name,
> + "noisy-lkup-num-writes")) {
> + n = atoi(optarg);
> + if (n >= 0)
> + noisy_lkup_num_writes = n;
> + else
> + rte_exit(EXIT_FAILURE,
> + "noisy-lkup-num-writes must be > 0\n");
> + }
> + if (!strcmp(lgopts[opt_idx].name,
> + "noisy-lkup-num-reads")) {
> + n = atoi(optarg);
> + if (n >= 0)
> + noisy_lkup_num_reads = n;
> + else
> + rte_exit(EXIT_FAILURE,
> + "noisy-lkup-num-reads must be > 0\n");
> + }
> + if (!strcmp(lgopts[opt_idx].name,
> + "noisy-lkup-num-reads-writes")) {
> + n = atoi(optarg);
> + if (n >= 0)
> + noisy_lkup_num_reads_writes = n;
> + else
> + rte_exit(EXIT_FAILURE,
> + "noisy-lkup-num-reads-writes must be > 0\n");
> + }
prev parent reply other threads:[~2018-10-02 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 7:44 Jens Freimann
2018-10-02 11:20 ` Iremonger, Bernard
2018-10-03 18:52 ` Jens Freimann
2018-10-02 11:58 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ec37a68-ccb9-374f-7451-c0201724b75d@redhat.com \
--to=ktraynor@redhat.com \
--cc=ailan@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jan.scheurich@ericsson.com \
--cc=jfreimann@redhat.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).