From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 646B67D3A for ; Thu, 24 Aug 2017 10:22:01 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2017 01:22:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,420,1498546800"; d="scan'208";a="143386038" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.28]) ([10.237.221.28]) by fmsmga005.fm.intel.com with ESMTP; 24 Aug 2017 01:21:59 -0700 To: Thomas Monjalon References: <20170823124241.17552-1-sergio.gonzalez.monroy@intel.com> <6484062.ssFnLodFTS@xps> Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com From: Sergio Gonzalez Monroy Message-ID: <6ed25652-da53-139f-37b1-12079f51c95e@intel.com> Date: Thu, 24 Aug 2017 09:21:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <6484062.ssFnLodFTS@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 08:22:01 -0000 On 23/08/2017 21:49, Thomas Monjalon wrote: > Please could you explain why the asm code was used? I guess we were not aware that there was a builtin for it. > Are you sure this builtin is implemented everywhere? > Actually the builtin used in this patch is not supported in most CLANG version (just recently merged upstream), so I have reworked the patch to use builtin supported in both GCC and CLANG 3.4+. Thanks, Sergio