From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B35A5A0521; Mon, 2 Nov 2020 12:50:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CCF5C7F2; Mon, 2 Nov 2020 12:50:41 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 03B99BE97 for ; Mon, 2 Nov 2020 12:50:38 +0100 (CET) IronPort-SDR: NfTW7DsO/pmr3DbMPNsQDBU+al69FXxgUVh84B0vwwT6oaMfcA47JlgeA4FGbSKKXIwb6/V4Gr CkEGQ9XbYjPA== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="155858631" X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="155858631" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 03:50:37 -0800 IronPort-SDR: 50YxVQWx7w/Bn5GDVqRIrIgXroLhGrG1Trs338opTXq22nek8tpoe7mUe88eGtjZll8G5GdbEx tnPTzrZguTpA== X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="537990551" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.219.143]) ([10.213.219.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 03:50:33 -0800 To: SteveX Yang , dev@dpdk.org Cc: konstantin.ananyev@intel.com, beilei.xing@intel.com, wenzhuo.lu@intel.com, bernard.iremonger@intel.com, qiming.yang@intel.com, mdr@ashroe.eu, nhorman@tuxdriver.com, Andrew Rybchenko , Thomas Monjalon References: <20201028030334.30300-1-stevex.yang@intel.com> <20201102085234.72779-1-stevex.yang@intel.com> <20201102085234.72779-3-stevex.yang@intel.com> From: Ferruh Yigit Message-ID: <6ee90e04-db8d-e2a9-3981-ae07e3a3d409@intel.com> Date: Mon, 2 Nov 2020 11:50:31 +0000 MIME-Version: 1.0 In-Reply-To: <20201102085234.72779-3-stevex.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 8:52 AM, SteveX Yang wrote: > Annouce to replace 'RTE_ETHER_MAX_LEN' with 'RTE_ETHER_MTU' as type > condition of jumbo frame. Involved scopes: > - rte_ethdev; > - app, e.g.: test-pmd, test-eventdev; > - examples, e.g.: ipsec-secgw, l3fwd, vhost; > - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e, ixgbe; > > Signed-off-by: SteveX Yang > --- > doc/guides/rel_notes/deprecation.rst | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 2e082499b..fae139f01 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -138,6 +138,18 @@ Deprecation Notices > will be limited to maximum 256 queues. > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. > > +* ethdev: Offload flag ``DEV_RX_OFFLOAD_JUMBO_FRAME`` will be set according to > + ``RTE_ETHER_MTU`` in next release. Currently, the jumbo frame uses the > + ``RTE_ETHER_MAX_LEN`` as boundary condition. When the MTU (1500) set, the > + frame type of rx packet will be different if used different overhead, it will > + cause the consistency issue. Hence, using fixed value ``RTE_ETHER_MTU`` can > + avoid this issue. > + Following scopes will be changed: > + - ``rte_ethdev`` > + - ``app``, e.g.: ``test-pmd``, ``test-eventdev``; > + - ``examples``, e.g.: ``ipsec-secgw``, ``l3fwd``, ``vhost``; > + - net PMDs which support VLAN tag(s) within overhead, e.g.: ``i40e``; > + > * cryptodev: support for using IV with all sizes is added, J0 still can > be used but only when IV length in following structs ``rte_crypto_auth_xform``, > ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal > Reviewed-by: Ferruh Yigit The mentioned code in the ethdev is: http://lxr.dpdk.org/dpdk/v20.08/source/lib/librte_ethdev/rte_ethdev.c#L1345 cc'ed other ethdev maintainers.