From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC1C2A04DD; Tue, 21 Jan 2020 17:43:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B13C11B952; Tue, 21 Jan 2020 17:43:39 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D940014583 for ; Tue, 21 Jan 2020 17:43:38 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 08:43:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,346,1574150400"; d="scan'208";a="215595014" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.35]) ([10.237.221.35]) by orsmga007.jf.intel.com with ESMTP; 21 Jan 2020 08:43:35 -0800 To: alvinx.zhang@intel.com, haiyue.wang@intel.com, qi.z.zhang@intel.com, beilei.xing@intel.com, xiaolong.ye@intel.com Cc: dev@dpdk.org References: <1578625225-110361-1-git-send-email-alvinx.zhang@intel.com> <1578625225-110361-3-git-send-email-alvinx.zhang@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <6efa95b9-d8ef-ce04-4ecb-7242472786e0@intel.com> Date: Tue, 21 Jan 2020 16:43:35 +0000 MIME-Version: 1.0 In-Reply-To: <1578625225-110361-3-git-send-email-alvinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC 3/7] drivers/net: add igc make X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/10/2020 3:00 AM, alvinx.zhang@intel.com wrote: > From: Alvin Zhang > > Add make files to igc PMD. > > Signed-off-by: Alvin Zhang > --- > drivers/net/Makefile | 1 + > drivers/net/igc/Makefile | 83 ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+) > create mode 100644 drivers/net/igc/Makefile > > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > index cee3036..427a757 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -24,6 +24,7 @@ ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy) > DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += dpaa2 > endif > DIRS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += e1000 > +DIRS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += igc > DIRS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += ena > DIRS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc > DIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic > diff --git a/drivers/net/igc/Makefile b/drivers/net/igc/Makefile > new file mode 100644 > index 0000000..a167d73 > --- /dev/null > +++ b/drivers/net/igc/Makefile > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2010-2020 Intel Corporation > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_pmd_igc.a > + > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -DALLOW_EXPERIMENTAL_API > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs > +LDLIBS += -lrte_bus_pci > + > +EXPORT_MAP := rte_pmd_igc_version.map > + > +LIBABIVER := 0 There shouldn't be LIBABIVER anymore, it is confusing the build system. Also please start with as empty as possible Makefile and add things as they are needed, like are all lddibs or clags are required in this stage? > + > +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) > +# > +# CFLAGS for icc > +# > +CFLAGS_BASE_DRIVER = -diag-disable 177 -diag-disable 181 > +CFLAGS_BASE_DRIVER += -diag-disable 869 -diag-disable 2259 > +else > +# > +# CFLAGS for gcc/clang > +# > +CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter > +CFLAGS_BASE_DRIVER += -Wno-unused-variable > +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) > +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation > +ifeq ($(shell test $(GCC_VERSION) -ge 70 && echo 1), 1) > +CFLAGS_BASE_DRIVER += -Wno-implicit-fallthrough > +endif > +endif > +endif > +endif > + > +# > +# Add extra flags for base driver files (also known as shared code) > +# to disable warnings in them > +# > +BASE_DRIVER_OBJS=$(sort $(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))) > +$(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER))) > + > +VPATH += $(SRCDIR)/base > + > +# > +# all source are stored in SRCS-y > +# > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_80003es2lan.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_82540.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_82541.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_82542.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_82543.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_82571.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_82575.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_api.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_base.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_i210.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_i225.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_ich8lan.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_impl_guide.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_mac.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_manage.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_mbx.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_nvm.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_osdep.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_phy.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += e1000_vf.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += igc_ethdev.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += igc_txrx.c > +SRCS-$(CONFIG_RTE_LIBRTE_IGC_PMD) += igc_logs.c > + > +# install this header file > +# SYMLINK-$(CONFIG_RTE_LIBRTE_IGC_PMD)-include := rte_pmd_igc.h > + > +include $(RTE_SDK)/mk/rte.lib.mk >