* [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device
@ 2021-09-15 5:08 dapengx.yu
2021-09-15 6:58 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: dapengx.yu @ 2021-09-15 5:08 UTC (permalink / raw)
To: Chas Williams, Min Hu (Connor); +Cc: dev, Dapeng Yu, stable
From: Dapeng Yu <dapengx.yu@intel.com>
If the bond device was created by vdev mode, the kvlist was not free
after the bond device was closed.
This patch fixes it.
Fixes: 144dc4739975 ("net/bonding: fix leak on remove")
Cc: stable@dpdk.org
Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index a6755661c4..2e96b850fb 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2163,6 +2163,9 @@ bond_ethdev_close(struct rte_eth_dev *dev)
*/
rte_mempool_free(internals->mode6.mempool);
+ if (internals->kvlist != NULL)
+ rte_kvargs_free(internals->kvlist);
+
return 0;
}
@@ -3475,8 +3478,6 @@ bond_remove(struct rte_vdev_device *dev)
ret = bond_ethdev_stop(eth_dev);
bond_ethdev_close(eth_dev);
}
- if (internals->kvlist != NULL)
- rte_kvargs_free(internals->kvlist);
rte_eth_dev_release_port(eth_dev);
return ret;
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device
2021-09-15 5:08 [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device dapengx.yu
@ 2021-09-15 6:58 ` Min Hu (Connor)
2021-09-15 7:18 ` Yu, DapengX
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-09-15 6:58 UTC (permalink / raw)
To: dapengx.yu, Chas Williams; +Cc: dev, stable
Hi, dapengx,
Why not free internals->kvlist at the end of "bond_ethdev_configure" ?
Does it call some bugs?
在 2021/9/15 13:08, dapengx.yu@intel.com 写道:
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> If the bond device was created by vdev mode, the kvlist was not free
> after the bond device was closed.
>
> This patch fixes it.
>
> Fixes: 144dc4739975 ("net/bonding: fix leak on remove")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index a6755661c4..2e96b850fb 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2163,6 +2163,9 @@ bond_ethdev_close(struct rte_eth_dev *dev)
> */
> rte_mempool_free(internals->mode6.mempool);
>
> + if (internals->kvlist != NULL)
> + rte_kvargs_free(internals->kvlist);
> +
> return 0;
> }
>
> @@ -3475,8 +3478,6 @@ bond_remove(struct rte_vdev_device *dev)
> ret = bond_ethdev_stop(eth_dev);
> bond_ethdev_close(eth_dev);
> }
> - if (internals->kvlist != NULL)
> - rte_kvargs_free(internals->kvlist);
> rte_eth_dev_release_port(eth_dev);
>
> return ret;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device
2021-09-15 6:58 ` Min Hu (Connor)
@ 2021-09-15 7:18 ` Yu, DapengX
2021-09-15 8:16 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: Yu, DapengX @ 2021-09-15 7:18 UTC (permalink / raw)
To: Min Hu (Connor), Chas Williams; +Cc: dev, stable
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Wednesday, September 15, 2021 2:59 PM
> To: Yu, DapengX <dapengx.yu@intel.com>; Chas Williams <chas3@att.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [PATCH] net/bonding: fix memory leak on closing device
>
> Hi, dapengx,
> Why not free internals->kvlist at the end of
> "bond_ethdev_configure" ?
> Does it call some bugs?
Just try not to deviate too much from the previous fix: 144dc4739975 ("net/bonding: fix leak on remove")
Since it is reasonable.
And releasing port resource in bond_ethdev_close() is in order to
avoid that memory leak detect tool to find memory leak after device is closed.
free internals->kvlist at the end of "bond_ethdev_configure" is also ok.
>
> 在 2021/9/15 13:08, dapengx.yu@intel.com 写道:
> > From: Dapeng Yu <dapengx.yu@intel.com>
> >
> > If the bond device was created by vdev mode, the kvlist was not free
> > after the bond device was closed.
> >
> > This patch fixes it.
> >
> > Fixes: 144dc4739975 ("net/bonding: fix leak on remove")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> > ---
> > drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> > b/drivers/net/bonding/rte_eth_bond_pmd.c
> > index a6755661c4..2e96b850fb 100644
> > --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> > @@ -2163,6 +2163,9 @@ bond_ethdev_close(struct rte_eth_dev *dev)
> > */
> > rte_mempool_free(internals->mode6.mempool);
> >
> > + if (internals->kvlist != NULL)
> > + rte_kvargs_free(internals->kvlist);
> > +
> > return 0;
> > }
> >
> > @@ -3475,8 +3478,6 @@ bond_remove(struct rte_vdev_device *dev)
> > ret = bond_ethdev_stop(eth_dev);
> > bond_ethdev_close(eth_dev);
> > }
> > - if (internals->kvlist != NULL)
> > - rte_kvargs_free(internals->kvlist);
> > rte_eth_dev_release_port(eth_dev);
> >
> > return ret;
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device
2021-09-15 7:18 ` Yu, DapengX
@ 2021-09-15 8:16 ` Min Hu (Connor)
2021-09-21 8:04 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-09-15 8:16 UTC (permalink / raw)
To: Yu, DapengX, Chas Williams; +Cc: dev, stable
Acked-by: Min Hu (Connor) <humin29@huawei.com>
在 2021/9/15 15:18, Yu, DapengX 写道:
>
>
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Wednesday, September 15, 2021 2:59 PM
>> To: Yu, DapengX <dapengx.yu@intel.com>; Chas Williams <chas3@att.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [PATCH] net/bonding: fix memory leak on closing device
>>
>> Hi, dapengx,
>> Why not free internals->kvlist at the end of
>> "bond_ethdev_configure" ?
>> Does it call some bugs?
>
> Just try not to deviate too much from the previous fix: 144dc4739975 ("net/bonding: fix leak on remove")
> Since it is reasonable.
> And releasing port resource in bond_ethdev_close() is in order to
> avoid that memory leak detect tool to find memory leak after device is closed.
>
> free internals->kvlist at the end of "bond_ethdev_configure" is also ok.
>
>>
>> 在 2021/9/15 13:08, dapengx.yu@intel.com 写道:
>>> From: Dapeng Yu <dapengx.yu@intel.com>
>>>
>>> If the bond device was created by vdev mode, the kvlist was not free
>>> after the bond device was closed.
>>>
>>> This patch fixes it.
>>>
>>> Fixes: 144dc4739975 ("net/bonding: fix leak on remove")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
>>> ---
>>> drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
>>> b/drivers/net/bonding/rte_eth_bond_pmd.c
>>> index a6755661c4..2e96b850fb 100644
>>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>>> @@ -2163,6 +2163,9 @@ bond_ethdev_close(struct rte_eth_dev *dev)
>>> */
>>> rte_mempool_free(internals->mode6.mempool);
>>>
>>> + if (internals->kvlist != NULL)
>>> + rte_kvargs_free(internals->kvlist);
>>> +
>>> return 0;
>>> }
>>>
>>> @@ -3475,8 +3478,6 @@ bond_remove(struct rte_vdev_device *dev)
>>> ret = bond_ethdev_stop(eth_dev);
>>> bond_ethdev_close(eth_dev);
>>> }
>>> - if (internals->kvlist != NULL)
>>> - rte_kvargs_free(internals->kvlist);
>>> rte_eth_dev_release_port(eth_dev);
>>>
>>> return ret;
>>>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device
2021-09-15 8:16 ` Min Hu (Connor)
@ 2021-09-21 8:04 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2021-09-21 8:04 UTC (permalink / raw)
To: Min Hu (Connor), Yu, DapengX, Chas Williams; +Cc: dev, stable
On 9/15/2021 9:16 AM, Min Hu (Connor) wrote:
<...>
>>> 在 2021/9/15 13:08, dapengx.yu@intel.com 写道:
>>>> From: Dapeng Yu <dapengx.yu@intel.com>
>>>>
>>>> If the bond device was created by vdev mode, the kvlist was not free
>>>> after the bond device was closed.
>>>>
>>>> This patch fixes it.
>>>>
>>>> Fixes: 144dc4739975 ("net/bonding: fix leak on remove")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-21 8:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 5:08 [dpdk-dev] [PATCH] net/bonding: fix memory leak on closing device dapengx.yu
2021-09-15 6:58 ` Min Hu (Connor)
2021-09-15 7:18 ` Yu, DapengX
2021-09-15 8:16 ` Min Hu (Connor)
2021-09-21 8:04 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).