From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 783D51CF0E for ; Fri, 6 Apr 2018 12:54:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2018 03:54:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,415,1517904000"; d="scan'208";a="48488409" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.27]) ([10.67.68.27]) by orsmga002.jf.intel.com with ESMTP; 06 Apr 2018 03:54:29 -0700 To: "Tan, Jianfeng" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" , "Van Haaren, Harry" References: <1522779443-1932-1-git-send-email-jia.guo@intel.com> <1522779443-1932-2-git-send-email-jia.guo@intel.com> Cc: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Zhang, Helin" From: "Guo, Jia" Message-ID: <6f629d49-a085-e0de-d030-ef173d14bdab@intel.com> Date: Fri, 6 Apr 2018 18:54:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V18 1/5] bus: introduce device hot unplug handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 10:54:33 -0000 thanks. On 4/4/2018 12:31 PM, Tan, Jianfeng wrote: > >> -----Original Message----- >> From: Guo, Jia >> Sent: Wednesday, April 4, 2018 2:17 AM >> To: stephen@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; >> Ananyev, Konstantin; gaetan.rivet@6wind.com; Wu, Jingjing; >> thomas@monjalon.net; motih@mellanox.com; Van Haaren, Harry; Tan, >> Jianfeng >> Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo, >> Jia; Zhang, Helin >> Subject: [PATCH V18 1/5] bus: introduce device hot unplug handle >> >> As of device hot unplug, we need some preparatory measures so that we will >> not encounter memory fault after device have been plug out of the system, >> and also let we could recover the running data path but not been break. >> This allows the buses to handle device hot unplug event. >> In the following patch, will show how to handle the case for pci bus. > Squeeze this patch with the next one. > >> Signed-off-by: Jeff Guo >> --- >> v16->v15: >> split patch, and remove the ops from RTE_VERIFY >> --- >> lib/librte_eal/common/include/rte_bus.h | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/lib/librte_eal/common/include/rte_bus.h >> b/lib/librte_eal/common/include/rte_bus.h >> index 6fb0834..ecd8b1c 100644 >> --- a/lib/librte_eal/common/include/rte_bus.h >> +++ b/lib/librte_eal/common/include/rte_bus.h >> @@ -168,6 +168,19 @@ typedef int (*rte_bus_unplug_t)(struct rte_device >> *dev); >> typedef int (*rte_bus_parse_t)(const char *name, void *addr); >> >> /** >> + * Implementation specific hot unplug handler function which is responsible >> + * for handle the failure when hot unplug the device, guaranty the system >> + * would not crash in the case. >> + * @param dev >> + * Pointer of the device structure. >> + * >> + * @return >> + * 0 on success. >> + * !0 on error. >> + */ >> +typedef int (*rte_bus_handle_hot_unplug_t)(struct rte_device *dev); >> + >> +/** >> * Bus scan policies >> */ >> enum rte_bus_scan_mode { >> @@ -209,6 +222,8 @@ struct rte_bus { >> rte_bus_plug_t plug; /**< Probe single device for drivers */ >> rte_bus_unplug_t unplug; /**< Remove single device from driver >> */ >> rte_bus_parse_t parse; /**< Parse a device name */ >> + rte_bus_handle_hot_unplug_t handle_hot_unplug; /**< handle when device >> + hot unplug */ > May be just rte_bus_hot_unplug_t hot_unplug /**< Handle hot unplug device event */ > >> struct rte_bus_conf conf; /**< Bus configuration */ >> rte_bus_get_iommu_class_t get_iommu_class; /**< Get iommu >> class */ >> }; >> -- >> 2.7.4