From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9696A04B3; Wed, 29 Jan 2020 00:45:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00D4A1C2E7; Wed, 29 Jan 2020 00:45:13 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 57FA61C1C8 for ; Wed, 29 Jan 2020 00:45:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 15:45:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,375,1574150400"; d="scan'208,217";a="217782856" Received: from unknown (HELO [10.241.225.137]) ([10.241.225.137]) by orsmga007.jf.intel.com with ESMTP; 28 Jan 2020 15:45:10 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com, antara.ganesh.kolar@intel.com, stephen@networkplumber.org References: <20200109031312.6344-1-pallavi.kadam@intel.com> <20200113215534.10084-1-pallavi.kadam@intel.com> <20200113215534.10084-8-pallavi.kadam@intel.com> <2703260.e9J7NaK4W3@xps> From: Pallavi Kadam Message-ID: <6f6e13ed-ee75-cbaa-b9f4-3bf7999819ae@intel.com> Date: Tue, 28 Jan 2020 15:45:10 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <2703260.e9J7NaK4W3@xps> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 7/9] eal: remove syslog support for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/27/2020 2:52 PM, Thomas Monjalon wrote: > 13/01/2020 22:55, Pallavi Kadam: >> Added #ifndef WIN64 to exclude syslog definitions and parameters >> from Windows builds. >> >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Ranjit Menon >> --- >> --- a/lib/librte_eal/common/eal_common_options.c >> +++ b/lib/librte_eal/common/eal_common_options.c >> @@ -204,9 +206,9 @@ eal_reset_internal_config(struct internal_config *internal_cfg) >> internal_cfg->hugepage_info[i].lock_descriptor = -1; >> } >> internal_cfg->base_virtaddr = 0; >> - > Please keep blank lines Sure, will add new lines here. > >> +#ifndef _WIN64 > Could it be #ifdef LOG_DAEMON? Will update this in v6. > >> internal_cfg->syslog_facility = LOG_DAEMON; >> - >> +#endif > [..] >> @@ -1391,7 +1395,7 @@ eal_parse_common_option(int opt, const char *optarg, >> +#ifndef _WIN64 >> case OPT_SYSLOG_NUM: >> if (eal_parse_syslog(optarg, conf) < 0) { > Instead of adding #ifdef, I think we could introduce eal_parse_unix_option() > in a separate file, and it would call eal_parse_common_option(). > So in Windows, you just skip it by calling directly eal_parse_common_option() > which would be truly common. We might have to include changes in multiple files once we create a 'unix' directory to introduce unix based functions and then test it on Linux and FreeBSD. For this release, will include #ifndef RTE_EXEC_ENV_WINDOWS for syslog functions and can add unix based functions in the next release. > > >