From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5A8D43EE9; Tue, 23 Apr 2024 13:15:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6BB040E54; Tue, 23 Apr 2024 13:15:38 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2078.outbound.protection.outlook.com [40.107.244.78]) by mails.dpdk.org (Postfix) with ESMTP id B204F402AB for ; Tue, 23 Apr 2024 13:15:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BwMvUcgjwxMrLppKA+Ww6Ie+9W+/CRqMbbfX/3H70RKrSLhTRcJMTr+p4kXvEXruUewWMvn7rxTe5EMXXMk/nj9mg+KCpcJhCa6YiETGvPVFr32iBU+uNNBEc4c0AXJAUiinxoLMNP+ME1mCzrL/C2tcsywqlDKffjVlmIxIsPmPRaMVUxQRd0XXWdb+paLdFLvHVoN8B8tdJT2Y0G5Yg30odUM5QTqRD6nM+XMv3k7//boyp9Bht76AZDgSE53AvR/0sBG2pU5XSZsVxcJn7MHSHBsKtKbfsaotKzC0g+Xb4RTgN/TgHzchBoL/wVPeSBSnJzFfGoCtQGhjeULEmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AYdJTbmuBxcBGd21eS6tuKAyOeXfCi/nqTnx4pkmGu8=; b=Nzq0fgc3zOU7p0TyVmzg6g7dAvrfVAn4d+LLBbbJ1EX+QryHeg3MJs9nMTaVDB5hYtJpYhJvLzFjLFyQ3psZshHxjewPnTsx0YIPezMXzZSnuR3FA5DEgN6vXCbvIbr+3wfRm8g0H2E6eGnDlfXpYU2bA1T7AnsbWioF2lnb5xEp50DLous/gF48VqvfrjZR/V7m2AhG/l85zGue5AqR8DcSpjkfn1amQuXYWWmOZQkgGjtLvi5juIxJXKk+Dp/bxx522vRob6pIRpdbWxO5/vtm9iu1eqc4yDidDJq/a7mhlak/4mCqc9+5iP6OI2j1QeSSvkh7ZmOOjSIwB1qrVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AYdJTbmuBxcBGd21eS6tuKAyOeXfCi/nqTnx4pkmGu8=; b=S8EabPGWtyBJ+jVHtwXyAuPo/x2gNIyReTpFF/3QmgM2A1rjOewRb55clXuXaDGcICR3j0oQvflxYmrhtMhDVwJTic7PjMrWmeZtrPfM7Ps3urDdbpvTUnNiX3tj4WLt33ITT8RzMvaRfTxufjwOVcatF/m2nQMkkG5pUo6QZ4c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB7682.namprd12.prod.outlook.com (2603:10b6:930:85::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 11:15:34 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7472.044; Tue, 23 Apr 2024 11:15:31 +0000 Message-ID: <6f7aabcb-2c12-4cfe-ae9d-73b42bfd4977@amd.com> Date: Tue, 23 Apr 2024 12:15:27 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/af_packet: cache align Rx/Tx structs To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "John W . Linville" Cc: dev@dpdk.org, hofors@lysator.liu.se, Tyler Retzlaff References: <20240423090813.94110-1-mattias.ronnblom@ericsson.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240423090813.94110-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0165.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB7682:EE_ X-MS-Office365-Filtering-Correlation-Id: 982a6706-188a-4336-6d92-08dc6386b025 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WTI0VnFFOUZXMy90bXpoMWlBWEhMdUZQR1pEL3lQUElWWVJXMmhPektnQXNs?= =?utf-8?B?K3pmaHRKakpPTTh3UE9RQWdsMFN0Z2xmbzk3dndvd0d5THFCcHR2Nzk3N1lZ?= =?utf-8?B?QWhkbzVIRDBaOGd0SzRkNDh4V3B5eVFlVzYrNVZGU1RmbnhkMVVHMVVJZnox?= =?utf-8?B?ZzRoREN2dmV3OU5XY1dyUmtjdkZzV2xDNlh6MUF5QWM0cEpFRS9qK0s5bzk5?= =?utf-8?B?RkFMcVZ4SUFzVTVlckY0NkFod2YrbGtiSys3NXVwT3BlemNhWmc3WFpndVdp?= =?utf-8?B?UzRQamxiQTk1bitOVWlnTERtZVN4OSt1V0NDNjU3Y09sK1ljSlRkZDFRazlV?= =?utf-8?B?VzN5SmtBWjZRT0xLajVyU2IvLzRsRmZqSXJRZGhyeDIyN0ZUd0dEZVhVWlVC?= =?utf-8?B?QmdRd001RlN5YVcvSVFWU3hnZmJOandNNStFTFgxcnBEUGpDNE1wV21DNWYw?= =?utf-8?B?dGZxK0hUQ0JVSUtNQmU2VVRTMGFFZElWblJmSm5OUjB0TkRkeGdOR2ZvaE1M?= =?utf-8?B?OGtRdVJEaGxCMGpodzVlZjFvbEpjdjlMY1BtTHhwTng4cVpYZlM5b0c5SnpC?= =?utf-8?B?WDJTdWRJaW1XZEVyd08wbHFDMnZqSFhOZGtxbFNveVVWVXIveHJsbGdycFdT?= =?utf-8?B?cFh4NzBaS2c1V2pqUlRqSFFkVENXaVFvTXROY2ZDRW42RUd1U3crNVU2bjcr?= =?utf-8?B?UERxdFgxeHZoVHppZDh4dk5TNElYVFEyUldlN2Z6czM2SE5QWUxMZDJsTHFw?= =?utf-8?B?cUJzOG9TWjd5aUc0NlcvSWVaWHBhMXNDczhiZ3BXR2h2QzRhWE9pQ3FRQ2pv?= =?utf-8?B?bzl3c2p3anhjQ3l1Q0w1WjVtQXhjOHNNQ1JVMVQvY2lPcVNpa1c1bVVwQ0tI?= =?utf-8?B?YXRoUWZNb0pKK3R3UDN3Z0xrVGNzL2h0UmZHdlJzeXQrZlNEUHFJM092Z004?= =?utf-8?B?WE9qdnFLN2hWWnZoMFZ2VWxVVXMxMXNUU3Iza3VyeXZCK3ZMU2hES0gvQ1lQ?= =?utf-8?B?S0JMQ3dxK1kyc1RuZm5ZQmYwdGZYKzRxN1d6MzJzL3JNL2ZZSlAzQzBUQVMz?= =?utf-8?B?Wk0rclFmZllEeWY3Wjl6QlRlYmhiL1orYWhBcWIxbC82SG1lTGlCQXE0WUtL?= =?utf-8?B?bkwvTlcydnlTcXNpcThMSUhpT0E4V1pTU1lWRUF6RzNOM0NXUmdtQVlPeStq?= =?utf-8?B?S1c1NU9FUWNVMGFhQnBjZEZQUEpraWdBV0tXMWxUUm5zVzQ0elp2REtpTmU2?= =?utf-8?B?ZDRJVmovT29WYXZ6Q3RMZjRPcUkzbldpY2JMd2QyUy9BK1JuY2JsNVp4NkM3?= =?utf-8?B?aUM4elI4WlpSRGFMMXppOWN5SFBONEZxYS9lbnUwMzN0QnVQcnZaTE9zTjdG?= =?utf-8?B?Nmhjd1pxUmdKWS9TajZmbVZxUUFjcEVZbjhCem5sQVZFbkxZMWNPblk1OTBB?= =?utf-8?B?eFZTTFZ3clRxcXN3L0NNcGgzQWRBS1FBNG9WSmV4STdJZS8yU3FCLzJZM2hJ?= =?utf-8?B?Z3hpb2cwVTNzQUR1bmVCS0ROM0tLakdVNEs0TUJGdjdBS2Ewa1ZIcm1yd05H?= =?utf-8?B?UGFFVkJ0a2gzV0ZkcHU1MzRxbDFWN0Fnak5UaERZOW5QbEZRZWRBemhKV01r?= =?utf-8?B?cFV1UTc1b1R1azBPN0d2eVozdmlCUndMQUlNV0dyTnZ1Q3Y0Unh6UWF3ZTBo?= =?utf-8?B?TDE3ZFBrU2RnTWd0aTVRVWVjd0FVOFh3amRvSlRTK0hkOXI0RjdIamFnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUNRWEluL3diSGtVWXVMRlcyQ29ESEY5K3ozL0ltTFlSbFk0U3E3czE0R1VU?= =?utf-8?B?UDlzY2JKKzg2U1Y4aVVYWGNURlZKVWFWVW84UFlwNVc2REVQTHVsSGs2WitE?= =?utf-8?B?alpSTyt2ZTRSbGc3Ty9rdkx4QU9CV25DN25PcXJVLzh3K2I0enZiYi90STRw?= =?utf-8?B?a3RNZHlxVnE2MiszMCtVRTBJQzliQXUrZ2tTamJJTjErZTZnWU5LYmNmNDhP?= =?utf-8?B?RitWSjFLdXRrMVhLVmIxUk8rdUg1Z1lUUUVKNUt0eDVhU0ZqcHBuNkFqbnZO?= =?utf-8?B?dnp4RTdpWkNnL1dqdFQxKy9Cc20vNEZIcy8waThTSXlUS2FhbmJmMThKTmFQ?= =?utf-8?B?UXBkS1E0RFN2ZkZBQlIwdDA3aXJHZklHMWthbVdmUVV4cmJCOFY5eUJaSTh2?= =?utf-8?B?OGU5VzRCZTJ1Mks4YWFwdDl2NW1vWXVCYWtzNVMyMWhWQkpUaHlSU3AwazFn?= =?utf-8?B?UkI1T1FKVjhRemhmei9iQkh6UWRON1FhakNlUjhyM3ZSMVNkREdKWXpMczFy?= =?utf-8?B?bUdlR3A2QlR6YWNGbG1qTFFFcmk3U09ET0FLZEpqblAzSW4wVmhnUmtvZGI4?= =?utf-8?B?dEJ2akd0WE5rWnVLVnFDVnFXYzBVR3UrWVJ6MGtwUC9DKzI5RmlxekdtdkhD?= =?utf-8?B?SkVNcGI5U3J6SS9jUjJsRDFScmgyQXo0RGhnb3dHRHNGQ2JGQnFZMnZ1VThX?= =?utf-8?B?bnVIRGVjU3gwbHo5WjV1TG1xRmhUNkM2bmRMUlQ0dERDRG1HRzNXcHBWajRM?= =?utf-8?B?NEFnZUhGOGFOeW9naUgxbmpuLzBPR2o2UWswd1FyeDBIcHowZ2ZxcDd2dDVG?= =?utf-8?B?clNzMCtrZGVlMnQzb3NDNVNlaFcyUFlRTXExbGJMSTdlN0RPK1JGOFMrMjhT?= =?utf-8?B?YTRWUFpMZUtsS1piQlhKdUVKakJBTG9UM0lUeFRvVnZucWo1SUxtMUtlS3Bp?= =?utf-8?B?eFB6VTVrVGFXZDcxRloxZjAvenRwVnpFWmxHODBYR1h0NzlJdVpXS1Y5Sk5N?= =?utf-8?B?YkFZRXJPV1FmbjZVblMrRFZtWmMxMk4xTTNvTW9tbUJ6TFhxS083Z3Vadmta?= =?utf-8?B?V3I1WGVEMDA3SkxYWXZOUVhDNUpNc1hBV094VzMzOXBRdG5RNUcvTEEwUTBS?= =?utf-8?B?elQ0VHpnUnE5L00ydHdWUFozNjdQTVhhcGtJeEtBQ1hBTVlHTUpvd0Q3VGpC?= =?utf-8?B?WmNIazZlUElJRHZJSEZ1cGgvU2g4T1lPQSt0Um1EZlZhSkZzbHpkNWZPYzZQ?= =?utf-8?B?cEZnUkNKY0dqaFl2TE1xVzI3Ry9FMk5wMWxsTElFWEtZYmY1QXMxT1J0ZlpM?= =?utf-8?B?MDhKa1MwMk9IaUxTT1Zvb1NMdnRmZkVIc05jWXlSWWE5aVl3NHgrVjVMM2hp?= =?utf-8?B?KzRtTnhvMTFnc3diNVRTbmJlMWxKNkV2VGdhalorTjhrWjZIbGo0bi9iRkR1?= =?utf-8?B?S3NIczlYSjNiUFNPREU1WEVLTHJiUHRpWjY3NDFzcys0MVUxbkF0TGVFUW1J?= =?utf-8?B?ZnMzQ2RNR1pXZXN3Q3RPc3R1MGxXWE9qVnMyd3ZJcUd2SEhvL2VoVjNFNlk2?= =?utf-8?B?V0hLdWJ1QjdKQ3dzK2J6NmZPc3huVzFMSmMzWGlHM2xzYUp2aVdZU1ozV1RX?= =?utf-8?B?K05LWjZQdEh0ck4xWUFoZzB4bFllcSsrWTFHOXF5bDVadGlLREcxZUczT3A2?= =?utf-8?B?eDhpem11TE1Ha05CU0x4SXU4ZmZaUVVMdmErZlNtdndmLzhSWDlmb3NkOEJZ?= =?utf-8?B?ZkhiMFZRQXRTU3N5MUlVa3pnWXc5cWc4UVAwOG9uMDFCcWRXc0tQMkRBZFpL?= =?utf-8?B?YUE0UE44ZXNNYkJEWVNJYS8yTHJDcWZOQ0twd3lYMWJkMzlnZWozamZUU1FP?= =?utf-8?B?dmlxb2Rmdmh6M0N3SE1CSmRlK2d4YWxiMEVubXNIVHlyUFFRK21WT3dCdTRv?= =?utf-8?B?U2FMNE11VTZPSmJNU3dzOFNDbjRzekx3SmVOVEZlWTlpRUtva0NMRHBpamJJ?= =?utf-8?B?WER0UjJPSnhqRHZmb2xvNzVUZzBNUzRQNEVqOHJlV3M5SDJEYmQwRHdPdFF3?= =?utf-8?B?QjkwcjViKzlXTGE0NmJVcEFMTzRsd0VUYVQ1UUxjVXVXWkN2dmpoUHZWaEgy?= =?utf-8?Q?RK6PJO8j+XtEq/hEMAjilp6HJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 982a6706-188a-4336-6d92-08dc6386b025 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 11:15:31.3440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /63hfF9pDwztCu7OCLyzTmN4gS7aKcqCGVC+XkFuW5hov/+YTpUih9CzvVExCrUx X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7682 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/23/2024 10:08 AM, Mattias Rönnblom wrote: > Cache align Rx and Tx queue struct to avoid false sharing. > > RX struct happens to be 64 bytes on x86_64 already, so cache alignment > makes no change there, but it does on 32-bit ISAs. > > TX struct is 56 bytes on x86_64. > Hi Mattias, No objection to the patch. Is the improvement theoretical or do you measure any improvement practically, if so how much is the improvement? > Both structs keep counters, and in the RX case they are updated even > for empty polls. > Do you think does it help if move 'rx_pkts' & 'rx_bytes' update within the loop? > Signed-off-by: Mattias Rönnblom > --- > drivers/net/af_packet/rte_eth_af_packet.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index 397a32db58..28aeb7d08e 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -6,6 +6,7 @@ > * All rights reserved. > */ > > +#include > #include > #include > #include > @@ -53,7 +54,7 @@ struct pkt_rx_queue { > > volatile unsigned long rx_pkts; > volatile unsigned long rx_bytes; > -}; > +} __rte_cache_aligned; > Latest location for '__rte_cache_aligned' tag is at the beginning of the struct [1], so something like: `struct __rte_cache_aligned pkt_rx_queue {` [1] https://patchwork.dpdk.org/project/dpdk/list/?series=31746&state=%2A&archive=both