DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Christensen <drc@linux.vnet.ibm.com>
To: David Marchand <david.marchand@redhat.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: "Wang, Yipeng1" <yipeng1.wang@intel.com>,
	Byron Marohn <byron.marohn@intel.com>, dev <dev@dpdk.org>,
	techboard@dpdk.org, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH] efd: change data type of parameter
Date: Tue, 14 Sep 2021 11:20:51 -0700	[thread overview]
Message-ID: <6f7d44a8-e847-6ad4-0ae6-daf0afc63d8f@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJFAV8xz_XQRNMDZZbX0MQ87-pU=29p3cdxcSpcH2eSw8W=6oQ@mail.gmail.com>



On 9/14/21 12:10 AM, David Marchand wrote:
> On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara
> <pablo.de.lara.guarch@intel.com> wrote:
>>
>> rte_efd_create() function was using uint8_t for a socket bitmask,
>> for one of its parameters.
>> This limits the maximum of NUMA sockets to be 8.
>> Changing to to uint64_t increases it to 64, which should be
>> more future-proof.
> 
> Cc: ppc maintainer, since I think powerX servers have non contiguous
> NUMA sockets.

Definitely correct, POWER CPU NUMA sockets are not necessarily contiguous.

Can you update efd_autotest and efd_perf_autotest as well?  After 
applying this patch the test still fails on my POWER9 system:

$ sudo /home/drc/src/dpdk/build/app/test/dpdk-test -l 64-127 -n 4 --no-pci
...
RTE>>efd_autotest
Entering test_add_delete
EFD: At least one CPU socket must be enabled in the bitmask
EAL: Test assert test_add_delete line 125 failed: Error creating the EFD 
table

Test Failed
RTE>>

On this system lcores 64-127 reside on NUMA socket 8.

Dave

  parent reply	other threads:[~2021-09-14 18:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 16:53 Pablo de Lara
2021-09-13 18:18 ` Mcnamara, John
2021-09-14  7:10 ` David Marchand
2021-09-14 10:49   ` Kinsella, Ray
2021-09-14 18:20   ` David Christensen [this message]
2021-09-17 12:56 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2021-09-20 19:30   ` David Christensen
2021-09-28 14:18     ` De Lara Guarch, Pablo
2021-09-28 13:58   ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2021-09-28 15:52     ` David Christensen
2021-09-29  7:51       ` De Lara Guarch, Pablo
2021-09-29 17:41         ` David Christensen
2021-09-29 18:13       ` Wang, Yipeng1
2021-10-01 14:34         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f7d44a8-e847-6ad4-0ae6-daf0afc63d8f@linux.vnet.ibm.com \
    --to=drc@linux.vnet.ibm.com \
    --cc=byron.marohn@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=techboard@dpdk.org \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).