From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2E45A0C41; Tue, 14 Sep 2021 20:21:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28BB74068F; Tue, 14 Sep 2021 20:21:00 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id EF5C04003C; Tue, 14 Sep 2021 20:20:58 +0200 (CEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18EGUU6h008635; Tue, 14 Sep 2021 14:20:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Z6X/lPQFvkaQk2BPZhbxukx1nmHqjmClMZoJvYX2OS4=; b=BKK4GK0nQBvII0tVnWjihInfcPf0ZgGG2/FV+g9LZozi67iS/reIMBifjSPSAJif1p5y YB4Y0y+HVdGaV7FXQk+h6ZkujYpGUn8uB/KQje0uRMoyylM+AVF1XlRLEiQ/Kve4+bW4 BsECrw0tMXcS6nQYJfRpAN4VkXIMxhQZod9mXlkvvIKKPMoLbu0uJdbsLdDWPFogdtL2 ZhOtL6dlP8EH+TKYuXEFMtryXKhqKBfA4ebNx8VC1XFeU8Pj0UrypuFDvyyzJceDh3YN dsbOpkNYdOByxrI4YSu1/M/yQhICgMqQ40zIbeaOnSbVo6Gp9ZaatUtw38wYHasExhAY bw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b2yaraw0a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 14:20:55 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18EHccM7029398; Tue, 14 Sep 2021 14:20:54 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3b2yaravyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 14:20:54 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18EIHoYI027854; Tue, 14 Sep 2021 18:20:53 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma03dal.us.ibm.com with ESMTP id 3b0m3b6tk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 18:20:53 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18EIKqHI7995678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Sep 2021 18:20:52 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C79EA124055; Tue, 14 Sep 2021 18:20:52 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0639F124052; Tue, 14 Sep 2021 18:20:51 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.211.70.237]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 14 Sep 2021 18:20:51 +0000 (GMT) To: David Marchand , Pablo de Lara Cc: "Wang, Yipeng1" , Byron Marohn , dev , techboard@dpdk.org, Ray Kinsella References: <20210910165346.807715-1-pablo.de.lara.guarch@intel.com> From: David Christensen Message-ID: <6f7d44a8-e847-6ad4-0ae6-daf0afc63d8f@linux.vnet.ibm.com> Date: Tue, 14 Sep 2021 11:20:51 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Kd0sq-OfLsjUG1GMP9_0dZIYqsuTGA4m X-Proofpoint-ORIG-GUID: fVv4bn4z_iPHMahRRlNS2et9mVR2Wnrj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 mlxscore=0 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109140091 Subject: Re: [dpdk-dev] [PATCH] efd: change data type of parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/21 12:10 AM, David Marchand wrote: > On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara > wrote: >> >> rte_efd_create() function was using uint8_t for a socket bitmask, >> for one of its parameters. >> This limits the maximum of NUMA sockets to be 8. >> Changing to to uint64_t increases it to 64, which should be >> more future-proof. > > Cc: ppc maintainer, since I think powerX servers have non contiguous > NUMA sockets. Definitely correct, POWER CPU NUMA sockets are not necessarily contiguous. Can you update efd_autotest and efd_perf_autotest as well? After applying this patch the test still fails on my POWER9 system: $ sudo /home/drc/src/dpdk/build/app/test/dpdk-test -l 64-127 -n 4 --no-pci ... RTE>>efd_autotest Entering test_add_delete EFD: At least one CPU socket must be enabled in the bitmask EAL: Test assert test_add_delete line 125 failed: Error creating the EFD table Test Failed RTE>> On this system lcores 64-127 reside on NUMA socket 8. Dave