From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CD3242C11; Fri, 2 Jun 2023 16:49:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 158B140ED8; Fri, 2 Jun 2023 16:49:51 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2084.outbound.protection.outlook.com [40.107.96.84]) by mails.dpdk.org (Postfix) with ESMTP id 18458406B8 for ; Fri, 2 Jun 2023 16:49:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ampsLg9y883vtAkwwbWjMw4NGYvTD7GDf6WEDeaU6R5TQzTpxwmLse2nSvzbYOs8pP677URiamHKEd29PDFXBqqxkbgpq/dqiM8UARRYv8QCLs08lh9DJjSeWuo88FkjWc9PQLY6+nV5SlC/oOOfFRW/gaM6RPGtXkXXp3dfXFK9PJpGrK6Pu6wuMXyeLaycSlb82mJrT3XrCb/nxEJCWBLx14mjGZ6kbX7h2Z8hhKlM0RHF0lMXO6/JjXNFHz92VfOnQiWxwmahCECvBlnnv/r2a1LLZQhl3AbPx/rfceHDR5mnk40bvsZzCN2RdgqJNJqc+mNc+2IXZCeLHJ04DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VJp9qlB6sK0bkmsmumMhKR00T0etM85/JaQz/86cGFY=; b=hjpUSOFWD+6kg05lv4Dptk+5cdXFt2W83S+u15UWMpy7U5vLiOpbm8jNQPsTVYlr6aT1zGNQHuQmvoe3iXpmd/GTalxua90FkxAs0ktXDNDAMSvnNNZBVo0bJF8nJRk2Cn6BpyuVoL461IbzKHToeS5e2S6kfI0TtSpbgDAvSOCS/O7eYrUZ0XrT/ObbmpAkXG6Ud+ygPT8c1K2WLCPRl+urz3Y/EqVloLAyXow8isaX+yF71jdPc7GS+9H5keYjhRrtPt4ZEPhQFvo8M+ggKJgtyIqpr7aObWf2EGBr4bRdKiOHSxxdqMxPw5aW96n3jzFCa0gOD22WSLbtZV/3wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VJp9qlB6sK0bkmsmumMhKR00T0etM85/JaQz/86cGFY=; b=HeJ/csKTjtNqaEuzlLlVa2/6iNoG5jPIT1N+8adwivQsEIkMc39s3bmnXMygpNfKn3XxTbGByU7Pi0Di9P05MkqzNtj5pnQ5fxlbthJ6oTLo0tFBgAhn6lWUE2LiF/VJgLMbuK4ItsyA59tqeDWwSCGg9KHK8OqKiz3SYCUM/1M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8877.namprd12.prod.outlook.com (2603:10b6:610:170::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.24; Fri, 2 Jun 2023 14:49:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Fri, 2 Jun 2023 14:49:47 +0000 Message-ID: <6f87b15e-2618-46a8-e43c-ddec57270c6d@amd.com> Date: Fri, 2 Jun 2023 15:49:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Rushil Gupta Cc: qi.z.zhang@intel.com, junfeng.guo@intel.com, dev@dpdk.org References: <20230601031513.453016-1-rushilg@google.com> <20230601044950.465926-1-rushilg@google.com> <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com> <660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com> From: Ferruh Yigit Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0012.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8877:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ba602fd-b78d-41c8-7290-08db63789bf3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +SYyPFplFJyXdAxOQHZXWFH6OnGtrgDUKcyNbwYe3YCQT7EZHGJeD8SLupGw4iQlvwVcBB21naYLcvyFTL1ZzXYD1GtJndoA6GEKbkGQsK/OyASehbuWWNsS9B/AclyNflDlkX4KbsFxBnzGY7fCSuZFcJk+NipELIpfZuCRb6NrFxf410a6bXBcsGzbcTKiB0AcL4iVWcly5pHWxU9zNgvqCMJ1kVlAzkU1YhxkVENSAU1jkENFSEh2tqkTSSH1VupLJ3bufRKwcAnDMw+3z6U/zWFpm4uk9fclqkMBlR3y7C28WtPW+WIv/UTsRc2kLCgoQQsqExEXehTB5auZCs/IKsW28pcJ7raxadg0iUWCtYVY2pk4aUwBbF6WJrc5LWOg5Fmri/MRcNG5s5PJdHDWeJc5YDaM+hAvDSA0bMFbxEFzGJei4EOocYkgEMKxznhPGXJfjdueL7xEkZl3NX868aXvUXmFQf2U8mKXB7WYw/Yuc3kVheppjy+ZBMjb/bUSv/vU4fNB/weLjnqrmq0otIesp3lV/MGGUwvq2+EVivLKDH0wU4ki7bTzUMtEBTLKPErBNuSr57X8sBM+G8UnsTx27cYkA1EHLcPClJ4nv3gP6L1uVLQhNd2orq9gLlN88IKrjQ/CmLidy7YVoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(451199021)(31686004)(83380400001)(36756003)(4326008)(41300700001)(38100700002)(316002)(53546011)(6506007)(6666004)(6486002)(26005)(6512007)(66476007)(6916009)(66946007)(66556008)(44832011)(2906002)(8676002)(15650500001)(31696002)(5660300002)(8936002)(2616005)(478600001)(86362001)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGpZZGFrWi8wOXVSZFhmdGlwVS9uS25BVCtCSG84dllzTy9yd3lBWEx2c1VL?= =?utf-8?B?a3d0eW9LL00rSjhxZWJINmVRYnk2S0ZrcWNYQUI4Y2JIb2tXQ1VsSmJaRlpw?= =?utf-8?B?OC8wdHhkMnN2S09vWlo2YTk0NVlzL1N4NU5wN2NESXNQdmdKVVdrY2laTWtT?= =?utf-8?B?OXNzWFpHSDBhZUlIMFMyN2xDM2YvanhEb2gyQ1hTdVVPUm9wRVdJQ1phU1cw?= =?utf-8?B?WEhsUERpajNRdnV3c3dpbEdCQ0RDSEFZcW91MXdneHlGdlJPL243bnRFRmJ4?= =?utf-8?B?MzdxTmVoM2s0VmorTHdJUUttN0xvRVp6aGdRS0w0K1FOVmFPdW41ZllnTXNr?= =?utf-8?B?RHNsQU1lWml0dXdYaTU2cDFxZThITHlwWmFFNENjaTlkd3Mrd0dhTzNzSUxU?= =?utf-8?B?SWVhU1lsNTd2TlhmWmxGdmpNeFhwem9rWDdOSThUcmNzOUF1UUk1MTcvOHRR?= =?utf-8?B?ZnJ0aitCSXk2VEtLNkEvY241N3Y4WnFUbHNZWVdsZFJ3clFicXlIL3IzWENp?= =?utf-8?B?TWx0MC9VUDAxVG1TUnpLSjF6N1JwNE45VWl0cXNOQ1RJVkFIUkNSL3NoY1dk?= =?utf-8?B?QUNQVnRuNm4vOGZXdVpRZ2psUHJQSnZlanRZdlE5RVpqMlJHVUhxcVV0RHdC?= =?utf-8?B?bCtOeFRJaCtiVmdpSlVudUo1Tk0yQW5ZYkk3ZXdwc1VLOWdheGhYb3d1MDYw?= =?utf-8?B?RysrZ0xLRnArU1RjUXVDRmNVWmYwNVN4RHFvT1ZvQkNjU1B2SkJBSVE2SVo5?= =?utf-8?B?dVhqdXlyLzFpWWRHd2tVb1phZHhuV0Nnc2t0eFZJNDFCTDNMYjA0aldtM1BJ?= =?utf-8?B?em9wVENnakFmdWdjT0hSY21XWDJqUk1MRnM4L1ozNW03OVNlZTlxNjRXc3py?= =?utf-8?B?dHJQRUtjVmUvbVFPY2RrbExvamZsVzhkeGVkemFQbVBGT1BmSTJZdG9XNTNG?= =?utf-8?B?S3pVVVB4cks0QlFsaHFqcGJzcWFLbFRETjlkem1LM1Z2eG5XSkZFM0VKSHFJ?= =?utf-8?B?LzFFcHh3RUttUm9iOEdNRU91b3FMTVUyeWRYT2tIQXVJK0I4VWIxN0ptRTZw?= =?utf-8?B?RzcwWnhOb01VY2dia2Jpc0gzNWpYUkJXMGcwZWlBSmR2SmpRQmJYYUlCUWhl?= =?utf-8?B?Y05tZWRFaVd1a0liZTdwdzQvVkdtOERxdnNMUkY4R1E2VDdKdWlvZU5lRzNQ?= =?utf-8?B?Skk2c2VhbU1XeGRPWVhEVDBlMmVkRThTcTdOTmVyb0IrTnYvOFJhb0owQk1j?= =?utf-8?B?THNZWXJ6cHNBS2h5TGdPeDFVQmRRQm84OWYyNTlKelMvdVB4VHVSeXRQR25v?= =?utf-8?B?WkJlWnN2TlZEWWZhYmVZZDhxWG96c0FvK2M5YjV6YzRrdHpGWXdCdWJZRzRS?= =?utf-8?B?R1loQmpTc2M1cVUwWVBmdkRlZGJQYnZXRXpXOXBJSTFHWnlXVkd5eXN5dHR2?= =?utf-8?B?UmxoejhPZFprVHlvbUtKeUxqMnU3d0QwdEFvWDh5ZmtWcVFMS3lmVzNhUzhC?= =?utf-8?B?YVc5MTJNWmxGS1NOSDE5Y2U3d0pEby9obzdUcnh2Zm9mZTA5OXhGZTZSb24v?= =?utf-8?B?UUViNHFJbWxZY0c4bXozOWEwUWc2a2ozOE55VytDWlhTOVpWN1d5R21TejZY?= =?utf-8?B?c01pRSsyL2xRSXVTVHk4M2lTbC9TcHVVWkhiUytKMTJVWmhmL05mbGthazRH?= =?utf-8?B?dXpJRkZ6RWZURnJRbVhPcTcxUjE1M1I2VXc2djlXTlJpbVhmemZMWnRFS2VP?= =?utf-8?B?NTVVOGJ5T3d5Y0U0M1k0b2VsSXFGNDVudk56RjVURVlrWFRQYzdlUkFXdnA0?= =?utf-8?B?dDRzT2ZsQTZPR1NWZHFLd3ZZVlliQzB6bVQwZnA3eFJWNDdRaXlYWDYwRGxK?= =?utf-8?B?dVpFOEtZTkhSRU9vZW1jdHJHNW5BRzVzZStUMW1iTnhpdXpvK3JZZi9zN2V2?= =?utf-8?B?QlAwcnZyNGNRK2x2WGxJdXpHdG9JczNRbWxrRzFsYW9rdUFqQzN0U1UyazNX?= =?utf-8?B?UWdYUzVEMnczRG1mVkVneGZVVHZvUzJmdEFsVTVGSm9rNWRuSEFWZGtUelVS?= =?utf-8?B?eXhtdlVGb2Zoa1pqamZFZEg4Vlc4TGJnWml3UUdKQUVJR3ZYV3hqc1VFd1M2?= =?utf-8?Q?bVtMFUjoXAect+dtC/c4Nef6I?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ba602fd-b78d-41c8-7290-08db63789bf3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 14:49:46.9793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ek2QQ2rtYiqqQGDtMNRehG3zaZBXte8buErc6Lub6SZKlaQ+Yykf7UY+hKFsef7v X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8877 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/2023 5:32 PM, Rushil Gupta wrote: > Thanks for the quick response! > Just for my own knowledge, what Junfeng described is the process to > fix the bug if a bug is present in the main dpdk repo? > Correct. As main dpdk repo doesn't rewrite git history, any bug there needs to be fixed with an incremental commit, and fix commit should have some metadata to describe what it is fixing (this is to help LTS maintainers and developers tracing down a change). But sub-trees (like next-net) allowed to rewrite git history, so allowed to squash/rebase commits when it is more practical to do so as this case. But changing directly in the git repo has its problems, like tracing, justifying source of the change and missing consensus etc. So, even it is squashed, the patch should be publicly available in the mail list first. For developers it is best to send incremental patch as if it will be merged as incremental commit, but can request a squash if the commit still not pulled by main repo, or maintainer can prefer to squash the fix to original commit, to reduce the churn & process overhead. > On Thu, Jun 1, 2023 at 3:24 AM Ferruh Yigit wrote: >> >> On 6/1/2023 9:26 AM, Ferruh Yigit wrote: >>> On 6/1/2023 5:49 AM, Rushil Gupta wrote: >>>> gVNIC requires physical address to be passed in the adminq command. >>>> This was initially rightly pointed by ferruh.yigit@. >>>> Fixed by passing 'driver_info_mem->iova'. >>>> >>>> Signed-off-by: Rushil Gupta >>>> --- >>>> drivers/net/gve/gve_ethdev.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c >>>> index 2c1e73d07a..aa75abe102 100644 >>>> --- a/drivers/net/gve/gve_ethdev.c >>>> +++ b/drivers/net/gve/gve_ethdev.c >>>> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv) >>>> (char *)driver_info->os_version_str2); >>>> >>>> err = gve_adminq_verify_driver_compatibility(priv, >>>> - sizeof(struct gve_driver_info), (dma_addr_t)driver_info); >>>> + sizeof(struct gve_driver_info), >>>> + (dma_addr_t)driver_info_mem->iova); >>>> >>> >>> Yep, this was my point, let me squashed onto original patch in next-net. >>> >>> >> >> Squashed into relevant commit in next-net, thanks. >> Can you please verify latest code in next-net?