From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id E389D4C8F for ; Wed, 1 May 2019 12:10:55 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id p21so6696176wmc.0 for ; Wed, 01 May 2019 03:10:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xbX6AQIlDqbyXFCQP3cKzwG2+LDL886GyOiPIKxUXQQ=; b=FqZsd3JGQPI+Q8H1rWg6ABg8okWQxQfD9Ea22YTU8MZVIHniki9ObUHgTkPGRETC05 35DKHx09XSgCGLoMMMgrz5aw4QSHG2puSr3M4djOsoOYPy69CUKN+n2pubyx6sAxPGwU ehOWqUVpQCO7SH/9r+4YiusKEG6ciG2oFBn6prgiasAOEXN6elGRYBjRhBPD3d3U7J0x nIDD4fIe7Gi+ABcEXCr2miRJwEGdWxgpulBBA+Sykj5MbhQTbs46MOkAKOfsK2/rFlTF mA/h5gwKiQSzG+GGSH6v5J50Rm4JERnIJ+aENX7STxUA0woDumJGE35VIuJPeqK1zKN0 bgVA== X-Gm-Message-State: APjAAAUmJZi0/Ut9IvimE8cc9e3WQo+9WnWnVtmD30pOtRmT2qkQE9Ra q195h1YDIhE/UIW3wHLlabWrvjcL48M= X-Google-Smtp-Source: APXvYqwJYRnymhMv+FGaRccc24LfJdWM3hGdWMsvTTsLph2x6+EGwUqZ4LQnUG10pxXibCIlZUE76A== X-Received: by 2002:a7b:c04b:: with SMTP id u11mr5260987wmc.95.1556705455579; Wed, 01 May 2019 03:10:55 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id i8sm7639872wrb.5.2019.05.01.03.10.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2019 03:10:54 -0700 (PDT) Message-ID: <6fa578af08ec8639ad23608280a0b55f63dd306a.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net Date: Wed, 01 May 2019 11:10:54 +0100 In-Reply-To: <20190426165043.17268-7-bruce.richardson@intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190426165043.17268-1-bruce.richardson@intel.com> <20190426165043.17268-7-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 10:10:56 -0000 On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > The examples/meson.build file scanned the filesystem to find all > examples > to build (for examples=3Dall option) and install. However, using > run_command > and scanning the filesystem prevented ninja from properly detecting > the > addition or removal of any examples - one had to recreate the build > directory from scratch to guarantee correct detection of all > examples. This > patch replaces this generated list with a static list of examples, > thereby > allowing proper tracking by ninja/meson, but at the cost of having to > update this file when a new example is added or removed. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > examples/meson.build | 31 ++++++++++++++++++++++++++++--- > 1 file changed, 28 insertions(+), 3 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4DE16A0AC5 for ; Wed, 1 May 2019 12:10:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A9FD4CA7; Wed, 1 May 2019 12:10:57 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id E389D4C8F for ; Wed, 1 May 2019 12:10:55 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id p21so6696176wmc.0 for ; Wed, 01 May 2019 03:10:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xbX6AQIlDqbyXFCQP3cKzwG2+LDL886GyOiPIKxUXQQ=; b=FqZsd3JGQPI+Q8H1rWg6ABg8okWQxQfD9Ea22YTU8MZVIHniki9ObUHgTkPGRETC05 35DKHx09XSgCGLoMMMgrz5aw4QSHG2puSr3M4djOsoOYPy69CUKN+n2pubyx6sAxPGwU ehOWqUVpQCO7SH/9r+4YiusKEG6ciG2oFBn6prgiasAOEXN6elGRYBjRhBPD3d3U7J0x nIDD4fIe7Gi+ABcEXCr2miRJwEGdWxgpulBBA+Sykj5MbhQTbs46MOkAKOfsK2/rFlTF mA/h5gwKiQSzG+GGSH6v5J50Rm4JERnIJ+aENX7STxUA0woDumJGE35VIuJPeqK1zKN0 bgVA== X-Gm-Message-State: APjAAAUmJZi0/Ut9IvimE8cc9e3WQo+9WnWnVtmD30pOtRmT2qkQE9Ra q195h1YDIhE/UIW3wHLlabWrvjcL48M= X-Google-Smtp-Source: APXvYqwJYRnymhMv+FGaRccc24LfJdWM3hGdWMsvTTsLph2x6+EGwUqZ4LQnUG10pxXibCIlZUE76A== X-Received: by 2002:a7b:c04b:: with SMTP id u11mr5260987wmc.95.1556705455579; Wed, 01 May 2019 03:10:55 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id i8sm7639872wrb.5.2019.05.01.03.10.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2019 03:10:54 -0700 (PDT) Message-ID: <6fa578af08ec8639ad23608280a0b55f63dd306a.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net Date: Wed, 01 May 2019 11:10:54 +0100 In-Reply-To: <20190426165043.17268-7-bruce.richardson@intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190426165043.17268-1-bruce.richardson@intel.com> <20190426165043.17268-7-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190501101054.4Eoz9E2faPAR_9DIJVbJf_RMTkVv2_MuGWGxEkMOrUE@z> On Fri, 2019-04-26 at 17:50 +0100, Bruce Richardson wrote: > The examples/meson.build file scanned the filesystem to find all > examples > to build (for examples=3Dall option) and install. However, using > run_command > and scanning the filesystem prevented ninja from properly detecting > the > addition or removal of any examples - one had to recreate the build > directory from scratch to guarantee correct detection of all > examples. This > patch replaces this generated list with a static list of examples, > thereby > allowing proper tracking by ninja/meson, but at the cost of having to > update this file when a new example is added or removed. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > examples/meson.build | 31 ++++++++++++++++++++++++++++--- > 1 file changed, 28 insertions(+), 3 deletions(-) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi