From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1946AA0C4B; Sun, 12 Sep 2021 14:35:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 888A340041; Sun, 12 Sep 2021 14:35:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A8C434003D for ; Sun, 12 Sep 2021 14:35:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631450120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b0dSzen8xJa7xmpT61vatBGLHbxqGrK4W7mCdtzGqj0=; b=HvxvsZtGCvjF4V6bMW30tV+WSn/Q/k1EAZ4X9P9QUfGXbCYela+lqdBlWtBLKt7Sqhwkq9 HpBhyxD7U2+94wBuoY6HZfoFEA8hun+xtoMSOXvfhZddnL5u/IGoo+m2br5TPj7KMpL95P 71GXHaW2TbIG/r4U32ys5Q39G4At21k= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-R3QcCq6RPzK2uiGf-jIZ_Q-1; Sun, 12 Sep 2021 08:35:19 -0400 X-MC-Unique: R3QcCq6RPzK2uiGf-jIZ_Q-1 Received: by mail-qk1-f200.google.com with SMTP id o4-20020ae9f504000000b003d39d97b227so38775053qkg.2 for ; Sun, 12 Sep 2021 05:35:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=b0dSzen8xJa7xmpT61vatBGLHbxqGrK4W7mCdtzGqj0=; b=SYiuh5v9lZ2xNtRG0m0pC81DM0bYS1Q8Ldh+49rEP90PTULFrRI47l0uW2iFNNuwcr hv6KrQxeeJEhivDj+zAFlCeFVrAVxN2CPcD3aqJoHrFo3s/V+nJz5Sx6b6AMnPTY50Vy Rfk/YJm6MqMEMvxydlRzq4PphuLdEfBeF7fm3K8+1H2oE1yKDdS9w0m4rNBKbVX6eWlW OHH80A9k2NW9s0AEfVFF8VXqBIJO5BqXoIOnLg01zseqaUPbXZ0KFC2wTZ3oqxWZbdJp Q+mqcNLHV4WloN5CyL0rLw1QzcAiA2x7klQ0T3GY0sjkU+TpBkSoLPOUBXM6px/O7bqo Bgrw== X-Gm-Message-State: AOAM530lAwQfii24AR9X1uqdJhGXVUiKjVULCIx/df/wTBJbxffR6rcq XIcF38Dszz9MDWfZlKN2B1vAWrTtNp86gLN23R7NNgNc9Uub3eK1P6fw2PVAoc0qqxQVPC4p9E2 rVSo= X-Received: by 2002:a05:620a:1651:: with SMTP id c17mr5576061qko.170.1631450119226; Sun, 12 Sep 2021 05:35:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAVwRxMGGAN7EG3PYlK686tA/Z+g4bCshgqzsK7NcFZdMg9C577m6vLA/YB8GFsXg6KIXENQ== X-Received: by 2002:a05:620a:1651:: with SMTP id c17mr5576044qko.170.1631450118974; Sun, 12 Sep 2021 05:35:18 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id m5sm3111163qkn.33.2021.09.12.05.35.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 05:35:18 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, arun.joshi@intel.com References: <1631063741-28631-1-git-send-email-nicolas.chautru@intel.com> <1631063741-28631-2-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <6fa9cc35-5b00-9343-7929-7e1e64425fc0@redhat.com> Date: Sun, 12 Sep 2021 05:35:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1631063741-28631-2-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 1/6] bbdev: add capability for CRC16 check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/7/21 6:15 PM, Nicolas Chautru wrote: > Adding a missing operation when CRC16 > is being used for TB CRC check. > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_vector.c | 2 ++ > doc/guides/prog_guide/bbdev.rst | 3 +++ > doc/guides/rel_notes/release_21_11.rst | 1 + > lib/bbdev/rte_bbdev_op.h | 34 ++++++++++++++++++---------------- > 4 files changed, 24 insertions(+), 16 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c > index 614dbd1..8d796b1 100644 > --- a/app/test-bbdev/test_bbdev_vector.c > +++ b/app/test-bbdev/test_bbdev_vector.c > @@ -167,6 +167,8 @@ > *op_flag_value = RTE_BBDEV_LDPC_CRC_TYPE_24B_CHECK; > else if (!strcmp(token, "RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP")) > *op_flag_value = RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP; > + else if (!strcmp(token, "RTE_BBDEV_LDPC_CRC_TYPE_16_CHECK")) > + *op_flag_value = RTE_BBDEV_LDPC_CRC_TYPE_16_CHECK; > else if (!strcmp(token, "RTE_BBDEV_LDPC_DEINTERLEAVER_BYPASS")) > *op_flag_value = RTE_BBDEV_LDPC_DEINTERLEAVER_BYPASS; > else if (!strcmp(token, "RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE")) > diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst > index 9619280..8bd7cba 100644 > --- a/doc/guides/prog_guide/bbdev.rst > +++ b/doc/guides/prog_guide/bbdev.rst > @@ -891,6 +891,9 @@ given below. > |RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP | > | Set to drop the last CRC bits decoding output | > +--------------------------------------------------------------------+ > +|RTE_BBDEV_LDPC_CRC_TYPE_16_CHECK | > +| Set for code block CRC-16 checking | > ++--------------------------------------------------------------------+ > |RTE_BBDEV_LDPC_DEINTERLEAVER_BYPASS | > | Set for bit-level de-interleaver bypass on input stream | > +--------------------------------------------------------------------+ > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index d707a55..69dd518 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -84,6 +84,7 @@ API Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* bbdev: Added capability related to more comprehensive CRC options. > > ABI Changes > ----------- > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h > index f946842..7c44ddd 100644 > --- a/lib/bbdev/rte_bbdev_op.h > +++ b/lib/bbdev/rte_bbdev_op.h > @@ -142,51 +142,53 @@ enum rte_bbdev_op_ldpcdec_flag_bitmasks { > RTE_BBDEV_LDPC_CRC_TYPE_24B_CHECK = (1ULL << 1), > /** Set to drop the last CRC bits decoding output */ > RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP = (1ULL << 2), > + /** Set for transport block CRC-16 checking */ > + RTE_BBDEV_LDPC_CRC_TYPE_16_CHECK = (1ULL << 3), > /** Set for bit-level de-interleaver bypass on Rx stream. */ > - RTE_BBDEV_LDPC_DEINTERLEAVER_BYPASS = (1ULL << 3), > + RTE_BBDEV_LDPC_DEINTERLEAVER_BYPASS = (1ULL << 4), > /** Set for HARQ combined input stream enable. */ > - RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE = (1ULL << 4), > + RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE = (1ULL << 5), > /** Set for HARQ combined output stream enable. */ > - RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE = (1ULL << 5), > + RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE = (1ULL << 6), > /** Set for LDPC decoder bypass. > * RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE must be set. > */ > - RTE_BBDEV_LDPC_DECODE_BYPASS = (1ULL << 6), > + RTE_BBDEV_LDPC_DECODE_BYPASS = (1ULL << 7), > /** Set for soft-output stream enable */ > - RTE_BBDEV_LDPC_SOFT_OUT_ENABLE = (1ULL << 7), > + RTE_BBDEV_LDPC_SOFT_OUT_ENABLE = (1ULL << 8), > /** Set for Rate-Matching bypass on soft-out stream. */ > - RTE_BBDEV_LDPC_SOFT_OUT_RM_BYPASS = (1ULL << 8), > + RTE_BBDEV_LDPC_SOFT_OUT_RM_BYPASS = (1ULL << 9), > /** Set for bit-level de-interleaver bypass on soft-output stream. */ > - RTE_BBDEV_LDPC_SOFT_OUT_DEINTERLEAVER_BYPASS = (1ULL << 9), > + RTE_BBDEV_LDPC_SOFT_OUT_DEINTERLEAVER_BYPASS = (1ULL << 10), > /** Set for iteration stopping on successful decode condition > * i.e. a successful syndrome check. > */ > - RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE = (1ULL << 10), > + RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE = (1ULL << 11), > /** Set if a device supports decoder dequeue interrupts. */ > - RTE_BBDEV_LDPC_DEC_INTERRUPTS = (1ULL << 11), > + RTE_BBDEV_LDPC_DEC_INTERRUPTS = (1ULL << 12), > /** Set if a device supports scatter-gather functionality. */ > - RTE_BBDEV_LDPC_DEC_SCATTER_GATHER = (1ULL << 12), > + RTE_BBDEV_LDPC_DEC_SCATTER_GATHER = (1ULL << 13), > /** Set if a device supports input/output HARQ compression. */ > - RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION = (1ULL << 13), > + RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION = (1ULL << 14), > /** Set if a device supports input LLR compression. */ > - RTE_BBDEV_LDPC_LLR_COMPRESSION = (1ULL << 14), > + RTE_BBDEV_LDPC_LLR_COMPRESSION = (1ULL << 15), > /** Set if a device supports HARQ input from > * device's internal memory. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_IN_ENABLE = (1ULL << 15), > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_IN_ENABLE = (1ULL << 16), > /** Set if a device supports HARQ output to > * device's internal memory. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE = (1ULL << 16), > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE = (1ULL << 17), > /** Set if a device supports loop-back access to > * HARQ internal memory. Intended for troubleshooting. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 17), > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 18), > /** Set if a device includes LLR filler bits in the circular buffer > * for HARQ memory. If not set, it is assumed the filler bits are not > * in HARQ memory and handled directly by the LDPC decoder. > */ > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS = (1ULL << 18) > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS = (1ULL << 19) The fiddling in the middle is fine since bbdev api is experimental Look good. Reviewed-by: Tom Rix > }; > > /** Flags for LDPC encoder operation and capability structure */