From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Matan Azrad <matan@mellanox.com>, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v1 3/3] drivers: move ifc driver to the vDPA class
Date: Tue, 7 Jan 2020 19:17:09 +0100 [thread overview]
Message-ID: <6fb34ab3-dc1d-e655-8a2e-d7af58a66b94@redhat.com> (raw)
In-Reply-To: <1577287161-10321-4-git-send-email-matan@mellanox.com>
On 12/25/19 4:19 PM, Matan Azrad wrote:
> A new vDPA class was recently introduced.
>
> IFC driver implements the vDPA operations, hence it should be moved to
> the vDPA class.
>
> Move it.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
> MAINTAINERS | 6 +-
> doc/guides/nics/features/ifcvf.ini | 8 -
> doc/guides/nics/ifc.rst | 106 ---
> doc/guides/nics/index.rst | 1 -
> doc/guides/vdpadevs/features/ifcvf.ini | 8 +
> doc/guides/vdpadevs/ifc.rst | 106 +++
> doc/guides/vdpadevs/index.rst | 1 +
> drivers/net/Makefile | 3 -
> drivers/net/ifc/Makefile | 34 -
> drivers/net/ifc/base/ifcvf.c | 329 --------
> drivers/net/ifc/base/ifcvf.h | 162 ----
> drivers/net/ifc/base/ifcvf_osdep.h | 52 --
> drivers/net/ifc/ifcvf_vdpa.c | 1280 ------------------------------
> drivers/net/ifc/meson.build | 9 -
> drivers/net/ifc/rte_pmd_ifc_version.map | 3 -
> drivers/net/meson.build | 1 -
> drivers/vdpa/Makefile | 6 +
> drivers/vdpa/ifc/Makefile | 34 +
> drivers/vdpa/ifc/base/ifcvf.c | 329 ++++++++
> drivers/vdpa/ifc/base/ifcvf.h | 162 ++++
> drivers/vdpa/ifc/base/ifcvf_osdep.h | 52 ++
> drivers/vdpa/ifc/ifcvf_vdpa.c | 1280 ++++++++++++++++++++++++++++++
> drivers/vdpa/ifc/meson.build | 9 +
> drivers/vdpa/ifc/rte_pmd_ifc_version.map | 3 +
> drivers/vdpa/meson.build | 2 +-
> 25 files changed, 1994 insertions(+), 1992 deletions(-)
> delete mode 100644 doc/guides/nics/features/ifcvf.ini
> delete mode 100644 doc/guides/nics/ifc.rst
> create mode 100644 doc/guides/vdpadevs/features/ifcvf.ini
> create mode 100644 doc/guides/vdpadevs/ifc.rst
> delete mode 100644 drivers/net/ifc/Makefile
> delete mode 100644 drivers/net/ifc/base/ifcvf.c
> delete mode 100644 drivers/net/ifc/base/ifcvf.h
> delete mode 100644 drivers/net/ifc/base/ifcvf_osdep.h
> delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c
> delete mode 100644 drivers/net/ifc/meson.build
> delete mode 100644 drivers/net/ifc/rte_pmd_ifc_version.map
> create mode 100644 drivers/vdpa/ifc/Makefile
> create mode 100644 drivers/vdpa/ifc/base/ifcvf.c
> create mode 100644 drivers/vdpa/ifc/base/ifcvf.h
> create mode 100644 drivers/vdpa/ifc/base/ifcvf_osdep.h
> create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c
> create mode 100644 drivers/vdpa/ifc/meson.build
> create mode 100644 drivers/vdpa/ifc/rte_pmd_ifc_version.map
>
...
> diff --git a/doc/guides/vdpadevs/features/ifcvf.ini b/doc/guides/vdpadevs/features/ifcvf.ini
> new file mode 100644
> index 0000000..ef1fc47
> --- /dev/null
> +++ b/doc/guides/vdpadevs/features/ifcvf.ini
> @@ -0,0 +1,8 @@
> +;
> +; Supported features of the 'ifcvf' vDPA driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +x86-32 = Y
> +x86-64 = Y
Xiao or someone knowing the IFC enough would need to file the feature
list in a separate patch.
Other than that:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-01-07 18:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 15:19 [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Matan Azrad
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 1/3] drivers: introduce vDPA class Matan Azrad
2020-01-07 17:32 ` Maxime Coquelin
2020-01-08 21:28 ` Thomas Monjalon
2020-01-09 8:00 ` Maxime Coquelin
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 2/3] doc: add vDPA feature table Matan Azrad
2020-01-07 17:39 ` Maxime Coquelin
2020-01-08 5:28 ` Tiwei Bie
2020-01-08 7:20 ` Andrew Rybchenko
2020-01-08 10:42 ` Matan Azrad
2020-01-08 13:11 ` Andrew Rybchenko
2020-01-08 17:01 ` Matan Azrad
2020-01-09 2:15 ` Tiwei Bie
2020-01-09 8:08 ` Matan Azrad
2019-12-25 15:19 ` [dpdk-dev] [PATCH v1 3/3] drivers: move ifc driver to the vDPA class Matan Azrad
2020-01-07 18:17 ` Maxime Coquelin [this message]
2020-01-07 7:57 ` [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers Matan Azrad
2020-01-08 5:44 ` Xu, Rosen
2020-01-08 10:45 ` Matan Azrad
2020-01-08 12:39 ` Xu, Rosen
2020-01-08 12:58 ` Thomas Monjalon
2020-01-09 2:27 ` Xu, Rosen
2020-01-09 8:41 ` Thomas Monjalon
2020-01-09 9:23 ` Maxime Coquelin
2020-01-09 9:49 ` Xu, Rosen
2020-01-09 10:42 ` Maxime Coquelin
2020-01-10 2:40 ` Xu, Rosen
2020-01-09 10:42 ` Maxime Coquelin
2020-01-09 10:53 ` Xu, Rosen
2020-01-09 11:34 ` Matan Azrad
2020-01-10 2:38 ` Xu, Rosen
2020-01-10 9:21 ` Thomas Monjalon
2020-01-10 14:18 ` Xu, Rosen
2020-01-10 16:27 ` Thomas Monjalon
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 " Matan Azrad
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 1/3] drivers: introduce vDPA class Matan Azrad
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table Matan Azrad
2020-01-10 18:26 ` Thomas Monjalon
2020-01-13 22:40 ` Thomas Monjalon
2020-01-09 11:00 ` [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class Matan Azrad
2020-01-09 17:25 ` Matan Azrad
2020-01-10 1:55 ` Wang, Haiyue
2020-01-10 9:07 ` Matan Azrad
2020-01-10 9:13 ` Thomas Monjalon
2020-01-10 12:31 ` Wang, Haiyue
2020-01-10 12:34 ` Maxime Coquelin
2020-01-10 12:59 ` Thomas Monjalon
2020-01-10 19:17 ` Kevin Traynor
2020-01-13 22:57 ` Thomas Monjalon
2020-01-13 23:08 ` [dpdk-dev] [PATCH v2 0/3] Introduce new class for vDPA device drivers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb34ab3-dc1d-e655-8a2e-d7af58a66b94@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).