From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6855AA0561; Wed, 17 Mar 2021 20:23:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 210A3140F31; Wed, 17 Mar 2021 20:23:43 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 7D1CE140F2B for ; Wed, 17 Mar 2021 20:23:41 +0100 (CET) IronPort-SDR: OGGZH3CANZkcLh8LQ674BMK+zXS00LqLr9G/RyHxbEr9lJSX1Hs13jt7jrn3JW7pcDlpprL8PW gtrQi8mTvuGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="186175184" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="186175184" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 12:23:40 -0700 IronPort-SDR: IifADVBQOymKTwnk0wsL5v/CC4TSFfkJ0ulT7h0Wu7w6sxBviBc5zrfAiD9MMm076yXe4wGnBq dbsz4dOAjHvA== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="412775837" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 12:23:40 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Nick Connolly , Khoa To References: <20210221142819.6769-1-dmitry.kozliuk@gmail.com> <20210306000500.8698-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: <6fb61787-2a76-c11a-49cb-6af25f8b4c00@intel.com> Date: Wed, 17 Mar 2021 12:23:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210306000500.8698-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/5/2021 4:04 PM, Dmitry Kozlyuk wrote: > On Windows, rte_os.h contains a small POSIX compatibility set of > functions and macros. Exposing it from EAL can break consumer own POSIX > compatibility layer and is against standards in general. > Hide these symbols from external consumers, while keeping them available > for DPDK code. > > v4: > * Instead of creating wrappers and replacing POSIX names in lib/ and > drivers/, provide POSIX names only to internal consumers. > * Move renaming from librte_cmdline to librte_eal. > > Dmitry Kozlyuk (4): > eal: add sleep API > eal: add asprintf() internal wrapper > build: indicate usage at build time for public headers > eal/windows: do not expose POSIX symbols > > config/meson.build | 3 + > doc/guides/rel_notes/release_21_05.rst | 3 + > lib/librte_cmdline/cmdline.c | 4 - > lib/librte_cmdline/cmdline_socket.c | 4 - > lib/librte_eal/common/eal_common_errno.c | 4 + > lib/librte_eal/common/eal_common_lcore.c | 2 +- > lib/librte_eal/common/eal_common_options.c | 10 +- > lib/librte_eal/common/eal_common_timer.c | 5 +- > lib/librte_eal/common/eal_common_trace.c | 2 +- > lib/librte_eal/common/eal_common_trace_ctf.c | 2 +- > .../common/eal_common_trace_utils.c | 2 +- > lib/librte_eal/common/eal_private.h | 18 +++ > lib/librte_eal/include/rte_thread.h | 11 ++ > lib/librte_eal/rte_eal_exports.def | 2 + > lib/librte_eal/unix/rte_thread.c | 10 +- > lib/librte_eal/version.map | 3 + > lib/librte_eal/windows/eal.c | 30 +++++ > lib/librte_eal/windows/eal_thread.c | 9 +- > lib/librte_eal/windows/include/rte_os.h | 103 ++++-------------- > 19 files changed, 122 insertions(+), 105 deletions(-) > Sorry, ack-ed the v1 of this patch series by mistake. This is the real ACK! Acked-by: Ranjit Menon