From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BF95A0C4B; Sun, 12 Sep 2021 14:39:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75A4640041; Sun, 12 Sep 2021 14:39:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 823204003D for ; Sun, 12 Sep 2021 14:39:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631450392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQfvwfS1NUW1946OL78y8MOQw61GpOmgl73m2buP2qk=; b=QLjC1sXxkoy4weA63v5UCkFalwYVCHnFkZrVwTTN6CaU9YMqudlSOANSCQU6EZU0CbDapv ORf3JXyXSGC923v9g8W2fqkGsVjucDaQC8Q1pyLolMeyKEO7laJSppPlwKq7DE5Csa4LKF WzEdxHfiMm4ctq9/XKvK+qo9RqZOhZQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-lVQkb9bKPxajEp4l5BeF8Q-1; Sun, 12 Sep 2021 08:39:51 -0400 X-MC-Unique: lVQkb9bKPxajEp4l5BeF8Q-1 Received: by mail-qk1-f197.google.com with SMTP id c27-20020a05620a165b00b003d3817c7c23so38784065qko.16 for ; Sun, 12 Sep 2021 05:39:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=pQfvwfS1NUW1946OL78y8MOQw61GpOmgl73m2buP2qk=; b=uuEhFESIeURvWNQBSSEyI7zQEVvUWZXXy8i6D38rXVbvzfx/mbI3pvx5AtV+jmqRef S5+brCuFDYNTPaC3SbBY/jnlC70xhat0uz18sF7iks9NamKhp3stI+4H/i73Vz7nEIXL fderEJdbIjTHJNCnHInSH6AohsRO/LgkTyxiYqDyN4WJOxl1Loib6xTnYJiUbYgVvjTm PKCrrIWs19pfVKxbwVNCnPgEg57W+blIlKgexUaELHsran0l7DQA7pnZVUNMTekk5jF8 S6oA29Yh80h05s3/aiPgyHn8HSjuOp6FftItahnUPZZEixjU4XCm/b40eBiTdKCtn6WL 07Eg== X-Gm-Message-State: AOAM532uDWFe7MgW75TvzRPQywP0D6Gvm6KKD/qO4TEkwARIpOyG0KX5 4QpPcPfBThPqGZWJmRnoUrak1KXripmUujIHTX8pc1mhzPfYbg2F6k2Gs3hvNsJaQ2lIL4JvvIF bkaU= X-Received: by 2002:ac8:187:: with SMTP id x7mr5471093qtf.231.1631450391081; Sun, 12 Sep 2021 05:39:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjiYJe8mQ4rqKVjjjNKzNszBkCkoKCFatZD/5Y9CSCf5TZiJjEUBv3mzviFaTAlW7BaJMM8w== X-Received: by 2002:ac8:187:: with SMTP id x7mr5471085qtf.231.1631450390921; Sun, 12 Sep 2021 05:39:50 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o7sm2445440qtw.87.2021.09.12.05.39.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Sep 2021 05:39:50 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, arun.joshi@intel.com References: <1631063741-28631-1-git-send-email-nicolas.chautru@intel.com> <1631063741-28631-4-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <6fbc24fb-2174-e286-76a7-15ad3a22715d@redhat.com> Date: Sun, 12 Sep 2021 05:39:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1631063741-28631-4-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3 3/6] bbdev: add capability for 4G CB CRC DROP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/7/21 6:15 PM, Nicolas Chautru wrote: > Adding option to drop CRC24B to align with existing > feature for 5G > > Signed-off-by: Nicolas Chautru > --- > app/test-bbdev/test_bbdev_vector.c | 2 ++ > lib/bbdev/rte_bbdev_op.h | 5 ++++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c > index 8d796b1..f020836 100644 > --- a/app/test-bbdev/test_bbdev_vector.c > +++ b/app/test-bbdev/test_bbdev_vector.c > @@ -149,6 +149,8 @@ > *op_flag_value = RTE_BBDEV_TURBO_DEC_SCATTER_GATHER; > else if (!strcmp(token, "RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP")) > *op_flag_value = RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP; > + else if (!strcmp(token, "RTE_BBDEV_TURBO_DEC_CRC_24B_DROP")) > + *op_flag_value = RTE_BBDEV_TURBO_DEC_CRC_24B_DROP; > else { > printf("The given value is not a turbo decoder flag\n"); > return -1; > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h > index 7c44ddd..5512859 100644 > --- a/lib/bbdev/rte_bbdev_op.h > +++ b/lib/bbdev/rte_bbdev_op.h > @@ -114,7 +114,10 @@ enum rte_bbdev_op_td_flag_bitmasks { > /** Set to keep CRC24B bits appended while decoding. Only usable when > * decoding Transport Block mode. > */ > - RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP = (1ULL << 16) > + RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP = (1ULL << 16), > + /** Set to drop CRC24B bits not to be appended while decoding. > + */ > + RTE_BBDEV_TURBO_DEC_CRC_24B_DROP = (1ULL << 17) > }; > > This is ok, thanks. Reviewed-by: Tom Rix