From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AB49A0561; Fri, 5 Mar 2021 07:13:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E83BE22A2E5; Fri, 5 Mar 2021 07:13:33 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 954D040147 for ; Fri, 5 Mar 2021 07:13:32 +0100 (CET) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DsHRr6dV8zlT43; Fri, 5 Mar 2021 14:11:20 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Mar 2021 14:13:27 +0800 To: "Li, Xiaoyun" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" References: <1614905757-33791-1-git-send-email-oulijun@huawei.com> <1614905757-33791-4-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: <6fbe98ac-38b4-b4f6-dd25-642dea6a270d@huawei.com> Date: Fri, 5 Mar 2021 14:13:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/3/5 11:25, Li, Xiaoyun дµÀ: > Hi > >> -----Original Message----- >> From: dev On Behalf Of Lijun Ou >> Sent: Friday, March 5, 2021 08:56 >> To: Yigit, Ferruh >> Cc: dev@dpdk.org; linuxarm@openeuler.org >> Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in >> testpmd >> >> From: Hongbo Zheng >> >> In testpmd, when we input "show config rxtx", we can see like this: >> >> 1: testpmd> show config rxtx >> 2: io packet forwarding packets/burst=32 >> 3: nb forwarding cores=1 - nb forwarding ports=1 >> 4: port 0: RX queue number: 1 Tx queue number: 1 >> 5: Rx offloads=0x0 Tx offloads=0x10000 >> 6: RX queue: 0 >> 7: RX desc=1024 - RX free threshold=32 >> 8: RX threshold registers: pthresh=0 hthresh=0 wthresh=0 >> 9: RX Offloads=0x0 >> 10: TX queue: 0 >> 11: TX desc=1024 - TX free threshold=928 >> 12: TX threshold registers: pthresh=0 hthresh=0 wthresh=0 >> 13: TX offloads=0x10000 - TX RS bit threshold=32 >> >> In line 4, RX/Tx is mixed used. Also in other lines, RX/Rx/TX/Tx is mixed used. > > If you're going to unify the print to only use "Rx/Tx" in testpmd as your title said. > There're a lot of more places using RX/TX when printing. You should change them too. > OK£¬ I will do it. >> >> This patch fix the mixed use of RX/Rx/TX/Tx in testpmd command "show config >> rxtx" output by change to unified use Rx/Tx. >> >> Signed-off-by: Hongbo Zheng >> Signed-off-by: Lijun Ou >> --- >> app/test-pmd/config.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >> 576d5ac..2435c26 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -2505,7 +2505,7 @@ rxtx_config_display(void) >> int32_t rc; >> >> /* per port config */ >> - printf(" port %d: RX queue number: %d Tx queue >> number: %d\n", >> + printf(" port %d: Rx queue number: %d Tx queue number: %d\n", >> (unsigned int)pid, nb_rxq, nb_txq); >> >> printf(" Rx offloads=0x%"PRIx64" Tx offloads=0x%"PRIx64"\n", >> @@ -2533,13 +2533,13 @@ rxtx_config_display(void) >> offloads_tmp = rx_qinfo.conf.offloads; >> } >> >> - printf(" RX queue: %d\n", qid); >> - printf(" RX desc=%d - RX free threshold=%d\n", >> + printf(" Rx queue: %d\n", qid); >> + printf(" Rx desc=%d - Rx free threshold=%d\n", >> nb_rx_desc_tmp, rx_free_thresh_tmp); >> - printf(" RX threshold registers: pthresh=%d >> hthresh=%d " >> + printf(" Rx threshold registers: pthresh=%d >> hthresh=%d " >> " wthresh=%d\n", >> pthresh_tmp, hthresh_tmp, wthresh_tmp); >> - printf(" RX Offloads=0x%"PRIx64"\n", offloads_tmp); >> + printf(" Rx Offloads=0x%"PRIx64"\n", offloads_tmp); >> } >> >> /* per tx queue config only for first queue to be less verbose */ >> @@ -2565,13 +2565,13 @@ rxtx_config_display(void) >> tx_rs_thresh_tmp = tx_qinfo.conf.tx_rs_thresh; >> } >> >> - printf(" TX queue: %d\n", qid); >> - printf(" TX desc=%d - TX free threshold=%d\n", >> + printf(" Tx queue: %d\n", qid); >> + printf(" Tx desc=%d - Tx free threshold=%d\n", >> nb_tx_desc_tmp, tx_free_thresh_tmp); >> - printf(" TX threshold registers: pthresh=%d >> hthresh=%d " >> + printf(" Tx threshold registers: pthresh=%d >> hthresh=%d " >> " wthresh=%d\n", >> pthresh_tmp, hthresh_tmp, wthresh_tmp); >> - printf(" TX offloads=0x%"PRIx64" - TX RS bit >> threshold=%d\n", >> + printf(" Tx offloads=0x%"PRIx64" - Tx RS bit >> threshold=%d\n", >> offloads_tmp, tx_rs_thresh_tmp); >> } >> } >> -- >> 2.7.4 > > . >