From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DDED42E9D; Mon, 17 Jul 2023 17:03:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A79C40DFD; Mon, 17 Jul 2023 17:03:26 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2059.outbound.protection.outlook.com [40.107.102.59]) by mails.dpdk.org (Postfix) with ESMTP id 3E18140A80 for ; Mon, 17 Jul 2023 17:03:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vj9W+cfoGC31Qp9zkGbNpjGGqSrK5NiiW7Kqszf+yUt0JmNnuQTkfC789XKevvyToKMleDHR30qrBKahKwYcwcY4Txh0SsIdiLsIlJJLkyX2FOon98hgz1A5Pa/s09UcNJmWF41i/vbV+zRWJh7x9DMduspZMxhlNhTqZ3fsyQF3k+6NSOMnOTYBtna4I/5QGEUFMsw8kjnI9LlLaLuZcUi/RJFITVMofLgA8c/q+ILjRKAP0mZQxwa0JFMdlKzi8KzPHsKK8Rp3KGaOnpx8gbUU2fRdDMtAPKSdXu83oJ75T284KSHS1jz2xl+P/k2LWGd2nFUvtLXnFHJuWO0Fmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u+QfgcVX/0cPkXIBb+s056qQVg0Roayn4PI4NA3pBmg=; b=Df6lcLRiAz4AKcWmS/WGkOugeuA5n7pBFBL3RHNwdVKCdIdSJaK8+8ioVBDe2WM5ecncoxrRRoerN0HmB9XIcOB7cQmwtsW2Lf0wH2mjlbO84v3vGN036HsuUmLFehN2SGLKrsKglIkdtjMCFcAEt6FIzzwPKxbRTkQz4Z6Zo5zO3mki62mNpTPC/ARzVUcuDC2yEcxdRNt+HI7ADWObLNAMc/+NFRXc+j/SrrHwwroaQy+JaC8q57Zzfjdy6tKmmFJI1WyTbTQqzaLXwuTi58RpYiY9JrmwGRvBeoc4SLUulCcfYL3OJYmTPz7wwChC95xxfwvB9PgNaaxvt5FBsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u+QfgcVX/0cPkXIBb+s056qQVg0Roayn4PI4NA3pBmg=; b=XHr0BU355B+/97ViPZ5BEUu5ha04guH8cWdzjWz2GxrSncCyJJ2/4gYVDkAD8VqBsxQNAb3BGhjDxNBNIQfRAATkac7yHenTH+j3BCE04gNQH72XjDsbqZW6JqdylFZ11EnkL1SZDFgeP/6v5LtAVz5vXV8DKOhSE9bPuazVZNo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB6850.namprd12.prod.outlook.com (2603:10b6:303:1ed::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 15:03:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 15:03:22 +0000 Message-ID: <6fe13e60-ea19-6acc-5f97-25135f899c02@amd.com> Date: Mon, 17 Jul 2023 16:03:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] doc: announce bonding data change Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <20230714081526.1277786-1-chaoyong.he@corigine.com> <20230714081526.1277786-3-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230714081526.1277786-3-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0392.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB6850:EE_ X-MS-Office365-Filtering-Correlation-Id: 8675a2a7-8dfe-48d9-8d10-08db86d6f6a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i5zsJNhHd+zWNahkBhCgBFTKS+qGjmyA02C22XHn6GjuqVPXH+RTGsv6Gr1KYNhjzhE8P0hX1X8t7W+KYfG/hkwxxsAmHiH4STKw8WbXV101SWNBdK8CTeNZQTroJdVmbka3t3PLTDL2tXuDTPhWMbbnKAlwILDMmcL2eeRBbgeonDDZ8J3rFgWMarpdg9pFnJzTrCrZbUS/fey6CPre6B7oUouRsexJPHhdMpz5YnlfN2Xz2OF8l5paFCgy9jjyKZLeupE8H0CqmnKNJamhfEe91Za7uBb/5cwIkBj5tGB/j/BTtwHb9yGQPz/PwMuWLHhlHSFw2ZMvTqLqWZMBTOcEUtKwPZYASKYjGCPaB2JE7zsznUypSDcdoc0saI2HWua1dwIGSILgUZ3JLmL/GZXvpFCxlhIfEryP3EjO/QtZ6gQnFuNU+oySBhbLzDBbg0B4gwhYDL5Xx+7h8ABff6/qqVe6tYLvvySNWrAt3pCC4gnPKuHnpZbiYUmpqIGzfmmV7UJ/c+Ue8HLajCexaHYKm2cbgbeOlOVRCt3stDBM/udtpnyDDPrRLMRVIbwS3YvCGwG4NMl4oElXbaDKdGSQpqRgAucqTuMZ3MrWan6bzqQuWOXnWGNQi+lHiUe2iQ3W/17opm4jbAF6+XzkXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199021)(316002)(2616005)(26005)(186003)(6506007)(53546011)(66476007)(66556008)(66946007)(4326008)(44832011)(2906002)(5660300002)(41300700001)(8676002)(8936002)(6486002)(6512007)(6666004)(36756003)(478600001)(83380400001)(38100700002)(86362001)(31686004)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1B0czV0ODR0STF4eWM1T2pHNVB0Yks3eDZ2ZG5kQ1psaDd6aDg2UEhpV0t3?= =?utf-8?B?QjBKbmZNY1FpVFc3c3dBOTZYMzhiVCsvQ3h1ODU1K1RBbUZ5M1NOOU4xbmdh?= =?utf-8?B?MndjQmxmMkZEVlhCZHdLVmVkQ0t3a0tBSVZ5SDZlMWRHNmtadmd3YzNCRkd4?= =?utf-8?B?R0dLY25pZUgzTDFhbit5QlhsYUJwM1kzWE5vQkd1aUR4a2VmOGZSZmZSZGJW?= =?utf-8?B?RXhrNndHa2hnOWphcGp0S3VnMTdINnVmbHJlWk9PbnppbDZieDk1T2hWQjJI?= =?utf-8?B?OWJCYzVKT0lUQXFsU253OFEyRHZCQzJ5M1JKQU51QjV5a3U3bnFXVytMRE5U?= =?utf-8?B?UGUxQUprTlpPbVZHYjEwK0J3VSt2L3ZrU0lYZmFabUFybzgxallteUhiTFFM?= =?utf-8?B?cW5hWXdRTFFUZkhsNEVmelNpMlFQQ2N0UGlrQ2VZWmwvdDVjaDJNQ0toSFRC?= =?utf-8?B?MFYrOW9YNG02bkxRSFBrU0w1VFVYcXFBamRkRkdmbDMrZ2d4WmRLMDV1TjdT?= =?utf-8?B?bGdOTndUcmZqMmNJZkp3aVQrT2N1bjFuOXN3V3BFRTN3YVk0aUxqOVFlb2FE?= =?utf-8?B?Wk84NVVrYis2U01iazh1a2pJMnRrbVhvamhwQ1N1L0xSL0NTcG9VSXR2QmE4?= =?utf-8?B?eEd0bnFSQXhGbm51dXRadUkxaUwwVDUxa0gvQm1zWEFjSEJ4YmNPSUU5UVBy?= =?utf-8?B?dDJjYWl4dFRNczd1RGtYeFY5U3hlMGNwRXBkNXNXTUVxcUlyeE85ZGxjNjlr?= =?utf-8?B?V3d3SjdMQ1BMckdWbFB1NkxSeVM0WFFKckpVQ3N4dStZekpaNFBoUnBPeTBt?= =?utf-8?B?dnZwUGhhNm0yNzJTelAxeWVoV3lQRmZOUVpsUCtONDRIODN6VnZqMkxmeWM4?= =?utf-8?B?SzJFYTZucFVGdkx4MzlRV042S2hlSmZzTkxTMEx0K3BGdFdWdnd4ZkNRbFFx?= =?utf-8?B?RW51MmhCdXlzRTRWUFljVXVlZC9tZ2FMVEhTWlNic1lWY1NKR0tkNHNnUzV3?= =?utf-8?B?YndJa2VYV3ZNV3ZKMWhqbnk4aUxJT3JNdnB3Nk9LT0lRNU9MYVo5cTFKN3NG?= =?utf-8?B?VnBldjFWSlhPMXFob0xXMlRBRG9ET1Rsa3ROWGw2bExYRDV3STBjK0FicExp?= =?utf-8?B?TkMwNkQzNGlhUHVETXNick1TbFRsVjJwR1hkcm9qVGR5UXh0TGZQbW54YmpD?= =?utf-8?B?akJueWg3MEpkdW9HODR2KzdoeHBRTDBtbWVVT3ZzSVRRZDhhaERKeTQwVUEy?= =?utf-8?B?azU4eFVWTkRPd0NpRDdmQ25VLzJvUlRscUo5NUN1czZoU2kyU3VMdjdUdDhk?= =?utf-8?B?a0crN2p2Q1kwT01MMS84QVRxSFVJbUtEc05BZlBES3JjQUJOSWlDd1NKZFhM?= =?utf-8?B?akpoREFjV3JiaC90MTFCWEFZYUl6SlFjeUliT1pDVkE2c09KMFJXa3ZGUmcw?= =?utf-8?B?RnhLZ0w5NUpkWWpWcHpDNjduRS9vV3dqNm9KaFRRenBqKzQ5QVJMSmNhczRi?= =?utf-8?B?eXV1c1c4emhsdFREUkZqRHdQUERPdXJLVTg0SktZOHAvaE1yU29mOWNyWGdU?= =?utf-8?B?eWVFclVObEhvanU2dlNDK21JRUxTTUx2OFlMYXhZZkNKeURDNUNmQ3M4R2xx?= =?utf-8?B?Zis2alJmZFU5ekxQcm52SWd0RTQrRWxYb1dQZUVFcVc4d1BqeFYxUDZaODgw?= =?utf-8?B?RDZHTVkya2VVMzlKZVZONldGRUxYT3RobUFWbHBZcWhLZWNsWUpGQjhodjVP?= =?utf-8?B?M2xGaGtJZHA2OUVNK2tTNlFGaU9DckZHWDBOMHNvVklvM28xb3BTSE1DcW5a?= =?utf-8?B?SDRwVXpCSTNLc2U3d2p1TE5CdmNTNHVkZHFKUmt5dXVEV3ZSV2JOcjBSb2xy?= =?utf-8?B?TnJva3VKRm5PT2RyS21qN1ZTNGwxeTlJNVJOQ0xIVjZScFE1ZHpvK3V1ZEFa?= =?utf-8?B?VjJtbm03RU9ZbVdQeXhjQlFpbFVHa3QyTTQ0c0ppN3cwR1pkbnpmOFRKMHM1?= =?utf-8?B?NkFvRUIxbkswd2tka1NTd25JMEh3ZzFuNVVOY3NXckdjbG1rZWU1WkhzQ0VJ?= =?utf-8?B?aUV3am9nOXpzeGw4ZUMzSytjaDdYSy9YQk5RdnE1TjcvMk9YQ2RPdTVHUkk0?= =?utf-8?Q?axmUUglnnvqfY/0vdmTI1pe5R?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8675a2a7-8dfe-48d9-8d10-08db86d6f6a0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 15:03:22.3819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: huBTpnQx/BSVUd8K2PXMhRodL+uc/xkNJATTAt/UzsYisBcwCfz+7jCnpFK79t0Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6850 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/14/2023 9:15 AM, Chaoyong He wrote: > In order to support inclusive naming, the data structure of bonding 8023 > info need to be renamed. Do this through deprecation process now for > 23.07. > > Signed-off-by: Chaoyong He > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- > drivers/net/bonding/rte_eth_bond_8023ad.h | 4 ++-- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++-- > 4 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index c9477dd0da..5b16b66267 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -165,3 +165,6 @@ Deprecation Notices > * bonding: The macro ``RTE_ETH_DEV_BONDED_SLAVE`` will be deprecated in > DPDK 23.07, and removed in DPDK 23.11. The relevant code can be updated using > ``RTE_ETH_DEV_BONDING_MEMBER``. > + The data structure ``struct rte_eth_bond_8023ad_slave_info`` will be > + deprecated in DPDK 23.07, and removed in DPDK 23.11. The relevant code can be > + updated using ``struct rte_eth_bond_8023ad_member_info``. <...> > --- a/drivers/net/bonding/rte_eth_bond_8023ad.h > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.h > @@ -141,7 +141,7 @@ struct rte_eth_bond_8023ad_conf { > enum rte_bond_8023ad_agg_selection agg_selection; > }; > > -struct rte_eth_bond_8023ad_slave_info { > +struct rte_eth_bond_8023ad_member_info { > enum rte_bond_8023ad_selection selected; > uint8_t actor_state; > struct port_params actor; There is no good way to deprecate struct names. For macros it is possible to keep both old and new ones, old ones will give warning but still continue to work, so that is just a heads up for the user. But above is rename and will break the application, forcing user to update their code. And if we will force user to update their code, this should be done on ABI break release, v23.11. That is why I suggest just keep the deprecation notice update, saying that struct will be renamed in v23.11, without mentioning from deprecating struct in this release etc..