From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A59A9A0C43; Tue, 19 Oct 2021 13:56:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A878410FA; Tue, 19 Oct 2021 13:56:01 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 2E8CC410F4 for ; Tue, 19 Oct 2021 13:55:59 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="215412111" X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="215412111" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 04:55:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,384,1624345200"; d="scan'208";a="444461467" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 19 Oct 2021 04:55:58 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 04:55:57 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 04:55:57 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 04:55:57 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 04:55:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H300dZ8cWqbrV99SVSejh0k9o9cO3cP8Xc3HYufy7lSctv1OZy8Rf6KfSMMikHxLaI7RH9UyjPym3c34F248J0yoBfPisQX5C1dwBpp5m23I9uYu9djQqtVo64PHESOMbU7I7JckD+x2wu8KBws84jFKKgQSzzzunYs/aKDPkuvjFDpmVwzYkYcU5qEzvr3EKcWBqddcn5EpEPAVCtydKv7AUc2XDALDN3wORQNJLAvXczuDfIukHkhqEU1eaE+NgkgsiiSqDNv7f3yibjcYdbIo71X1zhBKYcKgtI4RDgxdeJowGQxybcFoiN7bdOJyyRBzeAw6/b5j64HMr88Fgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y38vJ4UstzJog7ydw3A5levkNCTMGMQ7Y9UDS1MCnJE=; b=ErfOPmf8PGwVBqhWE3/NoRh4rB0ZFSkrfJJQRRKXAykqChjBPgvMDDqUY5NiEzILh9eEANiPu4Y2bniXjZDeigIcV4rWOE+oCP9g/WDfFhHe5TYH3jqHbyGii+yd2YP2KB5VFzPRyXlmez2NLkgE77LYzwyTK9VpazSMhaK+X366DlqHebXHIvEdwuaBxXkoCeLEstROEX9nA58fuE8e9Pnr2W/t8yfMhgDnuJq1buRlX7+bItaifa1K3QiC9N3X3a5zEYWmw5LHCLw4gppgZ0yc87Uwv0xidF7XcVk44t4isZ5QcPnQkpfDmQaw1W7+uY/TXn/AdCTB6DkKg5mETw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y38vJ4UstzJog7ydw3A5levkNCTMGMQ7Y9UDS1MCnJE=; b=B4quGV5jmlHNBTtWiQEF/chH0iap+wewWeZeOfOImEwj2yoaQgI93yEtxNqa1uRu/M7hgZlkAUK485h8JysGqO5MT1IoJZjeggsxwcsgcjPuXQhjgo8zIGlB24+XiOvePGUuDwXFC+vmQQ7q5nNwUf+2JIPMpqZckXNY5VYHQs8= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 11:55:56 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 11:55:56 +0000 Message-ID: <6fede0ad-5858-9423-3e86-1170269d01b4@intel.com> Date: Tue, 19 Oct 2021 12:55:50 +0100 Content-Language: en-US To: Andrew Rybchenko CC: , Thomas Monjalon , Konstantin Ananyev References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0081.eurprd04.prod.outlook.com (2603:10a6:10:232::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0081.eurprd04.prod.outlook.com (2603:10a6:10:232::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 11:55:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41ee8ddb-2d51-4629-5f68-08d992f76896 X-MS-TrafficTypeDiagnostic: PH0PR11MB4790: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a9KpkcBNxs5hmSIWfFM9tC22ldKXbSz0Z38tcg9YHaSgkBl6IDsDsDYMjU3h9Wnr2k+s5ZtZunxGaXuHTs1m7xve/f1Zx7Groumth7W7Q/tPSfxE4/6M2U8W/02fnTeBn+ssFV882QdQMObrHzuwwzVYJkkjF3hJBhjdqhPoFynCHQD6xKGp4t0m6YTxZ4ykhmqOlmz2ISqg8fhFqwr+UehtHOxX74kMfIN5/qd9GIP270MGXNkWecNs8opBz53fN90typSBkfP7LQNSUr8W4q86IxsoiB9IBcPVpuKiwF/apxpH+zONs3Wq8ETs2J4Er7nJMtVC1oceYBNPag6ejHbp06ZadQ/3WGJnN4qk6QVCvMNObNmXtoyua+orfhQ7Gj1+gX7NmgzWU5yuiD9056T9fM+P62mTUvv4MQPbYz0nCIQKhJOqSqV4yihZPbP62xmC+kvpp2WXqPLGYbzDKogt8GjaSfUVesEwS5VCep6v7HU+3J+7hSnsUkeNFT81JRA4OdIiq0hcRVbzfy7RVdh19VFlXLza8jLOLZmZwjc7GNxISmJ0ylA/nOjfKbrHOjehgUO0kFuFrZZ1SeRrYmjn9CFrnBGO18jPh5wTFOM6rYMZlY7cyLaHNgNSsHzaeZJYnFh6NVL0rhtPUtu5bUxdJKxGULA+wy/MtwOvQEth9TmP2PzeDvZZMOHrPplp1i737OdPR4rrUVwyrrLPtg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(107886003)(82960400001)(66476007)(6666004)(2616005)(31686004)(83380400001)(53546011)(6486002)(26005)(4326008)(4744005)(6916009)(66946007)(38100700002)(16576012)(44832011)(5660300002)(2906002)(36756003)(316002)(8936002)(8676002)(86362001)(54906003)(186003)(956004)(31696002)(66556008)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzhDUkthVnN6YnlJMkRGaTBCQjVlemVQdHFreElaU3VDUUVBYTlGclpVc0FZ?= =?utf-8?B?MS94cjcyNUh1TG14b1BZclJFZzZReW51a2VFa0RMNTF0Zklab3ViazFFL0Jv?= =?utf-8?B?L1ZaY0NYSUdLQTNYNW4wdzQ4c3FZeUtXUWVvT0JVN0hIc1cwckRhVjM1WmdU?= =?utf-8?B?M3REQU5xZXhoOEFlYWtpWHRncmdPSnJ4Sks3aWpDT01NYVFjcHJqY3V0QnA4?= =?utf-8?B?RTgwd2N5TEJJU0Q3STEvL1h5Z1RpOXlFRzVYM0NtYXlKT0pLbzY4bGRSbjV0?= =?utf-8?B?cDRrd1I0QXR6eks0eDl1aHhoVjNYK3ltTnBtYnErV0tkcklhcmJOWEVwMnRj?= =?utf-8?B?S0djOXVjcWpUMUd4MHA3b1VnK2E5czZoZ3Z2MVRaNHUvWUloNFc5ZG1OUFlQ?= =?utf-8?B?eEVDQzhlUmNDNDRkdG5OWFpVYUN2MkFlNGorQkl6ajRCK1MrbTZvZUtTNy9O?= =?utf-8?B?ZXNncUZLVXRwM1ZVS1ZWL3dRZkJIaFVjK25sSkJiaXFadWtySkxOLzZaS2s3?= =?utf-8?B?MFUwOGwyYmtNY3ZQWjlLcDhBTWlkUWh0OUhObG9nQmE5d2d1QklPbzhUNHEw?= =?utf-8?B?MmtBdC85Q3F1cVFYUzU2OWE5L3U5TU53Qmg5d3FiSGhUTlZ4dGMzbHZ6dEJa?= =?utf-8?B?U3Vmak14b2RyNVlYdnpSQ2FyT2ZSeUVhdVhSZkVjaXJ5dW1pZUxPOXUvelB6?= =?utf-8?B?bjNTTzNvc21uMWZGdmpWQ3FJV1dPakFjNFRJcENBa1VieVJRUDE1L0tHcUlN?= =?utf-8?B?ampGWFBBQk11TTJ5cHBMODd0KzBSZld4THZoU2FhczdyMDRmM1Jmb3ZRdDFO?= =?utf-8?B?cXg3VVY2ZmY0VVc5UG1ESGJpT1RlcUVBTHVvRms3R2JQKzl0eXNhUllpN2ZO?= =?utf-8?B?dEovRHEzd3dkMzFYWnVQTU9aM3VhbVpxOW9MMzhORDljN1Fic1hMZFZsMCtX?= =?utf-8?B?Z0x1S0cwbFhhRFVObHdiSU9DRnBnRFM0Y3E1SWlIZDlkaWdMRHFOTG9VcmUr?= =?utf-8?B?MDJ0M21ZMVZRd0VjU1FGMmgwRlBkMXh1SldPTHhsRzcyUzZidVgzLzQ3UElQ?= =?utf-8?B?ZFcwK3EwRWdVZEVUb0NIZGdEOU52bEtmSTc0OXYxcmFkbE52SVB2Z0Vld2M3?= =?utf-8?B?TVBlNUFycndKaDdhWEhoaXBnZGhxdzQyQmlZMjhSNnhpcFh0VW4wMkllV3Vp?= =?utf-8?B?RGFETWRhTXFKR2kvQzFOMWdMTVFMcXk1ekdrT1ZTM0p4Q1hYZVJkaVVYM0ow?= =?utf-8?B?d0ZJdG9MVjhmRTNHK0d2M21mTWVWZ1JHNVlLWmJCL2Nmc2cxUFFocUFLYmxQ?= =?utf-8?B?V2U0WU1pelZWRWgydG1PTVpTTHlWSmV3ays1TVVQYlZVZHlTbngxbzczSnMv?= =?utf-8?B?cEcwaUZBL1dhNDdNcW1oVU9kK0hsNjBTYkM5LzR3NjcrN1lyMWZCR1cwMUZH?= =?utf-8?B?dmJGRThPQVFYRlIwQjVQamgrNmlxL25BL1VXUTZrTTVtSUV2NTVoL1hLVDY1?= =?utf-8?B?cVhocXdLemFad0RlNUR1WU5GYXhKcS9lMGllVU9EeXNKU0hyS0c1NS83aHNE?= =?utf-8?B?MlFRLzdpSEhuQ2pNUlloUzY3cjR3RWtxZ0ZZQkJUYU9GNVVNaWljZnpWK2Vv?= =?utf-8?B?TEh6Q1dQQ09MNWliVURTQjhHOWtsMWN6TnBEOU8zZmFoYTZqY1BLb2xwSkJv?= =?utf-8?B?dHNWQlVoTFpiNDNXZmpaQ1haT0dSYXBVdXQ3R3liVXVvT1IxbWlSRHoxMXdO?= =?utf-8?Q?Mz2ioFmxZuad5wBatxiVgwHy6V8fJFMYY0HTOJc?= X-MS-Exchange-CrossTenant-Network-Message-Id: 41ee8ddb-2d51-4629-5f68-08d992f76896 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 11:55:56.2532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gBlmDEv0wPLMHKNAQMti6tb8HPoe8g31gR63xcuwTBueDavu9GxlQuRcULHHVmWg0YRaYjfs/MptRrsMU2F+Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: > Sicne rte_eth_dev and rte_eth_dev_data structures are just moved > right now is a good chance to make a cleanup. > > No strong opinion, but I think it would be useful for the future. > > Make be at least some fixes from below could be accepted. > > Andrew Rybchenko (5): > ethdev: avoid documentation in next lines > ethdev: fix Rx/Tx spelling in just moved structures > ethdev: remove reserved fields from internal structures > ethdev: make device and data structures readable > ethdev: remove full stop after short comments and references > Overall +1 to these changes, I think this release is the opportunity to have changes like this. But as far as I can see only new moved code updated in 'ethdev_driver.h', why not update whole 'ethdev_driver.h'?