From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E0F99282 for ; Mon, 8 May 2017 12:35:40 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 08 May 2017 03:35:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,309,1491289200"; d="scan'208";a="1145024034" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.229.26]) ([163.33.229.26]) by fmsmga001.fm.intel.com with ESMTP; 08 May 2017 03:35:31 -0700 To: Slawomir Mrozowicz References: <20170505110755.8403-1-slawomirx.mrozowicz@intel.com> <5b8225a8-e749-5f89-c6d6-d12cf7328057@intel.com> Cc: dev@dpdk.org From: Declan Doherty Message-ID: <6ff2bb9c-b1ba-0513-160f-60ab329fe2a0@intel.com> Date: Mon, 8 May 2017 11:35:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5b8225a8-e749-5f89-c6d6-d12cf7328057@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] cryptodev: remove crypto device type enumeration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2017 10:35:41 -0000 On 05/05/2017 4:37 PM, Declan Doherty wrote: > On 05/05/2017 12:07 PM, Slawomir Mrozowicz wrote: >> This RFC changes device type identification to be based on a unique >> driver id replacing the current device type enumeration, which needed >> library changes every time a new crypto driver was added. >> >> The driver id is assigned dynamically during driver registration using >> the new macro RTE_PMD_REGISTER_CRYPTO_DRIVER which returns a unique >> uint8_t identifier for that driver. New APIs are also introduced >> to allow retrieval of the driver id using the driver name. >> >> Library code is included in the RFC >> (implementation in progress, API complete). >> >> Signed-off-by: Slawomir Mrozowicz >> --- > .... >> > Acked-by: Declan Doherty sorry please ignore this ack, it was meant for the doc announce patch regarding the same.