From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5187AA034D; Wed, 12 Jan 2022 11:57:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FF8E426E8; Wed, 12 Jan 2022 11:57:48 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 17E9D40040 for ; Wed, 12 Jan 2022 11:57:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641985066; x=1673521066; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=8tWVYnsfrjoWYtfp0l+PwSjNXz0T5UqG0ERTbz58dgw=; b=fLzuJvaGzY8g3DA6vlYCyVdLqH1x7q/DsB6dOqCOaSLkOxJ20EYDcga2 lTNoNQArdNhXfpbGf3H+knJswPnkqoJM5bXgtFgRg7Bt63SYO5OMjjt1T wOH2O6mT6yEyGVo5rl1HMTRvCXvGvkwEbmvMV7B8nE53Xp9R+WaxcbEN9 Qknq74CD/Utc4O/IXn1b2BDkdVOvjuaEZl313oeAkCjLaUzk1Q1LmYAfG aTtpj3z+kPgL14FYzTuZtillBCqB6NxPia+4o76KZFN6Q2eC+zqdPLpT9 0vMIhLTyKifwUWuM+QmB5E+dIyUhXi+3UctxG99YY7MT3L34uT8+8aket A==; X-IronPort-AV: E=McAfee;i="6200,9189,10224"; a="243505987" X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="243505987" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 02:57:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="620154429" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 12 Jan 2022 02:57:45 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 02:57:44 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 02:57:44 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 02:57:44 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 02:57:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=few0W04kBwXlwHk8XAMDQdiNp19FbUuYopG7jXPOixDX8aexbb+LlrympKvbxqAE6HR7CV3JGN7qW1RITWHGn9SUhxjrNGxb98yHr6S+R4WJhZvRHs/DtEZz2YOFuW7U/zP1DHlqo7bT8JdiSKTZBaahhI0MOn/rNo1mU3/USnVkD5zZ8frLPxzGSBCQWg2qXDTR+XULAG2qJPd1KsxpabtYKasaiP4IrpgJDXKJz76z48s4IzEbmDzt7COI4Z15sXvWIfXMDWJYu1EXFLWNXKm3r8R2f3GpXnfv42wMSKDG3XaB+HTTWimJWuqYDcgr0cT2esTuYpZl2w+1t1RcPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EVfSxKJ0fNVrhCW03QYo76nwwo2BiaymkEu6cLEFKpg=; b=odOGY9pYUIEgfXpIFqzsTSpwECGOREzaCVPBnXNLa4MAFOuc5CDRzr4mIqa3sHKBaF0WhBpR073q+FxoW7BrQj0UFXFdIis6ZjKFkwLD/GO1HEDLlMl19TUaEBUO43a391u1quWG1S/qCZng6A6j60gfjUZciWoXpIaQmw3nnKfCJmS/k5bA4ijv6I8EN2+/WpHxDQy1pYfitF+GpHIjGF3ZorQuo6uWbA1ZUPJ1v2E1U0CGaL7mNFVateD5koa9pCFB7j1iEFj+OnlPBxG61YoFHG6faJtZNmTpO7GisUUSUBwD7Pr1QDMp4v0x7+AT2EZcR7scVdYYvyvBvffJtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Wed, 12 Jan 2022 10:57:43 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4867.012; Wed, 12 Jan 2022 10:57:42 +0000 Message-ID: <6ffd00b2-2b1b-872b-f47d-56ad26824460@intel.com> Date: Wed, 12 Jan 2022 10:57:36 +0000 Content-Language: en-US To: Satheesh Paul , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , "Satha Koteswara Rao Kottidi" CC: "dev@dpdk.org" , Ori Kam , "Andrew Rybchenko" References: <20211109094204.2343402-1-psatheesh@marvell.com> <20211109094204.2343402-2-psatheesh@marvell.com> <27efba59-e991-9f50-69f3-d4df7e2b7823@intel.com> From: Ferruh Yigit Subject: Re: [EXT] Re: [dpdk-dev] [PATCH 22.02 2/2] net/cnxk: add devargs for configuring SDP channel mask X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec01193d-5b58-4c67-5123-08d9d5ba5b84 X-MS-TrafficTypeDiagnostic: PH0PR11MB4824:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZlOT2Rf/9hITzihTKjjn1R9G6Eigpkmha/cCwXeSpIJ5GY/yy481tdHVRiO9uvHcZcuuOOD/ql6YNLyiJp54oKo0rtgJ1k98TGHTYIQ5g9UcP5Rxrbj5ca6BYdxMYCEu6c5Q/Kay6YmU2ShUisYlnCxcI8PWJufOXRRyDjYWBGgi45Iw5caPO6iMT6fMQ1BB+sz9shiyVy0j4NYuZSyUQS2+gKAU/8zXmo9UJwSf8tkpVlbWoWWTNAB4M4a1rOwyKykrDeZP56OHPRPJgrKqIrIgibnZwYvlW8pz5A8Nn/s7I83iV8zq3v308vxOhaBa2H+Kwg/+dqEWRKFIx/S/aRg/1DCjgyXXJwwU/0HSjvdUW7omsMO6fbPGnzRfe/k917aUXun2dCS6cnaOAOT7dn2CYBGb4vW60jbKhyeF+wImrf65b89YfTi732BnIr6LuBUZWbaiePK3K0vs9zgpgrtb93qs7zoq1tRn4Y+DiHgg7CAOMKUpy1ynqjD7jZqjMGnEUMPkc5OHa772fEEG5a/UzdWaMpoDCFNcke/e4JfX8+ETjVnxG50cMf+OPaFjj9Aw3Exw91iL30rUgN9CZn5SYJab+//n+OeDjgjjGQ9x8b5QBmJW2oByQD/zlFA5uZ+ju7SV7oJSwKXsIw7+RvIGSDnkuHvaTLhShdAPVYc2nyVFxsi2HoOMOu4JIMKuiJxSeuSmAkpUmfYo3L4ohw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(6512007)(508600001)(31686004)(86362001)(6486002)(26005)(6506007)(53546011)(2616005)(316002)(54906003)(36756003)(110136005)(186003)(66556008)(5660300002)(6666004)(66476007)(44832011)(2906002)(4326008)(8676002)(8936002)(38100700002)(82960400001)(31696002)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGcxY0I1WUdzMU85QXZlOFNjZzhMNlZOR2NnNm82RUJwelo3NHNxS3lSNGg4?= =?utf-8?B?b3o2WSsxcmNwZHV6ditOeWJ3a3BuK3ltaEc1Z1Zia1JmOW00bzhEMkNyOGE5?= =?utf-8?B?Vkc0OEFTTlRQbStINm5Wd000U2FqRjR1Sm94SWNlOHJjUnFPK0RVdmFLQmNy?= =?utf-8?B?Ly9iTFZMRHJXTTRRNTJlbVVOTHNUVm1HR01VWHROZ1JWU2dPYUhhWW9MTlBl?= =?utf-8?B?V0MvajYwRWdQMFpteDZZOS96ZjJrT09QNkFxN3hFTStoY1lZM2NkV2RVbmQz?= =?utf-8?B?K3NHOHlweEV2aUI2R0U5cm5BQkxRR21LQ0VNQW1kd0tGbXc5THVFUS9LNGZC?= =?utf-8?B?MXBwMDd3Y0k5a3ordEE3dlJKT3k2SEI1L0QyV2JORTRQRDBuaU5ZcStXaE5h?= =?utf-8?B?MlBBZzJpRlpnSE1xUzNzdkFMdGJqdEN1Tk55WDVxMDRzNnovejljdXM4N0FJ?= =?utf-8?B?dXVuVGk5WUJtRW5GVXRCR1hTSGUzbVQrNTBocU1EV0RXV2tRTDdLR2VNZ1ZM?= =?utf-8?B?KzZvM2dPVm9wUEdpYkdaa2N5ZkF5U2FJZ2JUU1FxcFk2RStUdGhIbkRodEhF?= =?utf-8?B?R01wNEYrMTVyZkVGSHo4S1Q5ZjloaU5XTWh4ZktrR1YvSkRUSXRweSt6Q05y?= =?utf-8?B?TnBvaGF1MTVpdWQ0VXQwbU9scFBaRlZER2ZucTM0VmEyMy91K2pZdnUrNTFV?= =?utf-8?B?NXczUzZvaUZNejQ3S21Za3pQUU9FbGhSa3lkUU1lRit4eEk0VlRmTzNMd3k4?= =?utf-8?B?QlpjVXRuZ3IxTUU2Y0JGUmNZT1kyM2wzUkZneFF1SHJyZ2IzUEZpK2l4RWNN?= =?utf-8?B?OG1QVEp5NTEzVjBmUTduRnRKcEdLTWl1d0VnREQrcTdUQmdCZ1cybklYMENh?= =?utf-8?B?ckF1STZORDB4SW95bzN2OWNaZU5UYURjMkFVNjNIZEZWZEhmU2xmd2YzOHVq?= =?utf-8?B?WHhlNlpqL2tZYkZiQmFsZ25PRk9LR0FzaWxURFNQM01LWUFaNllKSUtKYjlI?= =?utf-8?B?WS9aZEptc2FNVkJ2Y3l3Kyt6Ym05UWFJbjJSeUc5V1JVajFUSXF5ZnhYMmJn?= =?utf-8?B?UDZHb3pLcTdRSGdvSVIyQUV5Wk5LaFh6MFp1V3YzZzNoNkZRZ1hndmtNeXNr?= =?utf-8?B?TlF0cW5zWmVBemFqWmFLbW8vWDNBV3RzdVVpVWJDZDNWcTN2NkZhWmg3ODNs?= =?utf-8?B?NDNQelFvdU11SU5PUVpjWTJhVHlZTytCdll0dENnb2Z4eDRSNmJONXBWK255?= =?utf-8?B?RGhsMWJtemRIWTRJaE9oSDN3dklXc3kwUStwUjNPSnVlL3FVUGllKzM0ZC9S?= =?utf-8?B?Y21wa1VBSmpoTHFoTVREbTdUU0lsYWZXcE1FU3hNMmp1bnUwVDJGNzFCWWZr?= =?utf-8?B?Y0xnK0dmWVZKSFFsQ3YxSFBXQW13T0p1WEtzZW85eE4wVmkrczJZN3VFN1Uz?= =?utf-8?B?WTVxcDBROFhiTmdQNTcvaVVVb1M5VmZITVg3RWZETG1naTcxNnRhS0pOVUVJ?= =?utf-8?B?VHo4c1hNMm5ENENTamRLWncrYVRNUncvNE9JcCtXY24wQjJhTnVRdXg1SWwv?= =?utf-8?B?MytGNzN5Ym5FRkpWZXRiZUtzT2NNVVdKMWtEL2Z2VFlFZHpzTngrcTUxeVIr?= =?utf-8?B?cmc0dzNPa1ZMMDFDMCtuZldqSDhPVDJubXN3NmsydFY1aFNyTk5va1plRGtp?= =?utf-8?B?Tlc0UzA4ZFVZWWhZbkVTaklEcmpMK2lFSUNjS0htbWRrMFNmQTZZenFUQWVY?= =?utf-8?B?eFJ0SmdHWVNrcTQvclBRWmZXcTdESU9TZklpVmp6NFFIMVBmV3FFT21sZTBE?= =?utf-8?B?TWwxMXZ5eTBNcGZBK0FOcGtnbzJ6eGpJbzhkcXdjME40d25MQjk5SVJrMW1s?= =?utf-8?B?a3VUUWhxMHYyVUJPcms4ZmUySkRzMFAxMWtkdWtVdVp4YU5ob0hDZ3Ira1o4?= =?utf-8?B?VHRCeUlaR1VSWVlHaUJKbjF2UjBjSnJ2TWg3RTUvOVZubmdlVXRzYUt6U0c2?= =?utf-8?B?WkNGOTBRd0dCSE9nNnNlWERLQ0FFL1Q3eDFSaGZpNDdCVjk5cW5yS1F2ZGZO?= =?utf-8?B?c0krUUF3WXNKN2RyYlZaQ1BPVWtCbG1BWGtKSjZ1Q2toRUpCK2V3d0Roajgw?= =?utf-8?B?RlRodnpYWExzdGFFbjlHb3l6anViVlUwYzhVYmRMK2wrZWUwKzJ2dHZFY0JK?= =?utf-8?Q?bCxNSaUcXp8j4a/ySHHDQVM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec01193d-5b58-4c67-5123-08d9d5ba5b84 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2022 10:57:42.8635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JfNqx3P8kAYDlfrWvR3cLOKVsaGwlr9tcMBcv0gPxP/Eiw8JXNSzG8wgstCnyaaurjyiRzsq5KvMejr2Vvp4Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4824 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/11/2022 2:29 PM, Satheesh Paul wrote: > Hi, > > Please find reply inline. > > Thanks, > Satheesh. > > -----Original Message----- > From: Ferruh Yigit > Sent: 11 January 2022 05:26 PM > To: Satheesh Paul ; Nithin Kumar Dabilpuram ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi > Cc: dev@dpdk.org; Ori Kam ; Andrew Rybchenko > Subject: [EXT] Re: [dpdk-dev] [PATCH 22.02 2/2] net/cnxk: add devargs for configuring SDP channel mask > > External Email > > ---------------------------------------------------------------------- > On 11/9/2021 9:42 AM, psatheesh@marvell.com wrote: >> From: Satheesh Paul >> >> This patch adds support to configure channel mask which will be used >> by rte flow when adding flow rules on SDP interfaces. >> > >> Hi Satheesh, > >> + Ori & Andrew. > >> What 'SDP' stands for? > It stands for "System DMA Packet Interface". This is when the system acts as PCIe endpoint. For instance, an x86 machine can act as a host having an Octeon TX* board plugged through this PCIe interface and packets are transferred through this PCIe interface. > >> And can this new devarg be provided with flow rule? Why it needs to be a new devarg? > SDP and its channel related info are specific to the hardware and rte flow api cannot be extended to support them. Hence, it is added as a new devarg. > >> Can you please give a sample of the rte flow API that will be used? > This channel mask will be used by the rte_flow_create() api. It is actually transparent at rte_flow_create() invocation itself. That is, at the time of rte_flow_create() invocation, user does not give any additional information. But internally, the driver's flow creation api takes the SDP channel/mask value supplied at the startup and applies it. Basically, in Octeon tx*, the interfaces have a "channel identifier" number. The rules in packet classification hardware are configured to match the channel number. With this change, we are relaxing the exact match and are allowing a range for this SDP interface. > Got it. I am still not quite clear what SDP is, but from below document my understanding was user need to provide these channel & mask while creating a flow rule, but according above description that is not the case, but this is internal to the driver, so I am OK to proceed. Thanks for clarification. > Thanks, > ferruh > > >> Signed-off-by: Satheesh Paul >> --- >> doc/guides/nics/cnxk.rst | 21 ++++++++++++++ >> drivers/net/cnxk/cnxk_ethdev_devargs.c | 40 ++++++++++++++++++++++++-- >> 2 files changed, 59 insertions(+), 2 deletions(-) >> >> diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst index >> 837ffc02b4..470e01b811 100644 >> --- a/doc/guides/nics/cnxk.rst >> +++ b/doc/guides/nics/cnxk.rst >> @@ -276,6 +276,27 @@ Runtime Config Options >> set with this custom mask, inbound encrypted traffic from all ports with >> matching channel number pattern will be directed to the inline IPSec device. >> >> +- ``SDP device channel and mask`` (default ``none``) >> + Set channel and channel mask configuration for the SDP device. This >> + will be used when creating flow rules on the SDP device. >> + >> + By default, for rules created on the SDP device, the RTE Flow API sets the >> + channel number and mask to cover the entire SDP channel range in the channel >> + field of the MCAM entry. This behaviour can be modified using the >> + ``sdp_channel_mask`` ``devargs`` parameter. >> + >> + For example:: >> + >> + -a 0002:1d:00.0,sdp_channel_mask=0x700/0xf00 >> + >> + With the above configuration, RTE Flow rules API will set the channel >> + and channel mask as 0x700 and 0xF00 in the MCAM entries of the flow rules >> + created on the SDP device. This option needs to be used when more than one >> + SDP interface is in use and RTE Flow rules created need to distinguish >> + between traffic from each SDP interface. The channel and mask combination >> + specified should match all the channels(or rings) configured on the SDP >> + interface. >> + >> .. note:: >> > > <...>