From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F4AFA32A1 for ; Thu, 24 Oct 2019 10:24:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D314A1E4EE; Thu, 24 Oct 2019 10:24:50 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id C9D2D1E4E1 for ; Thu, 24 Oct 2019 10:24:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571905489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hYqXn0kruI8DzVD/jBkRSgG0E/CYk6EXSAas5NsbLFs=; b=FVhq/EaNrCnf//h6lqcYXL41/ymDdPTfwtDHkS6+ABF2GkqjGpMYIBO2x5M8DL5+eEIvgS 4y53zMcfGquHOE8+1ehFWwa4YUFiS9ec5mrDdb+H38WZ2oPtw+JOq8aRCjLGuR2SqhPp60 Yp34z7pm/fJ63VwtBcrcr9Egxs0xBtM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-7YPS_oFJO2eH5CYl0CF5aw-1; Thu, 24 Oct 2019 04:24:47 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 512DC80183D; Thu, 24 Oct 2019 08:24:46 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 708E4196B2; Thu, 24 Oct 2019 08:24:44 +0000 (UTC) To: "Liu, Yong" , "Bie, Tiwei" , "Wang, Zhihong" , "stephen@networkplumber.org" , "gavin.hu@arm.com" Cc: "dev@dpdk.org" References: <20191021154016.16274-1-yong.liu@intel.com> <20191021220813.55236-1-yong.liu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E633DA664@SHSMSX103.ccr.corp.intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <7007d6d7-ea4e-49df-57d6-b19507369d96@redhat.com> Date: Thu, 24 Oct 2019 10:24:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E633DA664@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 7YPS_oFJO2eH5CYl0CF5aw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v8 00/13] vhost packed ring performance optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/24/19 9:18 AM, Liu, Yong wrote: >=20 >=20 >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Thursday, October 24, 2019 2:50 PM >> To: Liu, Yong ; Bie, Tiwei ; Wa= ng, >> Zhihong ; stephen@networkplumber.org; >> gavin.hu@arm.com >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v8 00/13] vhost packed ring performance optimization >> >> I get some checkpatch warnings, and build fails with clang. >> Could you please fix these issues and send v9? >> >=20 >=20 > Hi Maxime, > Clang build fails will be fixed in v9. For checkpatch warning, it was due= to pragma string inside. > Previous version can avoid such warning, while format is a little messy a= s below.=20 > I prefer to keep code clean and more readable. How about your idea? >=20 > +#ifdef UNROLL_PRAGMA_PARAM > +#define VHOST_UNROLL_PRAGMA(param) _Pragma(param) > +#else > +#define VHOST_UNROLL_PRAGMA(param) do {} while (0); > +#endif >=20 > + VHOST_UNROLL_PRAGMA(UNROLL_PRAGMA_PARAM) > + for (i =3D 0; i < PACKED_BATCH_SIZE; i++) That's less clean indeed. I agree to waive the checkpatch errors. just fix the Clang build for patch 8 and we're good. Thanks, Maxime > Regards, > Marvin >=20 >> Thanks, >> Maxime >> >> ### [PATCH] vhost: try to unroll for each loop >> >> WARNING:CAMELCASE: Avoid CamelCase: <_Pragma> >> #78: FILE: lib/librte_vhost/vhost.h:47: >> +#define vhost_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll >> 4") \ >> >> ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in >> parenthesis >> #78: FILE: lib/librte_vhost/vhost.h:47: >> +#define vhost_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll >> 4") \ >> +=09for (iter =3D val; iter < size; iter++) >> >> ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in >> parenthesis >> #83: FILE: lib/librte_vhost/vhost.h:52: >> +#define vhost_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") = \ >> +=09for (iter =3D val; iter < size; iter++) >> >> ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in >> parenthesis >> #88: FILE: lib/librte_vhost/vhost.h:57: >> +#define vhost_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)"= ) \ >> +=09for (iter =3D val; iter < size; iter++) >> >> total: 3 errors, 1 warnings, 67 lines checked >> >> 0/1 valid patch/tmp/dpdk_build/lib/librte_vhost/virtio_net.c:2065:1: >> error: unused function 'free_zmbuf' [-Werror,-Wunused-function] >> free_zmbuf(struct vhost_virtqueue *vq) >> ^ >> 1 error generated. >> make[5]: *** [virtio_net.o] Error 1 >> make[4]: *** [librte_vhost] Error 2 >> make[4]: *** Waiting for unfinished jobs.... >> make[3]: *** [lib] Error 2 >> make[2]: *** [all] Error 2 >> make[1]: *** [pre_install] Error 2 >> make: *** [install] Error 2 >> >> >> On 10/22/19 12:08 AM, Marvin Liu wrote: >>> Packed ring has more compact ring format and thus can significantly >>> reduce the number of cache miss. It can lead to better performance. >>> This has been approved in virtio user driver, on normal E5 Xeon cpu >>> single core performance can raise 12%. >>> >>> http://mails.dpdk.org/archives/dev/2018-April/095470.html >>> >>> However vhost performance with packed ring performance was decreased. >>> Through analysis, mostly extra cost was from the calculating of each >>> descriptor flag which depended on ring wrap counter. Moreover, both >>> frontend and backend need to write same descriptors which will cause >>> cache contention. Especially when doing vhost enqueue function, virtio >>> refill packed ring function may write same cache line when vhost doing >>> enqueue function. This kind of extra cache cost will reduce the benefit >>> of reducing cache misses. >>> >>> For optimizing vhost packed ring performance, vhost enqueue and dequeue >>> function will be splitted into fast and normal path. >>> >>> Several methods will be taken in fast path: >>> Handle descriptors in one cache line by batch. >>> Split loop function into more pieces and unroll them. >>> Prerequisite check that whether I/O space can copy directly into mbuf >>> space and vice versa. >>> Prerequisite check that whether descriptor mapping is successful. >>> Distinguish vhost used ring update function by enqueue and dequeue >>> function. >>> Buffer dequeue used descriptors as many as possible. >>> Update enqueue used descriptors by cache line. >>> >>> After all these methods done, single core vhost PvP performance with 64= B >>> packet on Xeon 8180 can boost 35%. >>> >>> v8: >>> - Allocate mbuf by virtio_dev_pktmbuf_alloc >>> >>> v7: >>> - Rebase code >>> - Rename unroll macro and definitions >>> - Calculate flags when doing single dequeue >>> >>> v6: >>> - Fix dequeue zcopy result check >>> >>> v5: >>> - Remove disable sw prefetch as performance impact is small >>> - Change unroll pragma macro format >>> - Rename shadow counter elements names >>> - Clean dequeue update check condition >>> - Add inline functions replace of duplicated code >>> - Unify code style >>> >>> v4: >>> - Support meson build >>> - Remove memory region cache for no clear performance gain and ABI brea= k >>> - Not assume ring size is power of two >>> >>> v3: >>> - Check available index overflow >>> - Remove dequeue remained descs number check >>> - Remove changes in split ring datapath >>> - Call memory write barriers once when updating used flags >>> - Rename some functions and macros >>> - Code style optimization >>> >>> v2: >>> - Utilize compiler's pragma to unroll loop, distinguish clang/icc/gcc >>> - Buffered dequeue used desc number changed to (RING_SZ - PKT_BURST) >>> - Optimize dequeue used ring update when in_order negotiated >>> >>> >>> Marvin Liu (13): >>> vhost: add packed ring indexes increasing function >>> vhost: add packed ring single enqueue >>> vhost: try to unroll for each loop >>> vhost: add packed ring batch enqueue >>> vhost: add packed ring single dequeue >>> vhost: add packed ring batch dequeue >>> vhost: flush enqueue updates by cacheline >>> vhost: flush batched enqueue descs directly >>> vhost: buffer packed ring dequeue updates >>> vhost: optimize packed ring enqueue >>> vhost: add packed ring zcopy batch and single dequeue >>> vhost: optimize packed ring dequeue >>> vhost: optimize packed ring dequeue when in-order >>> >>> lib/librte_vhost/Makefile | 18 + >>> lib/librte_vhost/meson.build | 7 + >>> lib/librte_vhost/vhost.h | 57 ++ >>> lib/librte_vhost/virtio_net.c | 948 +++++++++++++++++++++++++++------- >>> 4 files changed, 837 insertions(+), 193 deletions(-) >>> >=20