From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E953A0548; Thu, 11 Nov 2021 12:00:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 402DC4113C; Thu, 11 Nov 2021 12:00:14 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 496C140E03 for ; Thu, 11 Nov 2021 12:00:13 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A60845C01C8; Thu, 11 Nov 2021 06:00:12 -0500 (EST) Received: from imap48 ([10.202.2.98]) by compute3.internal (MEProxy); Thu, 11 Nov 2021 06:00:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=kGOvrzajL3Y647I/Neq8fM748rQu1hZ oeLOcCf5VrLk=; b=64cfixTs0i+o5UapXcayXPac4DWttv92MBBQAGWZVk95MF6 idos9qi3F9a15fuTzkRy5vq+uGH3c37WZYOV+A9T087aSg41X/aLaj6s0mLUkEkv a3VvvZOBY6wK2DrcepI7ZeV3HHgDEhz0pmty9jl7yIvIwsAv7HTQHUzUQyvqZWn3 sHv/an+R7Oxt54kbwMtW63itSk6u+J9F3DHrgfC0y+XQrSLVGo6mX4tvjVL2WARq d9Um202MvYdBlcusFb/lSEmYWditBRC62WdFkoyIIuYHVM2bCtaQI3uSZg7tNd4e afeRrYitA7cl88yTifLdpQfipTdorwV+5G2bqGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=kGOvrz ajL3Y647I/Neq8fM748rQu1hZoeLOcCf5VrLk=; b=SnEmLNI7e3EcCYgC9cbZf9 qps8/GAy8tsw3aBFK3heFmVsFcW4zzc1uyLaF6KHU61s0mTFnGhMYD4jwBYkNQGv blUe/3k/tPcHfKR7iyjGQSoYCHIxlNLRznDffJYHVRdb4ShjBa9Ug552rYnHmllY Q9TJ/66xTIpw8cjMB4xJ2QIVclal+T978/kymmRgE89o5vYt/6h8UKEJdjl9ND8z Kfvug25cl96WGNPv/pQ1V7+g2MVO/iUSeK/IyW99KHhcEqc6pgiX0ziqI881rdsn Uj5fIWIm6wxoM6n4y1CPus1kua98/pgRbFqg5W2/q+XYQLsln6Zd3m3Ue9vW8s8Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrvddugddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpefirgotthgr nhgptfhivhgvthcuoehgrhhivhgvsehuvdehiedrnhgvtheqnecuggftrfgrthhtvghrnh epgfeuhfffleeludeuheeuteeufeegtdeiveduudfhgeevteeutdelueffueehkeefnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrihhvvg esuhdvheeirdhnvght X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7B52721E0429; Thu, 11 Nov 2021 06:00:12 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1371-g2296cc3491-fm-20211109.003-g2296cc34 Mime-Version: 1.0 Message-Id: <701ff4b4-5350-4e96-a4d4-3e178c71bce3@www.fastmail.com> In-Reply-To: <20211111100621.84769-1-kumaraparamesh92@gmail.com> References: <20211111100621.84769-1-kumaraparamesh92@gmail.com> Date: Thu, 11 Nov 2021 11:59:41 +0100 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Kumara Parameshwaran" Cc: dev@dpdk.org Subject: Re: [PATCH] failsafe: Bug fix for the secondary process RX-TX support Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 11, 2021, at 11:06, Kumara Parameshwaran wrote: > Remove the vdev args check for secondary process which prevents the > secondary from attaching > to the device created by the primary process via the hotplug framework. > This check was removed > for other vdevs but was missed for failsafe. > > Signed-off-by: Kumara Parameshwaran Hello Kumara, Thanks for your patch. If this is a fix, can you provide the fixline with a pointer to the patch it is meant to fix please? I'm guessing this should be this: Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary process") Cc: qi.z.zhang@intel.com Looking at this patch, I see also + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return rte_eth_dev_release_port_secondary(eth_dev); + Added to the remove callbacks of the ports. It seems to be omitted from this patch, is there a reason? > --- > drivers/net/failsafe/failsafe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c > index ad6b43538e..3c754a5f66 100644 > --- a/drivers/net/failsafe/failsafe.c > +++ b/drivers/net/failsafe/failsafe.c > @@ -340,8 +340,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) > INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s", > name); > > - if (rte_eal_process_type() == RTE_PROC_SECONDARY && > - strlen(rte_vdev_device_args(vdev)) == 0) { > + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { > eth_dev = rte_eth_dev_attach_secondary(name); > if (!eth_dev) { > ERROR("Failed to probe %s", name); > -- > 2.30.1 (Apple Git-130) -- Gaetan Rivet