From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 6A4002BAE for ; Mon, 10 Apr 2017 14:19:18 +0200 (CEST) Received: from 6wind.com (unknown [10.16.0.184]) by proxy.6wind.com (Postfix) with SMTP id DD2BF27089; Mon, 10 Apr 2017 14:19:11 +0200 (CEST) Received: by 6wind.com (sSMTP sendmail emulation); Mon, 10 Apr 2017 14:19:10 +0200 From: Pascal Mazon To: viktorin@rehivetech.com, hemant.agrawal@nxp.com Cc: dev@dpdk.org, Pascal Mazon Date: Mon, 10 Apr 2017 14:18:51 +0200 Message-Id: <70283424711dfed16b5a8a0a118966b39f6d0817.1491578065.git.pascal.mazon@6wind.com> X-Mailer: git-send-email 2.12.0.306.g4a9b9b3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] mk: fix quoting for ARM mtune argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 12:19:18 -0000 The mtune argument needs an unquoted argument, otherwise the compiler complains: arm-buildroot-linux-gnueabi-gcc.br_real: error: unrecognized argument in option ‘-mtune="cortex-a9"’ Fixes: 02a8686263de ("mk: introduce ARMv7 architecture") Fixes: 4a7e4626975a ("mk: introduce NXP dpaa2 architecture based on armv8-a") Reported-by: Jan Viktorin Signed-off-by: Pascal Mazon --- I couldn't test it though, as I don't have an ARM toolchain. mk/machine/armv7a/rte.vars.mk | 2 +- mk/machine/dpaa2/rte.vars.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mk/machine/armv7a/rte.vars.mk b/mk/machine/armv7a/rte.vars.mk index 36fa3dea1834..41c4c408278c 100644 --- a/mk/machine/armv7a/rte.vars.mk +++ b/mk/machine/armv7a/rte.vars.mk @@ -57,7 +57,7 @@ MACHINE_CFLAGS += -march=armv7-a ifdef CONFIG_RTE_ARCH_ARM_TUNE -MACHINE_CFLAGS += -mtune=$(CONFIG_RTE_ARCH_ARM_TUNE) +MACHINE_CFLAGS += -mtune=$(CONFIG_RTE_ARCH_ARM_TUNE:"%"=%) endif MACHINE_CFLAGS += -mfpu=neon diff --git a/mk/machine/dpaa2/rte.vars.mk b/mk/machine/dpaa2/rte.vars.mk index 8541633c17dc..61ada89a6277 100644 --- a/mk/machine/dpaa2/rte.vars.mk +++ b/mk/machine/dpaa2/rte.vars.mk @@ -56,5 +56,5 @@ MACHINE_CFLAGS += -march=armv8-a ifdef CONFIG_RTE_ARCH_ARM_TUNE -MACHINE_CFLAGS += -mcpu=$(CONFIG_RTE_ARCH_ARM_TUNE) +MACHINE_CFLAGS += -mcpu=$(CONFIG_RTE_ARCH_ARM_TUNE:"%"=%) endif -- 2.12.0.306.g4a9b9b3