From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>, Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
david.marchand@redhat.com, asafp@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/l3fwd-power: fix check_ptype query
Date: Sun, 22 Nov 2020 18:03:16 +0100 [thread overview]
Message-ID: <70286351.Sg7g2MFZJO@thomas> (raw)
In-Reply-To: <20201117184940.19218-1-getelson@nvidia.com>
I was expecting a review from David Hunt.
Let's proceed.
17/11/2020 19:49, Gregory Etelson:
> l3fwd-power uses `--parse-ptype' parameter to query egress packets
> type. Before that feature is eanbled l3fwd-power verifies PMD ability
typo: eanbled -> enabled
> to advertise supporrtred packet types with
double typo: supporrtred -> supported
> rte_eth_dev_get_supported_ptypes().
Adding the note from ethdev API description:
"
Better to invoke this API after the device is already started or rx burst
function is decided, to obtain correct supported ptypes.
"
> The patch updates code for PMDs that register supported types after
> dev_start.
>
> Fixes: 82bea4661626 ("examples/l3fwd-power: add --parse-ptype option")
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Applied, thanks
prev parent reply other threads:[~2020-11-22 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:59 [dpdk-dev] [PATCH 1/2] drivers/net/mlx5: fix representor interrupts handler Gregory Etelson
2020-10-28 9:59 ` [dpdk-dev] [PATCH 2/2] examples/l3fwd-power: fix check_ptype query Gregory Etelson
2020-11-04 18:25 ` [dpdk-dev] [PATCH 1/2] drivers/net/mlx5: fix representor interrupts handler Thomas Monjalon
2020-11-17 18:49 ` [dpdk-dev] [PATCH v2 1/2] examples/l3fwd-power: fix check_ptype query Gregory Etelson
2020-11-17 18:49 ` [dpdk-dev] [PATCH v2 2/2] drivers/net/mlx5: fix representor interrupts handler Gregory Etelson
2020-11-22 17:05 ` Thomas Monjalon
2020-11-22 17:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70286351.Sg7g2MFZJO@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).