From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A5D1A04B1; Sun, 22 Nov 2020 18:03:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D63872D8; Sun, 22 Nov 2020 18:03:24 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 7057BFFA for ; Sun, 22 Nov 2020 18:03:21 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 238C2513; Sun, 22 Nov 2020 12:03:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 22 Nov 2020 12:03:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= tGprn7iMAd16AXd65AoZmuEuMYWHK2v6MsX5y+9CJek=; b=D9Jk0VN9nyXauwR7 OO+pdGAbF5g+GEuuevKEEnCuEEUQaLEuaVhDHKMI/Ffme35VaX3T9L1R5low38BT DSjv//kERxmCmoIYwpJenejKajdRvLboxVy3eFAx7WYxD+iUHZOBUJzLpG8LWPJH rRzcxijC7ipHn61UgmMhDuGGfRhL9Gd33dAKMIoSqwZkCCfy3XWY9JYFYUr1e+ta +Uct5ccxO8JHrduWA4ZCSESMuFgpjYhQOB5ZZ421iWI0hd8yFAK1T6hI2qlx+3p1 xjoVT6L4SuhaJ2FfPyBTk8gUMMFQNtotI667UF8jK9LkSjDbIC2GlmlyonhOT0Hi Eej96Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=tGprn7iMAd16AXd65AoZmuEuMYWHK2v6MsX5y+9CJ ek=; b=atxnO2KnP5fLOcuG+Dh7gUA2vlkrKHYkVE2aq2jOjU0iyiWQ1AAvuCyxI gZ3dFO6h1E5RJUrANf11fUthSBlA7qdrhUvuhOFZDZN0G68IP0E1KjK94JlLGXY2 mUPLvTPF+0wGW3dH3Qs/JuGkh9fDDp00KasKVvxmPEgeK+YA0jAdgiujFzjB8z63 f7GlCD4HEYinxq+RCRRonQqcKtekSlrze1LzWhYykvfU6eeZgmG5wOQ+mKVbs2ff E4p8A/H3m3O/wcib5bsxjRXhrfoQIulqnBAcOzDFSb3fMmeJbKtW9t9Yk+BnRGrW 6xg6c6jteSr0ZtL0AhIUY+duXrprA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeggedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 56BAD3064AA6; Sun, 22 Nov 2020 12:03:17 -0500 (EST) From: Thomas Monjalon To: David Hunt , Gregory Etelson Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, david.marchand@redhat.com, asafp@nvidia.com Date: Sun, 22 Nov 2020 18:03:16 +0100 Message-ID: <70286351.Sg7g2MFZJO@thomas> In-Reply-To: <20201117184940.19218-1-getelson@nvidia.com> References: <20201028095935.27855-1-getelson@nvidia.com> <20201117184940.19218-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] examples/l3fwd-power: fix check_ptype query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I was expecting a review from David Hunt. Let's proceed. 17/11/2020 19:49, Gregory Etelson: > l3fwd-power uses `--parse-ptype' parameter to query egress packets > type. Before that feature is eanbled l3fwd-power verifies PMD ability typo: eanbled -> enabled > to advertise supporrtred packet types with double typo: supporrtred -> supported > rte_eth_dev_get_supported_ptypes(). Adding the note from ethdev API description: " Better to invoke this API after the device is already started or rx burst function is decided, to obtain correct supported ptypes. " > The patch updates code for PMDs that register supported types after > dev_start. > > Fixes: 82bea4661626 ("examples/l3fwd-power: add --parse-ptype option") > > Signed-off-by: Gregory Etelson Applied, thanks