From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05CBA45512; Wed, 3 Jul 2024 03:34:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5530402C5; Wed, 3 Jul 2024 03:34:26 +0200 (CEST) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id 949B64003C for ; Wed, 3 Jul 2024 03:34:25 +0200 (CEST) Received: from loongson.cn (unknown [10.20.42.74]) by gateway (Coremail) with SMTP id _____8DxPOueqoRmP1oAAA--.984S3; Wed, 03 Jul 2024 09:34:23 +0800 (CST) Received: from [10.20.42.74] (unknown [10.20.42.74]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axw8SYqoRm1Rw5AA--.56505S3; Wed, 03 Jul 2024 09:34:18 +0800 (CST) Subject: Re: [PATCH v5 1/2] power: introduce PM QoS API on CPU wide To: Huisong Li , dev@dpdk.org Cc: mb@smartsharesystems.com, thomas@monjalon.net, ferruh.yigit@amd.com, anatoly.burakov@intel.com, david.hunt@intel.com, sivaprasad.tummala@amd.com, stephen@networkplumber.org, david.marchand@redhat.com, liuyonglong@huawei.com References: <20240320105529.5626-1-lihuisong@huawei.com> <20240702035010.4874-1-lihuisong@huawei.com> <20240702035010.4874-2-lihuisong@huawei.com> From: zhoumin Message-ID: <702fd523-cb50-22cb-190d-c649e5442309@loongson.cn> Date: Wed, 3 Jul 2024 01:32:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20240702035010.4874-2-lihuisong@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf8Axw8SYqoRm1Rw5AA--.56505S3 X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/1tbiAQAHAWaDXRYJ8wABsS X-Coremail-Antispam: 1Uk129KBj93XoW7ZFy3ArWrZF1DWw48GrWxuFX_yoW8CrW7pF n7Kw1Yk3Wvyw13Ja1S93WIyFyFvaykCr45G343J34qyr98WrsIqr1rKFW5JrykZFy0ka4j vr1q9wn8u347uFgCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzV AYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1QVy3UU UUU== X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Huisong, I knew that this patchset was based on the *dpdk-next-net* repository in our previous communication. However, maybe it's better to rebase this pactchset on the *dpdk* repository. Because the CI system is not smart enough to recognize the patchset as a change for the *dpdk-next-net* repository. I personally feel this patchset is more likely a change for the *dpdk* repository because it modified the `lib` directory which is the infrastructure of DPDK instead of a feature for *dpdk-next-net*. Best regard, Min Zhou On Tue, July 2, 2024 at 11:50AM, Huisong Li wrote: > The deeper the idle state, the lower the power consumption, but the longer > the resume time. Some service are delay sensitive and very except the low > resume time, like interrupt packet receiving mode. > > And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs > interface is used to set and get the resume latency limit on the cpuX for > userspace. Each cpuidle governor in Linux select which idle state to enter > based on this CPU resume latency in their idle task. > > The per-CPU PM QoS API can be used to control this CPU's idle state > selection and limit just enter the shallowest idle state to low the delay > after sleep by setting strict resume latency (zero value). > > Signed-off-by: Huisong Li > Acked-by: Morten Brørup > --- > doc/guides/prog_guide/power_man.rst | 24 ++++++ > doc/guides/rel_notes/release_24_07.rst | 4 + > lib/power/meson.build | 2 + > lib/power/rte_power_qos.c | 114 +++++++++++++++++++++++++ > lib/power/rte_power_qos.h | 73 ++++++++++++++++ > lib/power/version.map | 2 + > 6 files changed, 219 insertions(+) > create mode 100644 lib/power/rte_power_qos.c > create mode 100644 lib/power/rte_power_qos.h