From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 20BC53772 for ; Fri, 7 Jul 2017 12:17:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B753020A34; Fri, 7 Jul 2017 06:17:41 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 07 Jul 2017 06:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=8YTA2pjkLHJnPM7 FIxVl476g5Qo7pXJi8DOuS9NuVeU=; b=hQR8YU+Z2fharp9k/9PNpMAB8BG4Zc4 lNttoNcJxOF4qvWcDRvgfq4BtbPvu3MxBpvT6gSaGFwXma/sk29R60mKvSNt6dN5 jwkDgZF+umhsbCpv/Ls75vQT2dyVtlyQM1rnXh+CtIdml0NfzSFV9mN44J55GtJx 0C5WG5IP81cU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=8YTA2pjkLHJnPM7FIxVl476g5Qo7pXJi8DOuS9NuVeU=; b=fhcJ+m4W DKdtV+B6IFBxbemeoNBfn+4nBuMCZg1XZ8shrGFoM4Bs+5N2AzwFJNEku95EvliS EldBK9CQGgjNRqM90AFGxGnkI4NvZHn5dd8734bx6uDlpdOT9ZGBwQxBPQilJzHw 5aSLce0B3QLF/yzqjCAZXk3osBwgw/VmMcF2/SZOiDqY4JEgP3UiRel2yCELQh2N GNFVxR3Sq6e/aWtWtqYVGXE8FXTiDvS8kYTyf/19HnrgEKtUJb0Vo2wpTbDqX3Op 5PG0pxXMZlJlRvyrhc3pAmI9ifEOabIWNSUd2M0g6bH8ybo/I7IjCne5VOuiDE3+ x938/DjF37qcYQ== X-ME-Sender: X-Sasl-enc: s56QhtvleZZkeX9DrAs2CDXY2c0fXWXIAhYVDGYPJEhI 1499422661 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 72B857E81A; Fri, 7 Jul 2017 06:17:41 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, helin.zhang@intel.com, jingjing.wu@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, thomas.monjalon@6wind.com, ferruh.yigit@intel.com Date: Fri, 07 Jul 2017 12:17:40 +0200 Message-ID: <7030258.umMgtiJvDN@xps> In-Reply-To: <1888554.fe4JxUsZG9@xps> References: <1498648044-57541-2-git-send-email-jia.guo@intel.com> <1498712510-44217-3-git-send-email-jia.guo@intel.com> <1888554.fe4JxUsZG9@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 10:17:42 -0000 07/07/2017 09:56, Thomas Monjalon: > 29/06/2017 07:01, Jeff Guo: > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1283,6 +1283,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw) > > > > /* enable uio intr after callback register */ > > rte_intr_enable(intr_handle); > > + > > /* > > * Add an ethertype filter to drop all flow control frames transmitted > > * from VSIs. By doing so, we stop VF from sending out PAUSE or PFC > > @@ -5832,11 +5833,29 @@ struct i40e_vsi * > > { > > struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > > struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > + struct rte_uevent event; > > uint32_t icr0; > > + struct rte_pci_device *pci_dev; > > + struct rte_intr_handle *intr_handle; > > + > > + pci_dev = RTE_ETH_DEV_TO_PCI(dev); > > + intr_handle = &pci_dev->intr_handle; > > > > /* Disable interrupt */ > > i40e_pf_disable_irq0(hw); > > > > + /* check device uevent */ > > + if (rte_uevent_get(intr_handle->uevent_fd, &event) == 0) { > > + if (event.subsystem == RTE_UEVENT_SUBSYSTEM_UIO) { > > + if (event.action == RTE_UEVENT_REMOVE) { > > + _rte_eth_dev_callback_process(dev, > > + RTE_ETH_EVENT_INTR_RMV, NULL); > > + return; > > + } > > + } > > + goto done; > > + } > > There is nothing specific to i40e in this patch. > It seems wrong to add such generic code in every drivers. It should be managed at bus layer and not be specific to ethdev only.