From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38566A052A; Tue, 2 Feb 2021 19:08:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E936C24038A; Tue, 2 Feb 2021 19:08:03 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B649A240388 for ; Tue, 2 Feb 2021 19:08:02 +0100 (CET) IronPort-SDR: KqptkQp8sf5G48Pm90zg1fsv4BH2b8Fr7cTONG2toysnPYUKR5FGtJQIdNtFqi6jEQxmNzSbHN LhkETZZF4Ebw== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="160666974" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="160666974" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 10:08:01 -0800 IronPort-SDR: 27jrO8pZXKkOdTNqpqrbBOHWaW7N2lYRmijS3Y/LlF3S0Dt/LA1B8TMeqNuX6cNrIrLItlXABE yRDpLNFBFI8w== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391603249" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 10:08:00 -0800 To: Jiawen Wu , dev@dpdk.org References: <20210122094800.197748-1-jiawenwu@trustnetic.com> From: Ferruh Yigit Cc: Thomas Monjalon , David Marchand Message-ID: <703a35e7-9b88-8fe6-8789-4e1f5e15462f@intel.com> Date: Tue, 2 Feb 2021 18:07:56 +0000 MIME-Version: 1.0 In-Reply-To: <20210122094800.197748-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 00/20] net/txgbe: add VF driver support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2021 9:47 AM, Jiawen Wu wrote: > This patch adds txgbevf PMD as a part of txgbe PMD. > > Jiawen Wu (20): > net/txgbe: add ethdev probe and remove for VF device > net/txgbe: add base code for VF driver > net/txgbe: support add and remove VF device MAC address > net/txgbe: get VF device information > net/txgbe: add interrupt operation for VF device > net/txgbe: get link status of VF device > net/txgbe: add Rx and Tx unit init for VF device > net/txgbe: add VF device stats and xstats get operation > net/txgbe: add VLAN handle support to VF driver > net/txgbe: add RSS support for VF device > net/txgbe: add VF device promiscuous and allmulticast mode > net/txgbe: support multicast MAC filter for VF driver > net/txgbe: support to update MTU on VF device > net/txgbe: support register dump on VF device > net/txgbe: start and stop VF device > net/txgbe: add some supports as PF driver implemented > net/txgbe: support VF representor > net/txgbe: hardware support for VF representor > net/txgbe: support VLAN filter for VF representor > doc: update release note for txgbe > Hi Jiawen, I put some comments on some patches, can you please send a new version with updates? And I want to note that it is specially hard to review this PMD because it is clone of complete and complex ixgbe driver. So most of the code is already ready, we are tying to structure it logically for upstreaming it but it is not possible to review the details of this much feature in this short time. For those feature we are relying on the Wangxun to test all these features, and to confirm this, can it be possible for Wangxun to send some test results for this release? Similar to those reports: https://patches.dpdk.org/patch/84436/ https://patches.dpdk.org/patch/84500/ https://patches.dpdk.org/patch/84517/ Also quick test results for the -rc2 & -rc3 can be very helpful, if you can provide, like: http://inbox.dpdk.org/dev/c2bd98a6da8d4955b19b8838c9bf60b7@intel.com/#t http://inbox.dpdk.org/dev/92ce632a-dc21-f50c-d4d6-85e7961b6e3b@linux.vnet.ibm.com/#t Thanks, ferruh