[dpdk-dev] [PATCH] net/mlx5: fix flow director delete with drop action

[dpdk-dev] [PATCH] net/mlx5: fix flow director delete with drop action

[Nelio Laranjeiro]

Removing a flow director rule with a drop action ends by not removing it
due to a missing verbs drop specification in the conversion process between
the flow director and generic flow API.

Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx5/mlx5_flow.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 5f49bf5ff..703a3459e 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2866,6 +2866,22 @@ priv_fdir_filter_delete(struct priv *priv,
 				attributes.actions, &error, &parser);
 	if (ret)
 		goto exit;
+	/*
+	 * Special case for drop action which is only set in the
+	 * specifications when the flow is created.  In this situation the
+	 * drop specification is missing.
+	 */
+	if (parser.drop) {
+		struct ibv_flow_spec_action_drop *drop;
+
+		drop = (void *)((uintptr_t)parser.drop_q.ibv_attr +
+				parser.drop_q.offset);
+		*drop = (struct ibv_flow_spec_action_drop){
+			.type = IBV_FLOW_SPEC_ACTION_DROP,
+			.size = sizeof(struct ibv_flow_spec_action_drop),
+		};
+		parser.drop_q.ibv_attr->num_of_specs++;
+	}
 	TAILQ_FOREACH(flow, &priv->flows, next) {
 		struct ibv_flow_attr *attr;
 		struct ibv_spec_header *attr_h;
-- 
2.11.0

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director delete with drop action

[Ferruh Yigit]

On 11/6/2017 2:41 AM, Nelio Laranjeiro wrote:
> Removing a flow director rule with a drop action ends by not removing it
> due to a missing verbs drop specification in the conversion process between
> the flow director and generic flow API.
> 
> Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-net/master, thanks.