From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B80B7A0547; Mon, 8 Feb 2021 13:58:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D9824014E; Mon, 8 Feb 2021 13:58:49 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D7A9340147 for ; Mon, 8 Feb 2021 13:58:47 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E647E5C00AB; Mon, 8 Feb 2021 07:58:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 08 Feb 2021 07:58:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= T/ZTqDPMmm4Nnt2qJyJZNLOSTtnUTiXZkpRpSAXLdGw=; b=DIHK/rubOiagH39S mxw2ud7ZBXsYE4JFC2MUMz3lXDuS5Nu6BjChaZqB11V5W+KQDS2m90Y1iZG4oXHh jpToOW76BGeWmrfbsjeBMUf4twwdtzBXvFGkjeV8veAM1FCrpijfceoJLSvmR7X3 M1hncXie2lJgIXLFHV/J8xZiRb0c71ck6nyPEa52xZVQJ96TKCek3ns6+7yxLFXm 9HatyjzbKPtuY1WZrBh2XLkK7iGnxIXoq8qaUiYaeD2D7VoiVYCHRqeE/ek7Nh0H 8L1dcIQrjnE8xF8NZWaxiZ6ZnLSdVXR9GlLRGjbBOI1t95F8FvoWznPnpxsYYC8g xbvWJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=T/ZTqDPMmm4Nnt2qJyJZNLOSTtnUTiXZkpRpSAXLd Gw=; b=nrVEBy7sLOgaLExZQUqLJH9YSZCH1JhOgPQb8tq7RROhqka7gIAlqVl6G 8sb8uQyUvxBIjqDZuOVS3OArzLY1nDh2xdcTsvHUPOpT2ljo6LlDSgUv3MG6323u 3/b/v41CzAgwv7TSVAXDhsPlltY4xJ8/k+yTHoSoBi0EsCZ82FH+Fh6sCOAG6ZSp Aow1E3dl7HfAcpbYkCURBbVt/iSKNi3eDo28VTR1EjHx5iDPZJhi/tWhHAizscxj goZF7BjmRzIIFb5jEgZz1zYF8Y59lgN14QT1UgUFJMkjbAXI9kT9uDYcOHMxf5aw 2HT2lMVy3o0qIXfrVAEq/07f0zodQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheefgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B3E3108005F; Mon, 8 Feb 2021 07:58:44 -0500 (EST) From: Thomas Monjalon To: Asaf Penso Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, jerinj@marvell.com, ajit.khaparde@broadcom.com, andrew.rybchenko@oktetlabs.ru Date: Mon, 08 Feb 2021 13:58:42 +0100 Message-ID: <7043894.1yPTiaYGO9@thomas> In-Reply-To: <1612695128-31878-1-git-send-email-asafp@nvidia.com> References: <1612694777-31505-1-git-send-email-asafp@nvidia.com> <1612695128-31878-1-git-send-email-asafp@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] doc: add new tables for rte flow items and actions support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/02/2021 11:52, Asaf Penso: > In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all > supported features. > It has a single line for "Flow API" that refers to rte_flow support. > rte_flow is composed of many items and actions that are not expressed in > this single line. One comment to add to this commit message if you agree: When the new rte_flow tables are filled for all relevant PMDs, we could remove the row "Flow API" from the main table. > The following new tables are suggested: > 1. rte_flow items > 2. rte_flow actions [...] > +vlan = > +ipv4 = > +ipv6 = > +icmp = > +udp = > +tcp = > +sctp = > +vxlan = [...] > +set_ipv4_src = > +set_ipv4_dst = In items and actions above (and others) I understand the names are taken directly from the enums or structs. However I could imagine a slight different natural naming, using some upper cases and spaces. Example: set_ipv4_dst -> set IPv4 dst I see pros and cons. What are other opinions?