From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id DFFAA1C52
 for <dev@dpdk.org>; Wed, 13 Jul 2016 11:27:22 +0200 (CEST)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 35382D4E4C;
 Wed, 13 Jul 2016 09:27:22 +0000 (UTC)
Received: from [10.36.6.136] (vpn1-6-136.ams2.redhat.com [10.36.6.136])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u6D9RI1J010236
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 13 Jul 2016 05:27:19 -0400
To: Jan Viktorin <viktorin@rehivetech.com>, dev@dpdk.org
References: <20160713092419.14425-1-viktorin@rehivetech.com>
Cc: Jianfeng Tan <jianfeng.tan@intel.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Huawei Xie <huawei.xie@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <7046512f-49fa-30b4-9238-318617cc04be@redhat.com>
Date: Wed, 13 Jul 2016 11:27:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160713092419.14425-1-viktorin@rehivetech.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Wed, 13 Jul 2016 09:27:22 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] virtio: fix missing curly braces
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2016 09:27:23 -0000

Hi Jan,

On 07/13/2016 11:24 AM, Jan Viktorin wrote:
> GCC 6 is complaining and seems to be correct here.
>
> virtio_user_ethdev.c:345:2: error:
> 	this ‘if’ clause does not guard... [-Werror=misleading-indentation]
>    if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
>    ^~
>
> virtio_user_ethdev.c:348:3: note:
> 	...this statement, but the latter is misleadingly indented
> 	as if it is guarded by the ‘if’
>     if (ret < 0) {
>
> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>
I already fixed it yesterday:
http://dpdk.org/dev/patchwork/patch/14780/

Thanks,
Maxime