Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception

["Kinsella, Ray" <mdr@ashroe.eu>]

On 01/02/2021 18:08, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
> 
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  devtools/libabigail.abignore | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index ab5db240e7..6c0b38984e 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -13,8 +13,6 @@
>          name_regexp = _pmd_info$
>  
>  ; Explicit ignore for driver-only ABI
> -[suppress_type]
> -        name = eth_dev_ops
>  [suppress_function]
>          name_regexp = rte_vdev_(|un)register
>  

eth_dev_ops structure are not exported, so there is no symbol that is actually
changing here. The type definition _only_ will be in DPDK 20.11 public headers, 
but is removed in DPDK 21.02.

I find it a little strange that libabigail is baulking when the type is changed 
(see 1fe3eef5e9b) but not when it is entirely removed?

Ray K