From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 257341E20 for ; Mon, 19 Feb 2018 15:21:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2018 06:21:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,535,1511856000"; d="scan'208";a="21305647" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 19 Feb 2018 06:21:45 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 19 Feb 2018 06:21:44 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.243]) by FMSMSX109.amr.corp.intel.com ([169.254.15.91]) with mapi id 14.03.0319.002; Mon, 19 Feb 2018 06:21:44 -0800 From: "Wiles, Keith" To: Matan Azrad CC: Thomas Monjalon , Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Thread-Index: AQHTqH9YhrarJeV/c02BHfwy89nKE6Oq0lgAgADxi4CAAIPYAIAABQiAgAACSIA= Date: Mon, 19 Feb 2018 14:21:43 +0000 Message-ID: <705E16BA-30AC-4306-B801-EDB06D810185@intel.com> References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <28F3DAA5-CCAB-4D2E-A6C9-FEB685A619C8@intel.com> <8522C580-BFB3-4D1B-A331-45DA05427D50@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.32.238] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 14:21:46 -0000 > On Feb 19, 2018, at 8:13 AM, Matan Azrad wrote: >=20 > Hi Wiles >=20 > From: Wiles, Keith, Monday, February 19, 2018 3:56 PM >>> On Feb 19, 2018, at 12:03 AM, Matan Azrad wrote: >>>> Is this the type of API that needs to be marked experimental, >>>=20 >>> I think it is relevant to any exposed API(not only for internal librari= es). >>>=20 >>>> we should be able to prove these functions, correct? >>>=20 >>> Don't we need to prove any function in DPDK? >>> What is your point? >>=20 >>=20 >> My point is this is a inline function and can not be placed in the .map = file as a >> external API. >=20 > Doesn't each API in .h file external? Why not? > If it shouldn't be external and should be in .h file, I think it should b= e marked as internal, no? We do not do a great job of using private headers as most of our headers ar= e public ones and in the case or private they would not be external. >=20 >> These simple type of APIs are easy to prove and making them >> experimental seems to just cause an extra step. >=20 > As Thomas mentioned here: > https://dpdk.org/ml/archives/dev/2018-January/087719.html >=20 > Any new API should be experimental. >=20 > Thomas, Is it different for .h file inline APIs? >=20 >> If the functions are not required that is a different problem or if the = API is really only ever used by a >> single function or module of files then it should be moved to the module= /file >> and made locate to the module/file. >=20 > Agree. > Looks like this function makes sense and may be used by other modules lat= er. >=20 Regards, Keith